Hi,

On 11.07.20 08:45, Rosen Penev wrote:
Found with shellcheck.

Signed-off-by: Rosen Penev <ros...@gmail.com>
---
  v2: rebased
  scripts/clean-package.sh | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh
index 4b536c8a48..03e49df3e7 100755
--- a/scripts/clean-package.sh
+++ b/scripts/clean-package.sh
@@ -8,13 +8,13 @@ IFS=$'\n'
        echo "File/directory not found"
        exit 1
  }
-cat "$1" | (
+(
        cd "$2" || exit 1
        while read -r entry; do
                [ -n "$entry" ] || break
                [ ! -d "$entry" ] || [ -L "$entry" ] && rm -f "$entry"
        done
-)
+) < "$1"
  sort -r "$1" | (
        cd "$2" || exit 1
        while read -r entry; do
I'd be curious whats wrong here, do you mind adding the SC numbers to future improvements?

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to