Re: [PATCH] dnsmasq: 'ipset' config sections

2020-11-11 Thread Hans Dedecker
Hi, On Mon, Nov 9, 2020 at 11:55 AM Aleksandr Mezin wrote: > > Is something wrong with this patch? Should I CC someone to get the > patch reviewed? I'm unable to figure out who is the maintainer of > dnsmasq package Nothing wrong the patch as it looks fine; it just takes some time before somebody

Re: [PATCH] dnsmasq: 'ipset' config sections

2020-11-12 Thread Hans Dedecker
0 at 1:50 AM Hans Dedecker wrote: > > > > Hi, > > > > On Mon, Nov 9, 2020 at 11:55 AM Aleksandr Mezin > > wrote: > > > > > > Is something wrong with this patch? Should I CC someone to get the > > > patch reviewed? I'm unable to figur

[PATCH] iproute2: update to 5.9

2020-11-12 Thread Hans Dedecker
Update iproute2 to latest stable 5.9; for the changes see https://lwn.net/Articles/834755/ Refresh patches Signed-off-by: Hans Dedecker --- package/network/utils/iproute2/Makefile | 4 ++-- .../utils/iproute2/patches/115-add-config-xtlibdir.patch| 2 +- .../utils

[PATCH] dropbear: update to 2.81

2020-11-14 Thread Hans Dedecker
Update dropbear to latest stable 2.81; for the changes see https://matt.ucc.asn.au/dropbear/CHANGES Refresh patches Signed-off-by: Hans Dedecker --- package/network/services/dropbear/Makefile | 6 +++--- .../network/services/dropbear/patches/110-change_user.patch | 2

[PATCH] ethtool: update to version 5.9

2020-11-15 Thread Hans Dedecker
The ipkg sizes changes as follows for mips 24kc : 5.8 : ethtool_5.8-1_mips_24kc.ipk 34930 5.9 : ethtool_5.9-1_mips_24kc.ipk 35241 Signed-off-by: Hans Dedecker --- package/network/utils/ethtool/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH 1/2] kernel: Remove support for MAP-E FMRs RFC 7597

2020-11-22 Thread Hans Dedecker
Hi Hauke, On Sun, Nov 22, 2020 at 12:33 AM Hauke Mehrtens wrote: > > I am not aware that any user space code uses this feature in OpenWrt and > maintaining this patch costs some effort especially when we add a new > kernel major version. The map package supports the creation of map-e interfaces (

Re: [PATCH] netifd: add possibility to switch off route config

2020-11-23 Thread Hans Dedecker
On Mon, Nov 23, 2020 at 12:08 PM Florian Eckert wrote: > > This change adds the new configuration option `disabled` for the route > section, which can be used to temporarily disable the section so that > the route is not set. The advantage is that I do not have to delete the > whole configuration

Re: [PATCH netifd] interface-ip: Normalise prefix address using netmask before using it

2020-11-25 Thread Hans Dedecker
Hi, On Wed, Nov 25, 2020 at 6:36 PM Daniel Gröber wrote: > > When a proto registers a prefix with an address which has bits outside the > netmask set this confuses the prefix-assignment code further down the line. > > For example if we have an interface with > > option ip6prefix fdff::fff

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

2020-11-26 Thread Hans Dedecker
Hi Petr On Thu, Nov 26, 2020 at 9:58 AM Petr Štetiar wrote: > > Hi Hans, > > I've tried to ping you on IRC few days ago as I've found some strange issue > with odhcp6c which leads to OOM/OOPS[1] (log with just the important parts). > It simply happens every time after about 10 hours for me when I

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

2020-11-28 Thread Hans Dedecker
Hi, On Sat, Nov 28, 2020 at 5:04 PM Petr Štetiar wrote: > > Hans Dedecker [2020-11-26 21:19:30]: > > Hi, > > > Is it possible to have a pcap trace of the DHCPv6 messages on the wan ? > > I hope to find some time next weekend to investigate the issue further >

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

2020-12-01 Thread Hans Dedecker
Hi Petr, On Sat, Nov 28, 2020 at 8:48 PM Hans Dedecker wrote: > > Hi, > > On Sat, Nov 28, 2020 at 5:04 PM Petr Štetiar wrote: > > > > Hans Dedecker [2020-11-26 21:19:30]: > > > > Hi, > > > > > Is it possible to have a pcap trace of the DHC

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

2020-12-03 Thread Hans Dedecker
On Wed, Dec 2, 2020 at 9:25 PM Petr Štetiar wrote: > > Hans Dedecker [2020-12-01 21:12:30]: > > Hi, > > > Can you check if commit > > https://git.openwrt.org/?p=project/odhcp6c.git;a=commit;h=a7b2221f687264c020b7a18a4e690d79f312a667 > > fixes the issue in you

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

2020-12-04 Thread Hans Dedecker
On Fri, Dec 4, 2020 at 11:45 AM Petr Štetiar wrote: > > Hans Dedecker [2020-12-03 21:18:11]: > > Hi, > > > Looking into the new pcap capture I must admit I've never seen such a DHCPv6 > > server with such weird behavior. > > it's OpenWrt so odhcpd. Coul

Re: [PATCH] netifd: add segment routing support

2020-12-12 Thread Hans Dedecker
Hi, On Wed, Dec 2, 2020 at 3:33 PM wrote: > > From: Nick Hainke > > seg6_enabled - Bool > Accept or drop SR-enabled IPv6 packets on this interface. > > More Information: > https://www.kernel.org/doc/html/latest/networking/seg6-sysctl.html > > Now you can set as interface option > option ip6s

Re: [PATCH] netifd: add segment routing support

2020-12-13 Thread Hans Dedecker
On Sat, Dec 12, 2020 at 9:51 PM wrote: > > From: Nick Hainke > > seg6_enabled - Bool > Accept or drop SR-enabled IPv6 packets on this interface. > > More Information: > https://www.kernel.org/doc/html/latest/networking/seg6-sysctl.html > > Now you can set as interface option > option ip6segme

Re: [PATCH] glibc: add arc700 patch

2020-12-26 Thread Hans Dedecker
Hi, On Fri, Dec 25, 2020 at 1:37 AM Rosen Penev wrote: > > glibc does not officially support ARC700 so this adds the missing > pieces. I looked at uClibc-ng and a patch by Synopsis for glibc. > > ran make toolchain/glibc/refresh to clean up fuzz. > > Signed-off-by: Rosen Penev > --- > toolchain

[PATCH] [netifd] interface-ip: fix ipv6 routing loop

2021-01-01 Thread Hans Dedecker
iif eth0 failed_policy 420015: from all iif eth4 failed_policy 420015: from all iif eth4 failed_policy 420019: from all iif br-lan failed_policy Signed-off-by: Hans Dedecker --- interface-ip.c | 70 -- iprule.h | 10

Re: [PATCH] odhcpd: add option for setting preferred lifetime

2021-01-02 Thread Hans Dedecker
On Fri, Jan 1, 2021 at 9:15 PM wrote: > > From: Nick Hainke > > "valid_lft" and "preferred_lft" are different. If the "preferred_lft" > is expired the prefix should be avoided in source prefix selection. > However, the interface is allowed to still receive downstream traffic. > > ra_use_preferred

[PATCH netifd v2] interface-ip: fix ipv6 routing loop

2021-01-03 Thread Hans Dedecker
: Hans Dedecker --- v2: Keep unreachable route in the routing table dropping traffic from the lan not matching any routing rules with an ICMPv6 unreachable interface-ip.c | 77 ++ iprule.h | 10 --- 2 files changed, 71 insertions(+), 16

Re: [PATCH] odhcpd: add option to use absolute timestamps

2021-02-06 Thread Hans Dedecker
On Sat, Jan 30, 2021 at 5:33 PM Nick Hainke wrote: > > Until now it is not possible to give absolute timestamps in odhcpd. > This means that on every new RA or request, the timestamp is renewed. > Further, the valid and preferred lifetimes are not synced between all > devices. > > There are severa

[OpenWrt-Devel] [PATCH] odhcp6c: Fix white space errors

2015-04-28 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- package/network/ipv6/odhcp6c/files/dhcpv6.script | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/package/network/ipv6/odhcp6c/files/dhcpv6.script b/package/network/ipv6/odhcp6c/files/dhcpv6.script index 5f3ff15..5e5b9a9

[OpenWrt-Devel] [PATCH] uci: properly close input before exit

2015-04-28 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- cli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cli.c b/cli.c index 557472e..e1e0a66 100644 --- a/cli.c +++ b/cli.c @@ -687,6 +687,7 @@ int main(int argc, char **argv) break; case &#

[OpenWrt-Devel] [PATCH] ubus: Fix memleak in examples/client in case of failure

2015-04-28 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- examples/client.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/client.c b/examples/client.c index 952ab54..7ef5663 100644 --- a/examples/client.c +++ b/examples/client.c @@ -118,6 +118,7 @@ static void test_count(struct uloop_timeout *timeout

[OpenWrt-Devel] [PATCH] odhcpd: Remove prefix class config option as not supported anymore by odhcpd

2015-04-28 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- package/network/services/odhcpd/Makefile | 8 1 file changed, 8 deletions(-) diff --git a/package/network/services/odhcpd/Makefile b/package/network/services/odhcpd/Makefile index 635a251..22b9e38 100644 --- a/package/network/services/odhcpd/Makefile

[OpenWrt-Devel] [RFC] netifd: Default enabling of transmit/receive packet steering

2015-04-29 Thread Hans Dedecker
In netifd transmit and receive packet steering is enabled by default since commit 20510bd. This default setting gives problems on our architecture as real time threads are used for networking. The transmit/receive packet steering will move some of the work to softirq which has higher prio than the

[OpenWrt-Devel] [PATCH] netifd: Support for configurable default packet steering

2015-05-11 Thread Hans Dedecker
for all devices without the need to define a device config list which disables receive/transmit packet steering Signed-off-by: Hans Dedecker --- config.c | 6 ++ device.c | 56 +--- device.h | 3 +++ 3 files changed, 58 insertions(+), 7

Re: [OpenWrt-Devel] [PATCH] netifd: Support for configurable default packet steering

2015-05-11 Thread Hans Dedecker
into default_ps in the follow-up patch Hans > > > Cheers, > > Steven > > On 11.05.2015 18:30, Hans Dedecker wrote: >> >> Default packet steering behavior can be configured via the parameter >> force_ps >> in the global section; the default value is t

[OpenWrt-Devel] [PATCH][v2] netifd: Support for configurable default packet steering behavior

2015-05-12 Thread Hans Dedecker
steering for all devices without the need to define a device config list which disables receive/transmit packet steering Signed-off-by: Hans Dedecker --- config.c | 6 ++ device.c | 56 +--- device.h | 3 +++ 3 files changed, 58 insertions(+), 7

Re: [OpenWrt-Devel] WAN dhcp client doesnt recognize unplugged cable and doesnt request new IP on replugged

2015-05-14 Thread Hans Dedecker
On Wed, May 13, 2015 at 12:35 PM, Conor O'Gorman wrote: > On 12/05/15 17:57, Jakub Jančo wrote: >> >> Hello, >> >> I have tplink 1043nd with BB >> >> Problem is that I have dhcp client on WAN and if I unplug cable from >> WAN, it doesnt change status, give up dhcp address. >> >> Even worse is that

Re: [OpenWrt-Devel] WAN dhcp client doesnt recognize unplugged cable and doesnt request new IP on replugged

2015-05-14 Thread Hans Dedecker
WAN interface unless you would use a static IP address. You verified force_link is enabled on the WAN interface for your board ? Hans > > Thanks. > > > -- > S pozdravom Jakub Janco > > 2015-05-14 17:32 GMT+02:00 Hans Dedecker : >> >> On Wed, May 13, 2015 at 12

Re: [OpenWrt-Devel] WAN dhcp client doesnt recognize unplugged cable and doesnt request new IP on replugged

2015-05-15 Thread Hans Dedecker
tect link changes; when the cable is unplugged the NO_CARRIER flag of eth0 needs to be set which can be checked via the ip utility (ip link show) or ifconfig (RUNNING flag not set in this case). Further the cmd ubus call network.device status dumps the netifd status of the devices (including th

[OpenWrt-Devel] [PATCH] netifd: Add old style vlan devices to device list

2015-05-26 Thread Hans Dedecker
ing a network reload. Signed-off-by: Hans Dedecker --- vlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vlan.c b/vlan.c index 354e12f..3d0a4cf 100644 --- a/vlan.c +++ b/vlan.c @@ -130,7 +130,7 @@ static struct device *get_vlan_device(struct device *dev, int id, bool c

Re: [OpenWrt-Devel] Regarding bridge multicast-to-unicast patch

2015-06-03 Thread Hans Dedecker
On Wed, Jun 3, 2015 at 8:50 AM, Steven Barth wrote: > Thanks for the quick reply. > > > On 03.06.2015 08:26, Linus Lüssing wrote: >> For IPv6 and a non-zero IPv4 source address it'll use the normal >> IGMP/MLD querier election mechanism, meaning the one with the lowest >> IP address will become th

[OpenWrt-Devel] [PATCH 1/3] 6rd: Remove sourcerouting parameter registration

2015-06-10 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- package/network/ipv6/6rd/files/6rd.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/package/network/ipv6/6rd/files/6rd.sh b/package/network/ipv6/6rd/files/6rd.sh index 6c68b3b..62d35b6 100644 --- a/package/network/ipv6/6rd/files/6rd.sh +++ b/package/network

[OpenWrt-Devel] [PATCH 3/3] ppp: Unnumbered support

2015-06-10 Thread Hans Dedecker
pted from the peer in the IPCP negotiation. A typical use case is the usage of a public IP subnet on the Lan interface which will be shared by the PPP interface as local IP address. Signed-off-by: Hans Dedecker --- package/network/services/ppp/files/ppp.sh | 66 ++-

[OpenWrt-Devel] [PATCH 2/3] 6to4: Remove sourcerouting parameter registration

2015-06-10 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- package/network/ipv6/6to4/files/6to4.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/package/network/ipv6/6to4/files/6to4.sh b/package/network/ipv6/6to4/files/6to4.sh index 57efc52..a5d0567 100755 --- a/package/network/ipv6/6to4/files/6to4.sh +++ b/package

[OpenWrt-Devel] [PATCHv2] 6rd: Remove sourcerouting parameter registration

2015-06-10 Thread Hans Dedecker
Commit 31214c38c8dd0f70366b523f9b0335145b9386bd removes IPv6 unneeded source-dest-routing workarounds; as a result sourcerouting parameter is unused and can be removed. Signed-off-by: Hans Dedecker --- package/network/ipv6/6rd/files/6rd.sh | 1 - 1 file changed, 1 deletion(-) diff --git a

[OpenWrt-Devel] [PATCHv2] 6to4: Remove sourcerouting parameter registration

2015-06-10 Thread Hans Dedecker
Commit 31214c38c8dd0f70366b523f9b0335145b9386bd removes IPv6 unneeded source-dest-routing workarounds; as a result sourcerouting parameter is unused and can be removed. Signed-off-by: Hans Dedecker --- package/network/ipv6/6to4/files/6to4.sh | 1 - 1 file changed, 1 deletion(-) diff --git a

Re: [OpenWrt-Devel] [PATCH 3/3] ppp: Unnumbered support

2015-06-10 Thread Hans Dedecker
On Wed, Jun 10, 2015 at 2:03 PM, Steven Barth wrote: > Thanks, I already applied the other two. > > > On 10.06.2015 10:39, Hans Dedecker wrote: >> +ppp_select_ipaddr() >> +{ >> + local interface="$1" >> + local addrs=$(uci_get "n

Re: [OpenWrt-Devel] [PATCH 3/3] ppp: Unnumbered support

2015-06-10 Thread Hans Dedecker
On Wed, Jun 10, 2015 at 8:42 PM, Steven Barth wrote: > I just pushed > http://git.openwrt.org/?p=project/netifd.git;a=commit;h=5cf30b59baa03db2448570c78e7e92873555d2ec > (not yet bumped in trunk) which allows generic dependencies to > interfaces by using an empty address, with that you can add a h

Re: [OpenWrt-Devel] [PATCH 3/3] ppp: Unnumbered support

2015-06-11 Thread Hans Dedecker
On Wed, Jun 10, 2015 at 8:42 PM, Steven Barth wrote: > I just pushed > http://git.openwrt.org/?p=project/netifd.git;a=commit;h=5cf30b59baa03db2448570c78e7e92873555d2ec > (not yet bumped in trunk) which allows generic dependencies to > interfaces by using an empty address, with that you can add a h

[OpenWrt-Devel] [PATCHv2] ppp : Unnumbered support

2015-06-12 Thread Hans Dedecker
l IP will be accepted from the peer in the IPCP negotiation. A typical use case is the usage of a public IP subnet on the Lan interface which will be shared by the PPP interface as local IP address. Signed-off-by: Hans Dedecker --- package/network/services/ppp/files/ppp.sh | 40 +

[OpenWrt-Devel] [PATCH] netifd: Add dadtransmits config option

2015-06-25 Thread Hans Dedecker
Config option dadtransmits allows to configure the amount of Duplicate Address Detection probes to be sent Signed-off-by: Hans Dedecker --- device.c | 12 +++- device.h | 5 - system-linux.c | 29 + 3 files changed, 36 insertions(+), 10

[OpenWrt-Devel] [PATCH 1/2] dnsmasq: enable extra tracing by default when UCI parameter logqueries is set

2015-07-06 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- package/network/services/dnsmasq/files/dnsmasq.init | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/dnsmasq/files/dnsmasq.init b/package/network/services/dnsmasq/files/dnsmasq.init index b0a5fbc..bbe2b56 100644 --- a

[OpenWrt-Devel] [PATCH 2/2] dnsmasq: Add sequential_ip UCI parameter

2015-07-06 Thread Hans Dedecker
When enabled the dnsmasq DHCP server allocates the IP addresses sequentially starting from the lowest available IP address. Signed-off-by: Hans Dedecker --- package/network/services/dnsmasq/files/dnsmasq.init | 1 + 1 file changed, 1 insertion(+) diff --git a/package/network/services/dnsmasq

[OpenWrt-Devel] [PATCH 2/4] netifd: Fix device usage after free

2015-08-04 Thread Hans Dedecker
Prevent new device from being freed in device_replace when device_unlock is called along the function chain triggered by setting the old device as not present Signed-off-by: Hans Dedecker --- device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/device.c b/device.c index 6f31e36

[OpenWrt-Devel] [PATCH 3/4] netifd: Remove obsolete device_set_present in device_replace

2015-08-04 Thread Hans Dedecker
New device does not need to be set present as device_check_state called via device_init sets the device present after probing the kernel device Signed-off-by: Hans Dedecker --- device.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/device.c b/device.c index 59a57f4

[OpenWrt-Devel] [PATCH 4/4] netifd: Spawn device events when registering dependency in device_replace

2015-08-04 Thread Hans Dedecker
Spawn device events when adding dependency in device_replace so the dependency installer gets the actual device status Signed-off-by: Hans Dedecker --- device.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/device.c b/device.c index 1636611

[OpenWrt-Devel] [PATCH 1/4] netifd: Fix SEG fault when device cannot be allocated

2015-08-04 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/device.c b/device.c index b5bee11..6f31e36 100644 --- a/device.c +++ b/device.c @@ -741,6 +741,9 @@ device_reset_old(void) continue; ndev

Re: [OpenWrt-Devel] [PATCH] [netifd] enable MULTICAST on GRE

2015-08-15 Thread Hans Dedecker
On Sat, Aug 15, 2015 at 3:09 AM, Nick Podolak wrote: > This patch enables multicast by for gre tunnels. I've only ever used > GRE to enable routing algorithms and other multicast applications over > otherwise non-multicast capable links (wan, ipsec) so this default > behavior makes more sense to

Re: [OpenWrt-Devel] [PATCH] [netifd] enable MULTICAST on GRE

2015-08-17 Thread Hans Dedecker
On Mon, Aug 17, 2015 at 4:40 PM, Nick Podolak wrote: > > On Sat, Aug 15, 2015 at 3:25 AM, Hans Dedecker wrote: > >> It would be better to make this a device setting like promiscuous >>> mode,macaddr, etc ... so it can be configured via UCI for every device and >>

[OpenWrt-Devel] [PATCH 1/2] netifd : Apply device settings when existing device becomes external

2015-09-01 Thread Hans Dedecker
Make sure device settings are applied when existing device becomes external Signed-off-by: Hans Dedecker --- device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/device.c b/device.c index 4a8db70..0d73138 100644 --- a/device.c +++ b/device.c @@ -446,6 +446,7 @@ device_get(const char

[OpenWrt-Devel] [PATCH 2/2] netifd: Don't call set_state for external device in device_claim

2015-09-01 Thread Hans Dedecker
e the device already exists in the kernel. Therefore move the external device check from device_set_state to device_claim so external vlan/macvlan devices are not created again and can also be external. Signed-off-by: Hans Dedecker --- device.c | 9 - 1 file changed, 4 insertions(

Re: [OpenWrt-Devel] [PATCH 2/2] netifd: Don't call set_state for external device in device_claim

2015-09-01 Thread Hans Dedecker
On Tue, Sep 1, 2015 at 2:49 PM, Felix Fietkau wrote: > On 2015-09-01 14:43, Hans Dedecker wrote: > > The function set_state disable is not called for external devices in > device_release > > which means for external vlan/macvlan devices they won't be deleted. >

Re: [OpenWrt-Devel] [PATCH 2/2] netifd: Don't call set_state for external device in device_claim

2015-09-02 Thread Hans Dedecker
On Wed, Sep 2, 2015 at 10:31 AM, Felix Fietkau wrote: > On 2015-09-01 15:53, Hans Dedecker wrote: > > > > > > On Tue, Sep 1, 2015 at 2:49 PM, Felix Fietkau > <mailto:n...@openwrt.org>> wrote: > > > > On 2015-09-01 14:43, Hans Dedecker wrote: &g

[OpenWrt-Devel] [PATCH netifd 1/6] device: Resolve ifindex for external claimed devices

2015-09-09 Thread Hans Dedecker
Fixes regression issues introduced by commit 3224b80 as external (PPP) device ifindex was not in sync with kernel device ifindex due to re-creation of the device by the PPP daemon Signed-off-by: Hans Dedecker --- device.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff

[OpenWrt-Devel] [PATCH netifd 2/6] iprule: Insert network and address ip rules before main table lookup rule

2015-09-09 Thread Hans Dedecker
checked first if the ip rule matches. Signed-off-by: Hans Dedecker --- iprule.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/iprule.h b/iprule.h index b4b124c..e1ac84b 100644 --- a/iprule.h +++ b/iprule.h @@ -17,8 +17,8 @@ #include "interface-ip.h"

[OpenWrt-Devel] [PATCH netifd 3/6] interface-ip: Remove ip loop policy rules as kernel issue is fixed

2015-09-09 Thread Hans Dedecker
Remove ip loop policy rules as workaround for the kernel using unspecified address to lookup locally originating traffic is fixed by http://lkml.iu.edu/hypermail/linux/kernel/1505.0/03094.html Signed-off-by: Hans Dedecker --- interface-ip.c | 23 +-- 1 file changed, 1

[OpenWrt-Devel] [PATCH netifd 4/6] interface-ip: Insert network and address ip rules for external addresses as well

2015-09-09 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- interface-ip.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/interface-ip.c b/interface-ip.c index 6c152b6..43b63c7 100644 --- a/interface-ip.c +++ b/interface-ip.c @@ -500,9 +500,7 @@ interface_update_proto_addr

[OpenWrt-Devel] [PATCH netifd 6/6] interface-ip: Set route table when enabling interface ip settings

2015-09-09 Thread Hans Dedecker
Routes are now inserted in the correct routing table when interface ip4table and/or ip6table was changed during interface_change_config Signed-off-by: Hans Dedecker --- interface-ip.c | 9 + 1 file changed, 9 insertions(+) diff --git a/interface-ip.c b/interface-ip.c index d5f6aff

[OpenWrt-Devel] [PATCH netifd 5/6] interface-ip: Don't create ip network rule if address mask is equal to full mask

2015-09-09 Thread Hans Dedecker
Prevents the creation of identical address and network IP rules Signed-off-by: Hans Dedecker --- interface-ip.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/interface-ip.c b/interface-ip.c index 43b63c7..d5f6aff 100644 --- a/interface-ip.c +++ b/interface

[OpenWrt-Devel] [PATCH] dnsmasq: Add option --min-port

2016-01-14 Thread Hans Dedecker
By default dnsmasq uses random ports for outbound dns queries; when the minport UCI option is specified the ports used will always be larger than the specified value. This is usefull for systems behind firewalls. Signed-off-by: Hans Dedecker --- package/network/services/dnsmasq/Makefile

[OpenWrt-Devel] [PATCH] dnsmasq: Don't add local hostname if ula prefix is not specified

2016-01-25 Thread Hans Dedecker
parameters ip6hint and ip6ifaceid and thus not always ula prefix suffixed with 1 Signed-off-by: Hans Dedecker --- package/network/services/dnsmasq/Makefile | 2 +- package/network/services/dnsmasq/files/dnsmasq.init | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[OpenWrt-Devel] [PATCH netifd 01/16] device: Fix possible segfault

2016-02-01 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/device.c b/device.c index 6dc4fa9..65183f3 100644 --- a/device.c +++ b/device.c @@ -429,6 +429,9 @@ device_create_default(const char *name, bool external) D(DEVICE, "Create simple d

[OpenWrt-Devel] [PATCH netifd 02/16] vlan: Fix possible segfault

2016-02-01 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- vlan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vlan.c b/vlan.c index 8e7141f..ac434ce 100644 --- a/vlan.c +++ b/vlan.c @@ -120,6 +120,8 @@ static struct device *get_vlan_device(struct device *dev, int id, bool create) D(DEVICE, "Create

[OpenWrt-Devel] [PATCH netifd 03/16] ubus: Fix possible segfault

2016-02-01 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- ubus.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ubus.c b/ubus.c index 454b42d..4184301 100644 --- a/ubus.c +++ b/ubus.c @@ -969,6 +969,9 @@ static void netifd_add_iface_object(void) int i; methods = calloc(1, sizeof

[OpenWrt-Devel] [PATCH netifd 04/16] tunnel: Fix uninitialized access

2016-02-01 Thread Hans Dedecker
Fix tb_dev uninitialized access by device_init_settings Signed-off-by: Hans Dedecker --- tunnel.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tunnel.c b/tunnel.c index aa670a3..524fd43 100644 --- a/tunnel.c +++ b/tunnel.c @@ -49,12 +49,11 @@ tunnel_reload(struct

[OpenWrt-Devel] [PATCH netifd 05/16] tunnel: Fix possible segfault

2016-02-01 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- tunnel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tunnel.c b/tunnel.c index 524fd43..4a6c409 100644 --- a/tunnel.c +++ b/tunnel.c @@ -67,6 +67,9 @@ tunnel_create(const char *name, struct blob_attr *attr) struct device *dev; tun

[OpenWrt-Devel] [PATCH netifd 06/16] proto: Fix possible buffer overflow due to non null terminated string

2016-02-01 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- proto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto.c b/proto.c index eaec913..b91fcde 100644 --- a/proto.c +++ b/proto.c @@ -287,7 +287,7 @@ static bool parse_prefix_option(struct interface *iface, const char *str, size_t len

[OpenWrt-Devel] [PATCH netifd 07/16] proto-shell: Fix possible segfault

2016-02-01 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- proto-shell.c | 5 + 1 file changed, 5 insertions(+) diff --git a/proto-shell.c b/proto-shell.c index 8a3ff69..25dec00 100644 --- a/proto-shell.c +++ b/proto-shell.c @@ -708,6 +708,8 @@ proto_shell_add_host_dependency(struct proto_shell_state *state, struct

[OpenWrt-Devel] [PATCH netifd 09/16] interface-ip: Fix possbile segfaults

2016-02-01 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- interface-ip.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/interface-ip.c b/interface-ip.c index 919c8cc..eb585f5 100644 --- a/interface-ip.c +++ b/interface-ip.c @@ -366,7 +366,7 @@ interface_ip_add_route(struct

[OpenWrt-Devel] [PATCH netifd 08/16] interface: Fix possbile segfault

2016-02-01 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- interface.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/interface.c b/interface.c index 2aab37c..7b18cef 100644 --- a/interface.c +++ b/interface.c @@ -189,6 +189,9 @@ interface_add_data(struct interface *iface, const struct blob_attr *data

[OpenWrt-Devel] [PATCH netifd 11/16] handler: Fix memory leak

2016-02-01 Thread Hans Dedecker
Call globfree to free dynamically allocated storage from a previous glob call Signed-off-by: Hans Dedecker --- handler.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/handler.c b/handler.c index f81a7c5..0c4627f 100644 --- a/handler.c +++ b/handler.c @@ -128,10

[OpenWrt-Devel] [PATCH netifd 12/16] proto: Fix possible segfaults

2016-02-01 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- proto.c | 9 + 1 file changed, 9 insertions(+) diff --git a/proto.c b/proto.c index b91fcde..45eeb4b 100644 --- a/proto.c +++ b/proto.c @@ -101,6 +101,9 @@ alloc_device_addr(bool v6, bool ext) struct device_addr *addr; addr = calloc(1

[OpenWrt-Devel] [PATCH netifd 10/16] interface-event: Fix possible out of bounds array access

2016-02-01 Thread Hans Dedecker
The array eventnames is of size 3 while the interface_event type may use the indexes 3 or 4. Signed-off-by: Hans Dedecker --- interface-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interface-event.c b/interface-event.c index cfbc15c..3cdfbdb 100644 --- a/interface

[OpenWrt-Devel] [PATCH netifd 13/16] system-linux: Fix memory leak

2016-02-01 Thread Hans Dedecker
Call globfree to free dynamically allocated storage from a previous glob call Signed-off-by: Hans Dedecker --- system-linux.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/system-linux.c b/system-linux.c index 909ba0f..9978ade 100644 --- a/system-linux.c +++ b/system-linux.c @@ -1140,6

[OpenWrt-Devel] [PATCH netifd 14/16] alias: Fix possible segfault

2016-02-01 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- alias.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/alias.c b/alias.c index 01bec41..1f23da0 100644 --- a/alias.c +++ b/alias.c @@ -112,6 +112,9 @@ alias_device_create(const char *name, struct blob_attr *attr) struct alias_device *alias

[OpenWrt-Devel] [PATCH netifd 15/16] device: Support multicast config option

2016-02-01 Thread Hans Dedecker
Make multicast device flag configurable by extending device attributes with the multicast attribute Signed-off-by: Hans Dedecker Signed-off-by: Nick Podolak --- Based on a patch by Nick Podolak (https://lists.openwrt.org/pipermail/openwrt-devel/2015-October/036654.html) with some minor tweaks

[OpenWrt-Devel] [PATCH netifd 16/16] device: Fix null pointer derefence if device is unset

2016-02-01 Thread Hans Dedecker
Fix null pointer deference in device_claim if device is unset in device_user struct. Typically this is observed when the parent device is removed from (mac)vlan device config followed by a network reload Signed-off-by: Hans Dedecker --- device.c | 13 ++--- 1 file changed, 10 insertions

[OpenWrt-Devel] [PATCH] gre: Support multicast configurable gre interfaces

2016-02-01 Thread Hans Dedecker
UCI paramater multicast is added which allows to toggle multicast support on gre interfaces. By default multicast support is enabled as gre tunnels are often used in combination with routing protocols using multicast. Signed-off-by: Hans Dedecker Signed-off-by: Nick Podolak --- Based on a

[OpenWrt-Devel] [PATCH netifd] interface-ip : Don't handle external addresses and routes

2016-02-15 Thread Hans Dedecker
Prevent external routes and address being added or deleted when changing the state of the interface ip settings Signed-off-by: Hans Dedecker --- interface-ip.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/interface-ip.c b/interface-ip.c index eb585f5..26a2865 100644 --- a/interface

[OpenWrt-Devel] [PATCH] odhcp6c : Silence mtu write error warnings

2016-03-09 Thread Hans Dedecker
Silence warning "daemon.notice netifd: wan6 (1139): sh: write error: Invalid argument" when an invalid MTU is received via RA as kernel refuses to accept IPv6 mtu values which are smaller than 1280 and bigger than the device mtu. Signed-off-by: Hans Dedecker --- package/network/ip

[OpenWrt-Devel] [PATCH netifd] alias : Fix interface aliased on top of a static interface not getting active

2016-03-31 Thread Hans Dedecker
via alias_notify_device. As a result alias_set_device_state when called will overwrite the device with an invalid pending device meaning the interface will not be set available anymore and thus will stay down. Signed-off-by: Hans Dedecker --- alias.c | 9 - 1 file changed, 8 insertions

[OpenWrt-Devel] [PATCH 1/2] dnsmasq: Fix dhcp option parsing

2016-03-31 Thread Hans Dedecker
Parse dhcp options as a config list; this fixes dhcp options which contain a white space as it resulted into an invalid config Signed-off-by: Hans Dedecker --- package/network/services/dnsmasq/files/dnsmasq.init | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a

[OpenWrt-Devel] [PATCH] netifd: Send DHCP release when client exits

2016-03-31 Thread Hans Dedecker
Let DHCP client send a release when it exists so the DHCP server is informed the IP address is released and allowing to clean up IP/mac state info in intermediate devices. Signed-off-by: Hans Dedecker --- package/network/config/netifd/files/lib/netifd/proto/dhcp.sh | 2 +- 1 file changed, 1

[OpenWrt-Devel] [PATCH 2/2] dnsmasq: Add enable parameter in the UCI DHCP host section

2016-03-31 Thread Hans Dedecker
Parameter allows to enable/disable static leases; by default the value is 1 to keep backwards compatibility Signed-off-by: Hans Dedecker --- package/network/services/dnsmasq/files/dnsmasq.init | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/network/services/dnsmasq/files

Re: [OpenWrt-Devel] [PATCH 1/2] dnsmasq: Fix dhcp option parsing

2016-03-31 Thread Hans Dedecker
On Thu, Mar 31, 2016 at 12:32 PM, Jo-Philipp Wich wrote: > Hi, > > various configurations out there use "option dhcp_option ..." still, did > you check whether this works yet after your patch? > Hi Jow, Good point; if dhcp_option is specified as "option dhcp_option" it will fail Patch was based

Re: [OpenWrt-Devel] [PATCH] netifd: Send DHCP release when client exits

2016-04-18 Thread Hans Dedecker
On Sun, Apr 17, 2016 at 2:07 PM, Hauke Mehrtens wrote: > On 03/31/2016 12:18 PM, Hans Dedecker wrote: > > Let DHCP client send a release when it exists so the DHCP server is > > informed the IP address is released and allowing to clean up IP/mac > > state info in

Re: [OpenWrt-Devel] [PATCH] netifd: Send DHCP release when client exits

2016-04-18 Thread Hans Dedecker
On Mon, Apr 18, 2016 at 1:22 PM, Bjørn Mork wrote: > Hans Dedecker writes: > > On Sun, Apr 17, 2016 at 2:07 PM, Hauke Mehrtens > wrote: > > > >> https://www.ietf.org/rfc/rfc2131.txt says in section 3.2 part 4.: > >> Note that in this case,

[OpenWrt-Devel] [PATCH v2 1/6] netifd: Make sending DHCP release configurable via uci when client exits

2016-04-27 Thread Hans Dedecker
Make sending a DHCP release configurable when the client exits allowing to clean up IP/mac state info in intermediate devices. Signed-off-by: Hans Dedecker --- v1 -> v2 : Make sending DHCP release configurable via uci package/network/config/netifd/files/lib/netifd/proto/dhcp.sh

[OpenWrt-Devel] [PATCH 2/6] dropbear: Make utmp and putuline support configurable via seperate config options

2016-04-27 Thread Hans Dedecker
Utmp support tracks who is currenlty logged in by logging info to the file /var/run/utmp (supported by busybox) Putuline support will use the utmp structure to write to the utmp file Signed-off-by: Hans Dedecker --- package/network/services/dropbear/Config.in | 15 +++ package

[OpenWrt-Devel] [PATCH 3/6] iproute2: Add package for nstat utility

2016-04-27 Thread Hans Dedecker
Add support for the command line utility nstat displaying network statistics Signed-off-by: Hans Dedecker --- package/network/utils/iproute2/Makefile | 11 +++ 1 file changed, 11 insertions(+) diff --git a/package/network/utils/iproute2/Makefile b/package/network/utils/iproute2

[OpenWrt-Devel] [PATCH 4/6] dropbear: Add procd interface triggers when interface config is specified

2016-04-27 Thread Hans Dedecker
A dropbear instance having an interface config won't start if the interface is down as no IP address is available. Adding interface triggers for each configured interface executing the dropbear reload script will start the dropbear instance when the interface is up. Signed-off-by: Hans Ded

[OpenWrt-Devel] [PATCH 5/6] dnsmasq: Add conntrack support in the full variant

2016-04-27 Thread Hans Dedecker
accouting and firewall. Signed-off-by: Hans Dedecker --- package/network/services/dnsmasq/Makefile | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/package/network/services/dnsmasq/Makefile b/package/network/services/dnsmasq/Makefile index a5b96a3..3f12a40 100644

[OpenWrt-Devel] [PATCH 6/6] ppp: Add ppp-mod-passwordfd subpackage to ppp

2016-04-27 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- package/network/services/ppp/Makefile | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/package/network/services/ppp/Makefile b/package/network/services/ppp/Makefile index e0acf59..23c1e93 100644 --- a/package/network

[OpenWrt-Devel] [PATCH] xtables-addons: Fix Lua packet script implementation

2016-04-28 Thread Hans Dedecker
_buff Signed-off-by: Hans Dedecker Signed-off-by: Stijn Cleynhens --- .../xtables-addons/patches/201-fix-lua-packetscript.patch | 15 +++ 1 file changed, 15 insertions(+) diff --git a/package/network/utils/xtables-addons/patches/201-fix-lua-packetscript.patch b/package/network/

Re: [OpenWrt-Devel] [PATCH v2 1/6] netifd: Make sending DHCP release configurable via uci when client exits

2016-04-28 Thread Hans Dedecker
On Thu, Apr 28, 2016 at 12:26 PM, Jo-Philipp Wich wrote: > Hi, > > I assume this one supersedes "netifd: Send DHCP release when client > exits" ? > Correct > > Asking because I see no deletion of the "-R" option which would be > introduced by the other patch. > > If this is the case can you slig

[OpenWrt-Devel] [PATCH] netifd: Add configurable DHCP release behavior

2016-04-28 Thread Hans Dedecker
Make sending a DHCP release configurable when the client exits allowing to clean up IP/mac state info in intermediate devices. Signed-off-by: Hans Dedecker --- v1 -> v2 : Make sending DHCP release configurable via uci package/network/config/netifd/files/lib/netifd/proto/dhcp.sh

Re: [OpenWrt-Devel] [PATCH] set mark for locally generated traffic in OUTPUT chain

2016-04-28 Thread Hans Dedecker
On Thu, Apr 28, 2016 at 3:31 PM, Daniel Golle wrote: > Hi Jo! > > On Thu, Apr 28, 2016 at 03:03:49PM +0200, Jo-Philipp Wich wrote: > > my stomach feeling tells me that this is okay but can you elaborate on > > the change? > > Currently all marking always happends in the PREROUTING chain. This > d

Re: [OpenWrt-Devel] [PATCH 2/6] dropbear: Make utmp and putuline support configurable via seperate config options

2016-04-29 Thread Hans Dedecker
On Fri, Apr 29, 2016 at 1:24 PM, John Crispin wrote: > Hi, > > comment inline > > On 27/04/2016 11:13, Hans Dedecker wrote: > > Utmp support tracks who is currenlty logged in by logging info to the > file /var/run/utmp (supported by busybox) > > Putuline support

  1   2   3   4   5   >