Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-26 Thread Denis K
Hello Adrian > > +&spi { > > + status = "okay"; > > + > > + compatible = "qca,ar7100-spi"; > > + > > + cs-gpios = <0>, <&gpio_latch 0 GPIO_ACTIVE_LOW>; > > Are you sure you need cs-gpios here? We've removed it everywhere else (for > &spi node): > https://github.com/openwrt/openwrt/com

Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-26 Thread Denis K
Hello Sergey > the device tree has a dualistic > nature, on one hand it is a place for driver configuration, on the > other hand it is a way to document board stuff interconnections I agree with you here, but I don't think that I should insist on this.

Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-26 Thread Denis K
> I am just curious, why did you place beeper and LEDs in the root node, > but specify latch and NAND as the AHB bus child nodes? Ack, you are right. > > + /* NAND control gpios */ > > + read-gpios = <&gpio_latch 3 GPIO_ACTIVE_HIGH>; > > + rdy-gpios = <&g

Re: [PATCH 2/2] ath79: mikrotik: Change the moment of routerboot partition parser init

2021-11-10 Thread Denis K
> Hi, wouldn't it be better for the rb_hardconfig_init to return > -EPROBE_DEFER so the > the core can try probing later? Hello, Robert! I've tried what you suggested (return -EPROBE_DEFER from rb_hardconfig_init and routerboot_init). It doesn't work. do_one_initcall() from linux-5.4.158/init/main.

Re: [PATCH 2/2] ath79: mikrotik: Change the moment of routerboot partition parser init

2021-11-10 Thread Denis K
Hello, Thibaut! Here is a dmesg output as an attachment. I've added printk into rb_hardconfig_init: [0.806327] rb_hardconfig_init: get_mtd_device_nm returns error: -19 dmesg.gz Description: application/gzip ___ openwrt-devel mailing list openwrt-de

Re: [PATCH 2/2] ath79: mikrotik: Change the moment of routerboot partition parser init

2021-11-11 Thread Denis K
Hello, Thibaut! > because the driver depends on SPI routines, it should be linked and loaded > after SPI > rb_hardconfig should never be loaded where it is: platform drivers (where it > is currently hooked) are linked much later in kernel Maybe the order of init functions of SPI and routerboot

Re: [PATCH 2/2] ath79: mikrotik: Change the moment of routerboot partition parser init

2021-11-12 Thread Denis K
> OK, let’s do that as a workaround and hope that deferred probes won’t overlap > past late_initcall() What about using register_mtd_user function: routerboot can call rb_hardconfig_init and rb_softconfig_init when mtd subsystem notifies it about a new mtd device? It works. --- .../drivers/platf

Re: [PATCH 2/2] ath79: mikrotik: Change the moment of routerboot partition parser init

2021-11-15 Thread Denis K
I've tested it (on 5.4 and 5.10). On reboot I've had this kernel panic: [ 1028.460043] Reserved instruction in kernel code[#1]: [ 1028.465191] CPU: 0 PID: 2406 Comm: procd Not tainted 5.4.158 #0 [ 1028.471300] $ 0 : 0001 [ 1028.476702] $ 4 : 8342118c 806adf50 000

Re: [PATCH 2/2] ath79: mikrotik: Change the moment of routerboot partition parser init

2021-11-16 Thread Denis K
I got it! _exit macro of rb_hardconfig_init seems to cause this kernel panic. Here is a patch. Regards, Denis. From e042f7d0a72ff9b69fd34ab2f3bac2b698da776f Mon Sep 17 00:00:00 2001 From: Denis Kalashnikov Date: Mon, 15 Nov 2021 11:27:14 +0300 Subject: [PATCH] Fixes to generic: platform/mikrotik:

Re: [PATCH 2/2] ath79: mikrotik: Change the moment of routerboot partition parser init

2021-11-16 Thread Denis K
Thank you for your help, Thibaut. I think we've found the right way of initializing routerboot. I've sent a v2 of the patch. Denis вт, 16 нояб. 2021 г. в 13:20, Thibaut : > > Hi, > > > Le 16 nov. 2021 à 10:46, Denis K a écrit : > > > > I got it! _exit macro

ath79: MikroTik RB912UAG: not working Wi-Fi card in mPCIe slot

2021-12-10 Thread Denis K
> Thomas Hühn wrote: > > We have 5 Mikrotik 912UAG in our Freifunk Network and just build and updated > them today with latest tunk .. we moved vom ar71xx to ath79 successfully, > so far so good .. thx for your upstream work! > > The only thing that is not working: we can not get your 2nd wifi car

Re: [PATCH v2 1/2] ath79: add support for reset key on MikroTik RB912UAG-2HPnD

2021-12-10 Thread Denis K
Mikrotik RB912UAG needs to be better supported in ath79, imho and I'm working on it. Reset key, Gigabit Ethernet, mPCIe slot, UART -- all need to be fixed. This patch adds support for reset key, next one I'm working on will fix mPCIe slot. No ideas about how to fix Gigabit, sigh. Guys, please tell

Re: [PATCH v2 1/2] ath79: add support for reset key on MikroTik RB912UAG-2HPnD

2021-12-10 Thread Denis K
> Added to my staging tree. Thank you, Koen! It is very good news for me this Friday night. Regards, Denis ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH v2 1/2] ath79: add support for reset key on MikroTik RB912UAG-2HPnD

2022-01-17 Thread Denis K
> I'm seeing this in the bootlogs when using this patch: > > [5.183305] gpio-latch gpio_latch: failed to get gpio 7: -517 > [5.235889] rb91x-nand nand_gpio: failed to get gpios: -517 It's okay. The gpio-latch probe function seems to be called before the rb91x-key probe, but it also returns

Re: [PATCH] netifd: add support of GRE tunnel ignore-df option

2023-04-25 Thread Denis K
It seems that we have two options: all is good with the tunnel path, so in this case we use default "pmtudisc noignore-df". Or something wrong and ICMP replies with "fragmentation needed" do not come back, so in this case we use "nopmtudisc ignore-df". But I would leave the possibility of selective