> I am just curious, why did you place beeper and LEDs in the root node, > but specify latch and NAND as the AHB bus child nodes? Ack, you are right.
> > + /* NAND control gpios */ > > + read-gpios = <&gpio_latch 3 GPIO_ACTIVE_HIGH>; > > + rdy-gpios = <&gpio_latch 4 GPIO_ACTIVE_HIGH>; > > + nce-gpios = <&gpio_latch 5 GPIO_ACTIVE_LOW>; /* Chip > > Enable */ > > + cle-gpios = <&gpio_latch 6 GPIO_ACTIVE_HIGH>; /* Command > > Latch */ > > + ale-gpios = <&gpio_latch 7 GPIO_ACTIVE_HIGH>; /* Address > > Latch */ > > + nrw-gpios = <&gpio 12 GPIO_ACTIVE_LOW>; /* Read/Write */ > > Why did you use so complex set of properties for configuration? You > anyway add comments to a large portion of properties. So why do not > follow the 'gpio-control-nand' driver approach and simply use a single > 'gpios' array? I'll fix this in v3. Denis _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
