Re: [OpenWrt-Devel] High-level process for releases

2020-01-10 Thread Baptiste Jonglez
d links as needed. Thomas, regarding the step "Update the ToH to work with the new release", do you have documentation on how to do that, and an estimation of how much time it takes? Thanks, Baptiste On 03-12-19, Baptiste Jonglez wrote: > Hi, > > Following some discussion [1]

Re: [OpenWrt-Devel] Question: Migration from ar71xx to ath79

2020-01-11 Thread Baptiste Jonglez
perly on the device? Baptiste On 10-01-20, Baptiste Jonglez wrote: > Good point, the ar71xx - ath79 migration needs more documentation. > > I have just created > https://openwrt.org/docs/guide-user/installation/ar71xx.to.ath79 > but it needs some work: is sysupgrade supposed to work in

Re: OpenWrt 21.02-rc1

2021-04-27 Thread Baptiste Jonglez
On 21-04-21, Perry wrote: > Now that openwrt-21.02-rc1 is tagged, would it be possible to have an > "openwrt-21.02" section for the Reported Version on bugs.openwrt.org? > While at it, why is it still possible to file bug reports for lede-17.01? Good catch, thanks. I have just added openwrt-21.02

routerbootpart: hard_config partition can be larger than a single block on MikroTik devices

2021-04-30 Thread Baptiste Jonglez
Hi Thibault, I was debugging why OpenWrt could not find the radio calibration data on one of my hAP-ac2 devices: the /sys/firmware/mikrotik/hard_config/wlan_data/ directory is created but stays empty. It turns out that the compressed data does not fit in a single block (i.e. 4 KB), and the hard_c

Re: [PATCH] Fix URL validation for more than one URLs.

2021-05-03 Thread Baptiste Jonglez
Hi, On 02-05-21, fabian.bauma...@mailbox.org wrote: > That's my first contribution for OpenWRT, if something's not right, please > let me know. The patch is a good start (comments below), thanks a lot for your first contribution! There are a few formal issues with your patch. See https://openw

[PATCH] ipq40xx: fix hard_config partition size on MikroTik hAP-ac2

2021-05-03 Thread Baptiste Jonglez
From: Baptiste Jonglez The routerbootparts driver dynamically discovers the location of MikroTik partitions, but it cannot determine their size (except by extending them up to the start of the next discovered partition). The hard_config partition has a default size of 0x1000 in the driver

Re: [PATCH opkg] libopkg: pkg_hash: print unresolved dependencies

2021-05-03 Thread Baptiste Jonglez
Hi, On 02-05-21, Hauke Mehrtens wrote: > When a package is not installed because it has unresolved dependencies > normally we get only an error message like this: > * pkg_hash_fetch_best_installation_candidate: Packages for ltq-vdsl-app > found, but incompatible with the architectures configured

Re: [PATCH v3 2/2] sdk: unset BINARY_FOLDER and DOWNLOAD_FOLDER in final archives

2021-05-06 Thread Baptiste Jonglez
Hi, On 26-04-21, Sven Roederer wrote: > Using these config-options to customize the folders used at build-time makes > these > folder settings appear in generated archive. This causes the SDK to be not > portable, as it's going to use the build-time folders on the new systems. > The errors vary f

Re: [PATCH v3 1/2] imagebuilder: unset BINARY_FOLDER and DOWNLOAD_FOLDER in final archive

2021-05-06 Thread Baptiste Jonglez
Hi, On 26-04-21, Sven Roederer wrote: > Using these config-options to customize the folders used at build-time > makes these folder settings appear in generated archive. This causes the > imagebuilder to be not portable, as it's going to use the build-time folders > on the new systems. Errors look

Re: [PATCH v3 1/2] imagebuilder: unset BINARY_FOLDER and DOWNLOAD_FOLDER in final archive

2021-05-07 Thread Baptiste Jonglez
On 06-05-21, Sven Roederer wrote: > Baptiste, > > Am Donnerstag, 6. Mai 2021, 13:13:46 CEST schrieb Baptiste Jonglez: > > > > > > + $(SED) 's/^CONFIG_BINARY_FOLDER=.*/# CONFIG_BINARY_FOLDER was reset by > > > Imagebuilder/' $(PKG_BUILD_DIR)/.co

Re: [PATCH v3 1/2] imagebuilder: unset BINARY_FOLDER and DOWNLOAD_FOLDER in final archive

2021-05-08 Thread Baptiste Jonglez
On 07-05-21, Sven Roederer wrote: > Baptiste, > > Am Freitag, 7. Mai 2021, 14:12:21 CEST schrieb Baptiste Jonglez: > > > > Since these settings are hidden under "Advanced configuration options (for > > developers)", I don't think it's real

Re: [PATCH v2] uqmi: fix network registration loop

2021-05-08 Thread Baptiste Jonglez
Applied, thanks. Does this need to be backported to 21.02 or even 19.07? Baptiste On 20-04-21, thomas.rich...@kontron.com wrote: > From: Thomas Richard > > With some debug in qmi.sh using following patch, some errors are visible > in the registration step > @@ -29,6 +29,7 @@ proto_qmi_init_con

Re: [PATCH] Extend checks on build prerequisites for building OpenWRT core

2021-05-08 Thread Baptiste Jonglez
Hi, On 20-04-21, Bas Mevissen via openwrt-devel wrote: > Date: Tue, 20 Apr 2021 01:08:19 +0200 > From: Bas Mevissen > To: openwrt-devel@lists.openwrt.org > Cc: Bas Mevissen > Subject: [PATCH] Extend checks on build prerequisites for building OpenWRT > core Merged and backported to 21.02 and 19

Re: [PATCH v2] uqmi: fix network registration loop

2021-05-11 Thread Baptiste Jonglez
On 10-05-21, Florian Eckert wrote: > > > On 2021-05-08 12:33, Baptiste Jonglez wrote: > > Applied, thanks. > > > > Does this need to be backported to 21.02 or even 19.07? > > yes that would not be bad at least for openwrt-21.02 > On openwrt-19.07 there are

Re: [PATCH] uclient-http: set eof mark when content-length is 0

2021-05-14 Thread Baptiste Jonglez
Merged, thanks for the fix! On 11-03-21, Youfu Zhang wrote: > or uclient-fetch will stall until timeout for 2XX (except 204) response > with content-length of 0 > > Signed-off-by: Youfu Zhang > --- > uclient-http.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ucli

Backport ipq806x cpufreq change to OpenWrt 21.02?

2021-05-17 Thread Baptiste Jonglez
Hi, There have been reports of 5.4 kernel crash on ipq806x related to cpufreq: https://bugs.openwrt.org/index.php?do=details&task_id=3099 As far as I can tell, you changed the cpufreq driver recently (more recently than the bug reports): 6e411b8416388 ("ipq806x: backport cpufreq changes to

Re: [RFC] OpenWrt within a Docker container

2021-05-17 Thread Baptiste Jonglez
Hi, On 17-05-21, Paul Spooren wrote: > Hello, > > after some back and forth I'd like to request some more opinions on what > kind of Docker containers to offer containing the OpenWrt rootfs. This is > not about the SDK or ImageBuilder Docker containers. > > tl;dr: > > Should we ship `slim` cont

Re: [PATCH uclient] uclient-fetch: allow to overwrite Content-Type header for POST

2021-06-19 Thread Baptiste Jonglez
Hi, On 03-06-21, Andre Heider wrote: > This is required by some APIs, e.g. matrix's media upload [0]. > > [0] > https://matrix.org/docs/spec/client_server/latest#post-matrix-media-r0-upload > @@ -484,6 +485,7 @@ static int usage(const char *progname) > " --user-agent | -U

Re: [PATCH 21.02] ipq806x: backport cpufreq changes to 5.4

2021-06-27 Thread Baptiste Jonglez
Hi, On 20-06-21, Shane Synan wrote: > In the time since submitting this, I've continued testing this > change on my ZyXEL NBG6817. I'm reasonably confident this fixes my > issue (11/11 successes), and if there's any further testing that > would help, let me know! Thanks for the patch and testing

Re: [PATCH v3] busybox: sysntpd: add trigger to reload server

2021-06-27 Thread Baptiste Jonglez
On 06-06-21, Alexey Dobrovolsky wrote: > sysntpd server becomes unavailable if the index of the bound > interface changes. So let's add an interface trigger to reload sysntpd. > > This patch also adds the ability for the sysntpd script to handle > uci interface name from configuration. > > Fixes:

Re: [PATCH 19.07] busybox: sysntpd: option to bind server to iface

2021-06-27 Thread Baptiste Jonglez
On 08-03-21, Alexey Dobrovolsky wrote: > NTPD in busybox has option -I to bind server to IFACE. > However, capabilities of the busybox are limited, the -I option cannot be > repeated and only one interface can be effectively specified in it. > This option is currently not configurable via UCI. > Th

[PATCH] base-files: Don't enable ULA IPv6 addresses by default in new config

2022-09-08 Thread Baptiste Jonglez
From: Baptiste Jonglez ULA IPv6 prefixes (Unique Local Addresses, RFC 4193) are not routable on the Internet. As such, they have very limited use, and enabling them by default causes more problems than it solves: - if an OpenWrt device already has external IPv6 connectivity with globally

Re: [PATCH] base-files: Don't enable ULA IPv6 addresses by default in new config

2022-09-09 Thread Baptiste Jonglez
Hi, On 08-09-22, Michael Richardson wrote: > > >>>>> Baptiste Jonglez writes: > > ULA IPv6 prefixes (Unique Local Addresses, RFC 4193) are not routable > > on the Internet. As such, they have very limited use, and enabling > > them by defa

Re: [PATCH] base-files: Don't enable ULA IPv6 addresses by default in new config

2022-09-09 Thread Baptiste Jonglez
On 08-09-22, Michael Richardson wrote: > > >>>>> Baptiste Jonglez writes: > > - there have been various bug reports [1, 2, 3] in 19.07 and 21.02 > > where ULA addresses basically break global IPv6 connectivity. These > > bugs have not bee

Re: [RFC] Refactoring OpenWrt's build infra

2022-10-16 Thread Baptiste Jonglez
Hi, On 05-10-22, Thibaut wrote: > Hi, > > Following an earlier conversation on IRC with Petr, I’m willing to work on > refactoring our buildbot setup as follows: > > - single master for each stage (images and packages) > - latent workers attached to either master, thus able to build > opportun

Re: [RFC] Refactoring OpenWrt's build infra

2022-10-16 Thread Baptiste Jonglez
On 16-10-22, Christian Marangi wrote: > On Sun, Oct 16, 2022 at 02:07:05PM +0200, Baptiste Jonglez wrote: > > - either buildbot can run latent workers with a different Docker image > > depending on the build > > IMHO, this would be the safest and better solution to the prob

[PATCH] firewall: config: drop input traffic by default

2022-10-19 Thread Baptiste Jonglez
From: Baptiste Jonglez This is necessary with firewall4 to avoid a hard-to-diagnose race condition during boot, causing DNAT rules not to be taken into account correctly. The root cause is that, during boot, the ruleset is mostly empty, and interface-related rules (including DNAT rules) are

Re: [OpenWrt-Devel] 19.07.0 boot hang on Mikrotik device

2020-01-26 Thread Baptiste Jonglez
Hi, You should report this bug under "openwrt-19.07": https://bugs.openwrt.org/ You are apparently using ar71xx, did you try an ath79 19.07 image? Regards, Baptiste On 25-01-20, Joe Ayers wrote: > At http:\\arednmesh.org, we've had several mikrotik devices working, > all with "LHG" motherboards

Re: [OpenWrt-Devel] [PATCH 1/2] brcm47xx: rename target to bcm47xx

2020-02-10 Thread Baptiste Jonglez
On 08-02-20, Adrian Schmutzler wrote: > This change makes the names of Broadcom targets consistent by using > the common notation based on SoC/CPU ID (which is used internally > anyway), bcm instead of brcm. > This is even used for target TITLE in make menuconfig already, > only the short t

[OpenWrt-Devel] OpenWrt 19.07.2 service release

2020-03-06 Thread Baptiste Jonglez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, The OpenWrt community is proud to announce the second service release of OpenWrt 19.07. OpenWrt 19.07.2 focuses on security and device support. It notably fixes a security issue in ppp and improves support for migrating devices from ar71xx to at

[OpenWrt-Devel] OpenWrt 18.06.8 service release

2020-03-06 Thread Baptiste Jonglez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, The OpenWrt Community is proud to announce the eighth service release of the stable OpenWrt 18.06 series. OpenWrt 18.06.8 brings security fixes, as well as the usual device support fixes and core components update. - --- The main highlights of

[OpenWrt-Devel] [PATCH] ar71xx: Fix gigabit switch support for Mikrotik RB951G-2HnD

2020-03-26 Thread Baptiste Jonglez
From: Baptiste Jonglez Without this patch, when using rev 3 of the Atheros AR9344 SoC, the gigabit switch (AR8327) does not work or works very erratically. This is a re-spin of http://patchwork.ozlabs.org/patch/419857/ with a different PLL value, according to the feedback from several users

[OpenWrt-Devel] OpenWrt 19.07.3 service release

2020-05-20 Thread Baptiste Jonglez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, The OpenWrt community is proud to announce the third service release of OpenWrt 19.07. OpenWrt 19.07.3 focuses on security, stability and device support. Selected highlights of this service release are: * reduce opkg memory usage * allow to

[OpenWrt-Devel] Experimental "release goals" for 19.07.4

2020-05-23 Thread Baptiste Jonglez
Hi, It can be useful to have "release goals" to get a clearer idea of regression, release-blocking bugs, or wanted features for a release. I started an (experimental) list for 19.07.4 based on recent discussions on the mailing list, forum and IRC: https://openwrt.org/docs/guide-developer/relea

Re: [OpenWrt-Devel] Experimental "release goals" for 19.07.4

2020-05-24 Thread Baptiste Jonglez
On 23-05-20, Michael Jones wrote: > On Sat, May 23, 2020, 13:01 Baptiste Jonglez > wrote: > > > If the initial concept looks good, we can think about automating some of > > it: > > tag bug reports on Flyspray/Github/Gitlab as blocking for a specific > > release

[OpenWrt-Devel] Google Season of Docs projects for OpenWrt

2020-06-08 Thread Baptiste Jonglez
Hi, As discussed previously, OpenWrt has applied and been accepted for the Season of Docs. We have three mentors (me, Jow, Thomas Hühn), while Hauke and Paul are "project administrators". We started proposing projects here: https://openwrt.org/google-season-of-docs Feel free to discuss the prop

Re: [OpenWrt-Devel] Google Season of Docs projects for OpenWrt

2020-06-08 Thread Baptiste Jonglez
ific device. I'll let Paul answer, as I think he was the one proposing this. Thanks, Baptiste PS: please keep discussion in the same email thread. > On Mon, Jun 8, 2020 at 3:32 AM > wrote: > > > > -- Forwarded message -- > > From: Baptiste Jonglez

[OpenWrt-Devel] [PATCH 18.06] libubox: backport additional length-checking fixes

2020-06-13 Thread Baptiste Jonglez
From: Baptiste Jonglez Fixes: FS#3177 Cc: Felix Fietkau Cc: Rafał Miłecki Signed-off-by: Baptiste Jonglez --- package/libs/libubox/Makefile | 2 +- ...s-iteration-in-the-blobmsg_check_arr.patch | 75 ++ ...sg-fix-length-in-blobmsg_check_array.patch | 28

Re: [OpenWrt-Devel] [PATCH] ath79: archer-c7-v5: fix initramfs image

2020-06-19 Thread Baptiste Jonglez
Hi, On 17-06-20, Petr Štetiar wrote: > Currently it's not possible to tftpboot initramfs image as the image > contains tplink-v1-header which leads to: Out of curiosity, it looks like booting an initramfs image is only possible with serial access to the bootloader? > --- a/target/linux/ath79/ima

Re: [OpenWrt-Devel] [PATCH] ath79: archer-c7-v5: fix initramfs image

2020-06-19 Thread Baptiste Jonglez
On 19-06-20, Petr Štetiar wrote: > > On 17-06-20, Petr Štetiar wrote: > > > Currently it's not possible to tftpboot initramfs image as the image > > > contains tplink-v1-header which leads to: > > > > Out of curiosity, it looks like booting an initramfs image is only > > possible with serial acces

Re: [OpenWrt-Devel] [PATCH 18.06] libubox: backport additional length-checking fixes

2020-06-20 Thread Baptiste Jonglez
commits: I don't think I missed one, but I'm not 100% sure that the 4 commits I backported are all strictly necessary. In any case, they are all clean cherry-picks. Thanks, Baptiste On 13-06-20, Baptiste Jonglez wrote: > From: Baptiste Jonglez > > Fixes: FS#3177 > Cc: Feli

Simplified LuCI interface project: dashboard, quick setup, configuration

2020-06-26 Thread Baptiste Jonglez
Hi, The student project of Biyun and Zhao has just finished. The goal was to develop a simplified web interface for OpenWrt, integrated in LuCI and complementary to the current LuCI interface. Feedback on the results of the project is welcome, preferably in the pull requests (see below). Zhao a

Re: [OpenWrt-Devel] [PATCH 18.06] libubox: backport additional length-checking fixes

2020-07-03 Thread Baptiste Jonglez
Hi, On 20-06-20, Baptiste Jonglez wrote: > I should have added more details in the commit message: this fixes a > serious regression where procd fails to start some services, for instance > rpcd. See FS#3177. Any feedback on this regression fix? Thanks, Baptiste > This is the sam

Re: Simplified LuCI interface project: dashboard, quick setup, configuration

2020-07-18 Thread Baptiste Jonglez
Hi, On 26-06-20, Baptiste Jonglez wrote: > The student project of Biyun and Zhao has just finished. > > The goal was to develop a simplified web interface for OpenWrt, integrated > in LuCI and complementary to the current LuCI interface. > > Feedback on the results of the

Re: Simplified LuCI interface project: dashboard, quick setup, configuration

2020-07-18 Thread Baptiste Jonglez
Hi Michael, Thanks for your feedback. On 26-06-20, Michael Richardson wrote: > From watching the video the two tasks that you were attempting to improve > were (in laymens terms): > 1) changing the WIFI password > 2) creating a port-forward > > I think that this could be just a bit easier t

Re: [PATCH v2 firewall3] zones: apply tcp mss clamping also on ingress path

2020-07-24 Thread Baptiste Jonglez
Hi, On 24-07-20, Yousong Zhou wrote: > Fixes FS#3231 It looks like this bug also affects 18.06 and 19.07, so the fix should probably be backported. Baptiste > Signed-off-by: Yousong Zhou > --- > zones.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/zones.c b/zones.c > inde

Upcoming 19.07.4 and 18.07.9 stable releases

2020-07-30 Thread Baptiste Jonglez
Hi, New point releases for 19.07 and 18.06 are starting to be overdue, and I would like to help 19.07.4 and 18.06.9 get released somewhere around mid-August. The main motivation are fixes for a libubox regression and for the musl synchronisation bug, as well as a LuCI regression (see "release goa

Re: Simplified LuCI interface project: dashboard, quick setup, configuration

2020-07-31 Thread Baptiste Jonglez
On 18-07-20, Baptiste Jonglez wrote: > > - quick setup: https://github.com/openwrt/luci/pull/4141 > > - configuration: https://github.com/openwrt/luci/pull/4186 > > This needs more discussion and feedback. > > There is one interesting question (on the github pull requ

Re: Upcoming 19.07.4 and 18.07.9 stable releases

2020-08-14 Thread Baptiste Jonglez
Hi, On 07-08-20, Adrian Schmutzler wrote: > > Hi, > > There is also a new mbedtls version which fixes some security bugs, we > > should also update this: > > https://github.com/ARMmbed/mbedtls/releases/tag/mbedtls-2.16.7 I have added it to https://openwrt.org/docs/guide-developer/releases/go

[PATCH 19.07] tools/tplink-safeloader: use soft_ver 1.9.1 for archer c6 v2

2020-08-20 Thread Baptiste Jonglez
c6 v2 with firmware 1.3.1 Signed-off-by: Alexander Couzens (cherry picked from commit 6d5d815e3f6850a0dc754bf16053fa34490766f7) [remove changes to C6-V2-US because it's unsupported in 19.07] Signed-off-by: Baptiste Jonglez --- tools/firmware-utils/src/tplink-safeloader.c | 2 +- 1 file ch

[PATCH opkg] libopkg: move file size check after checksum verification

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez The file size check was added in cb6640381808dd ("libopkg: check for file size mismatches"). Its purpose is to provide an additional line of defense against hash collisions. It is more user-friendly to tell the user that the checksum is wrong, so move the file

[PATCH opkg] libopkg: harden checksum verification in error cases

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez This should make it harder to exploit bugs such as CVE-2020-7982. If we can't compute the checksum of a package, we should abort. Similarly, if we can't find any checksum in the package index, this should yield an error. As an exception, installing a packag

Re: [PATCH opkg] libopkg: move file size check after checksum verification

2020-08-24 Thread Baptiste Jonglez
On 24-08-20, Henrique de Moraes Holschuh wrote: > On 24/08/2020 07:53, Baptiste Jonglez wrote: > > The file size check was added in cb6640381808dd ("libopkg: check for file > > size mismatches"). Its purpose is to provide an additional line of > > defense against

Re: [PATCH opkg] libopkg: move file size check after checksum verification

2020-08-24 Thread Baptiste Jonglez
On 24-08-20, Henrique de Moraes Holschuh wrote: > On 24/08/2020 09:01, Baptiste Jonglez wrote: > > On 24-08-20, Henrique de Moraes Holschuh wrote: > > > On 24/08/2020 07:53, Baptiste Jonglez wrote: > > > > It is more user-friendly to tell the user that the checksum

[PATCH opkg v2] libopkg: harden checksum verification in error cases

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez This should make it harder to exploit bugs such as CVE-2020-7982. If we can't compute the checksum of a package, we should abort. Similarly, if we can't find any checksum in the package index, this should yield an error. As an exception, installing a packag

[PATCH opkg] man: remove obsolete manual pages

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez The man pages have not been updated since 2010. Options are documented in the usage message obtained when running "opkg" without arguments. In addition, the man page are no longer used anywhere in the build system since 2017: the autoconf-based build system w

[PATCH opkg] opkg: allow to configure the path to the signature verification script

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez Currently, package index signatures are only checked when opkg runs on the OpenWrt device. The verification script is hard-coded to a path in /usr/sbin/. Making this path configurable is a first step to implement signature verification in host builds of opkg (e.g. in the

Re: [PATCH opkg v2] libopkg: harden checksum verification in error cases

2020-08-24 Thread Baptiste Jonglez
On 24-08-20, Baptiste Jonglez wrote: > From: Baptiste Jonglez > > This should make it harder to exploit bugs such as CVE-2020-7982. > > If we can't compute the checksum of a package, we should abort. > > Similarly, if we can't find any checksum in the packag

[PATCH opkg 3/5] download: factor out the logic for building cache filenames

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez If we want to access files in the cache from multiple functions, it is necessary to have a single source of truth regarding the naming of files in the cache. Signed-off-by: Baptiste Jonglez --- libopkg/opkg_download.c | 17 - 1 file changed, 12

[PATCH opkg 2/5] libopkg: factor out checksum and size verification

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez This is a sizeable chunk of code that be can pretty well isolated in its own function. This refactoring will be necessary for an upcoming feature in which opkg_download_pkg() will need to verify the checksum of packages in the cache. This is the reason why the new

[PATCH opkg 5/5] opkg_verify_integrity: better logging and error conditions

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez The function now always returns an error if size/checksum don't match: we let the caller decide what to do with the result. In addition, most of the logging is also moved to the caller. We just keep logging for unexpected errors and a bit of debug at loglevel

[PATCH opkg 4/5] download: purge cached packages that have incorrect checksum

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez Before using a package from the cache, verify its size and checksum against a package index, and delete the package from the cache if they don't match. The install process will then proceed to download the "fixed" package as usual. This allows to c

[PATCH opkg 0/5] Purge packages from cache when they have incorrect checksum

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez The motivation of this patch series is to fix FS#2690. Because packages are continuously rebuilt, the ImageBuilder ends up with old packages in its cache, and fails because checksums don't match with the new package index from the download server. The approach to

[PATCH opkg 1/5] download: remove compatibility with old cache naming scheme

2020-08-24 Thread Baptiste Jonglez
From: Baptiste Jonglez A long time ago, the name of cached files was derived from the source URL. This was changed in 2011 with d46db43e21 ("Don't include the source URI in the cached filename.") Some compatibility code was left behind: even today, we are still trying to re

Kr00k vulnerabilities / CVE-2019-15126 / CVE-2020-3702

2020-08-25 Thread Baptiste Jonglez
Hi, Detailed information about the kr00k vulnerabilities is hard to find. Here is a WIP recap about it and whether/how OpenWrt is vulnerable. It's missing lots of information, please contribute if you have any. I will summarize the results in a wiki page afterwards. Kr00k v1 (CVE-2019-15126) =

[PATCH 19.07 2/8] ath10k-firmware: update ath10k-ct firmware

2020-08-25 Thread Baptiste Jonglez
From: Michael Yartys This supports better per-chain noise floor reporting, which in turn allows for better RSSI reporting in the driver. Wave-2 fixes a long-standing rate-ctrl problem when connected to xbox (and probably other devices). Wave-2 has fix for crash likely related to rekeying. Wav

[PATCH 19.07 1/8] ath10k-firmware: update Candela Tech firmware images

2020-08-25 Thread Baptiste Jonglez
From: Stefan Lippers-Hollmann The release notes since last time for wave-1: * No changes to wave-1, but I make a version .014 copy anyway to keep the makefile in sync. The release notes since last time for wave-2: * December 16, 2019: Wave-2 has a fix to make setting txpower work

[PATCH 19.07 6/8] ath10k-ct-firmware: update firmware images

2020-08-25 Thread Baptiste Jonglez
From: Álvaro Fernández Rojas No release notes this time. Signed-off-by: Álvaro Fernández Rojas (cherry picked from commit 06f510df6e2aa0b1e40124bbd758672458d01482) --- package/firmware/ath10k-ct-firmware/Makefile | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) dif

[PATCH 19.07 8/8] ath10k-ct-firmware: update firmware images

2020-08-25 Thread Baptiste Jonglez
Fernández Rojas (cherry picked from commit 91aab77bf1ce91b0e60e720eb147c94a02c1f2fd) Tested-by: Baptiste Jonglez [Archer C6 v2: qca9888-ct] --- package/firmware/ath10k-ct-firmware/Makefile | 60 ++-- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/package/firmware

[PATCH 19.07 7/8] ath10k-ct-firmware: add htt-mgt variants

2020-08-25 Thread Baptiste Jonglez
From: Álvaro Fernández Rojas For wave-2, there is now a new variant: htt-mgt-community (vs the old full-htt-mgt-community). The non-full one (hence forth 'diet') compiles out a lot of firmware features that ath10k does not use. This saves a lot of resources and lets one configure more stations/v

[PATCH 19.07 3/8] ath10k-firmware: update ath10k-ct firmware images

2020-08-25 Thread Baptiste Jonglez
From: Álvaro Fernández Rojas Release notes for 017: Wave-1: * March 19, 2020: Fix problem where power-save was not enabled when going off-channel to scan. The problem was a boolean logic inversion in the chmgr code, a regression I introduced a long

[PATCH 19.07 5/8] ath10k-ct-firmware: rename ct-htt packages

2020-08-25 Thread Baptiste Jonglez
From: Álvaro Fernández Rojas Signed-off-by: Álvaro Fernández Rojas (cherry picked from commit 2e5e9b459ed53b42f8938294a98e2546be976c85) --- package/firmware/ath10k-ct-firmware/Makefile | 130 +-- target/linux/ath79/image/generic.mk | 2 +- 2 files changed, 66 insertio

[PATCH 19.07 4/8] ath10k-firmware: move CT firmwares to new package

2020-08-25 Thread Baptiste Jonglez
From: Álvaro Fernández Rojas Signed-off-by: Álvaro Fernández Rojas (cherry picked from commit 658e68f85c2645e0132edc6b30a9c76cc17292de) --- package/firmware/ath10k-ct-firmware/Makefile | 524 +++ package/firmware/ath10k-firmware/Makefile| 446 2 files change

Re: [PATCH opkg] opkg: allow to configure the path to the signature verification script

2020-08-26 Thread Baptiste Jonglez
On 25-08-20, Paul Spooren wrote: > On 24.08.20 05:07, Baptiste Jonglez wrote: > > From: Baptiste Jonglez > > > > Currently, package index signatures are only checked when opkg runs on the > > OpenWrt device. The verification script is hard-coded to a path in > >

Re: [PATCH] build: opkg-key variable key folder

2020-08-26 Thread Baptiste Jonglez
On 25-08-20, Paul Spooren wrote: > The key folder is used by `opkg` and `usign` to store and retrieve > trusted public keys. Using `opkg-key` outside a running device is > unfeasible as the key folder is hard coded to `/etc/opkg/keys`. > > This commit adds a variable OPKG_KEYS which defaults to `/

Re: [PATCH v3] treewide: switch to HTTPS by default

2020-08-27 Thread Baptiste Jonglez
On 25-08-20, Paul Spooren wrote: > From: Petr Štetiar > > As there is now wolfSSL included by default due to SAE/WPA3 we can > finally switch to TLS/SSL in other parts as well. The commit message needs improvement, especially "treewide: switch to HTTPS by default". What is switched to HTTPS exa

Re: [PATCH 3/3] build: switch VERSION_REPO to HTTPS

2020-08-28 Thread Baptiste Jonglez
Thanks :) Acked-by: Baptiste Jonglez On 27-08-20, Paul Spooren wrote: > The variable VERSION_REPO is used by opkg to download package(list)s. > Now that the default installation support encrypted HTTP opkg should > make use of it. > > Suggested-by: Petr Štetiar > Sugg

Re: CVE-2020-3702: Firmware updates for ath9k and ath10k chips

2020-08-29 Thread Baptiste Jonglez
Hi, Cross-posting to openwrt-devel because we are backporting the necessary fixes. On 12-08-20, Jouni Malinen wrote: > On Wed, Aug 12, 2020 at 11:17:47AM +0200, Toke H?iland-J?rgensen wrote: > > Pali Roh?r writes: > > > Could somebody react and provide some details when fixes would be > > > avai

Re: Upcoming 19.07.4 and 18.07.9 stable releases

2020-08-29 Thread Baptiste Jonglez
On 28-08-20, Hauke Mehrtens wrote: > Hi, > > I would like to do a 19.07.4 and a 18.06.9 release on Sunday or > beginning of next week. Cool, looks good to me. > Is there something missing in the current branches which should get into > this release? There's the ath10k-ct-firmware bump for 19.07

Re: [PATCH 18.06] mac80211: Backport fixes for Kr00k vulnerabilities

2020-08-29 Thread Baptiste Jonglez
On 28-08-20, Hauke Mehrtens wrote: > This backports some fixes from kernel 5.6 and 4.14.175. Thanks, I will give this a try. It's missing two fixes though: 5981fe5b0529 ("mac80211: fix misplaced while instead of if") a0761a301746 ("mac80211: drop data frames without key on encrypted links") The

Re: [PATCH 18.06] mac80211: Backport fixes for Kr00k vulnerabilities

2020-08-29 Thread Baptiste Jonglez
On 29-08-20, Hauke Mehrtens wrote: > On 8/29/20 2:02 PM, Baptiste Jonglez wrote: > > On 28-08-20, Hauke Mehrtens wrote: > >> This backports some fixes from kernel 5.6 and 4.14.175. > > > > Thanks, I will give this a try. > > > > It's missing two

Re: Upcoming 19.07.4 and 18.07.9 stable releases

2020-08-30 Thread Baptiste Jonglez
On 29-08-20, Baptiste Jonglez wrote: > On 28-08-20, Hauke Mehrtens wrote: > > Hi, > > > > I would like to do a 19.07.4 and a 18.06.9 release on Sunday or > > beginning of next week. > > Cool, looks good to me. > > > Is there something missing in

Re: [PATCH] build: opkg-key variable key folder

2020-08-31 Thread Baptiste Jonglez
Sorry, forgot to reply: On 31-08-20, Daniel Golle wrote: > On Wed, Aug 26, 2020 at 11:57:55AM -1000, Paul Spooren wrote: > > > > On 26.08.20 09:17, Baptiste Jonglez wrote: > > > On 25-08-20, Paul Spooren wrote: > > > > The key folder is used by `opk

Re: [PATCH 19.07 7/8] ath10k-ct-firmware: add htt-mgt variants

2020-09-03 Thread Baptiste Jonglez
a different firmware variant under the same package name. I will send a v2 fixing this. On 25-08-20, Baptiste Jonglez wrote: > From: Álvaro Fernández Rojas > > For wave-2, there is now a new variant: htt-mgt-community (vs the old > full-htt-mgt-community). > > The non-full one (

[PATCH 19.07 v2 1/6] ath10k-firmware: update Candela Tech firmware images

2020-09-03 Thread Baptiste Jonglez
From: Stefan Lippers-Hollmann The release notes since last time for wave-1: * No changes to wave-1, but I make a version .014 copy anyway to keep the makefile in sync. The release notes since last time for wave-2: * December 16, 2019: Wave-2 has a fix to make setting txpower work

[PATCH 19.07 v2 0/6] Update ath10k-ct firmware

2020-09-03 Thread Baptiste Jonglez
From: Baptiste Jonglez This backports all recent ath10k-ct firmware bumps from master, and also backports moving these firmwares to a new package. Opkg package names remain unchanged. v2: don't backport the following changes: 2e5e9b459ed5 ("ath10k-ct-firmware: rename ct-ht

[PATCH 19.07 v2 2/6] ath10k-firmware: update ath10k-ct firmware

2020-09-03 Thread Baptiste Jonglez
From: Michael Yartys This supports better per-chain noise floor reporting, which in turn allows for better RSSI reporting in the driver. Wave-2 fixes a long-standing rate-ctrl problem when connected to xbox (and probably other devices). Wave-2 has fix for crash likely related to rekeying. Wav

[PATCH 19.07 v2 3/6] ath10k-firmware: update ath10k-ct firmware images

2020-09-03 Thread Baptiste Jonglez
From: Álvaro Fernández Rojas Release notes for 017: Wave-1: * March 19, 2020: Fix problem where power-save was not enabled when going off-channel to scan. The problem was a boolean logic inversion in the chmgr code, a regression I introduced a long

[PATCH 19.07 v2 6/6] ath10k-ct-firmware: update firmware images

2020-09-03 Thread Baptiste Jonglez
package names] [remove changes to non-full htt-mgt variants because we did not backport a882bfce052e ("ath10k-ct-firmware: add htt-mgt variants")] Signed-off-by: Baptiste Jonglez --- package/firmware/ath10k-ct-firmware/Makefile | 42 ++-- 1 file changed, 21 insertions(+), 21

[PATCH 19.07 v2 5/6] ath10k-ct-firmware: update firmware images

2020-09-03 Thread Baptiste Jonglez
kages")] Signed-off-by: Baptiste Jonglez --- package/firmware/ath10k-ct-firmware/Makefile | 50 ++-- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/package/firmware/ath10k-ct-firmware/Makefile b/package/firmware/ath10k-ct-firmware/Makefile index 79bdeeec4f..6fe8ea6

[PATCH 19.07] scripts: getver.sh: Fix version when running on local 19.07 branch

2020-09-03 Thread Baptiste Jonglez
From: Baptiste Jonglez When building from a local branch based off the "openwrt-19.07" branch, version computation is wrong, for instance: r10194+1004-c53f62b111 The number of local commits (1004 in this case) is wrong because it is computed against master. As a result, it wron

[PATCH 18.06] scripts: getver.sh: Fix version when running on local 18.06 branch

2020-09-03 Thread Baptiste Jonglez
From: Baptiste Jonglez When building from a local branch based off the "openwrt-18.06" branch, version computation is wrong, for instance: r6907+1154-7e15e21766 The number of local commits (1154 in this case) is wrong because it is computed against master. As a result, it wron

[PATCH 19.07 v2 4/6] ath10k-firmware: move CT firmwares to new package

2020-09-03 Thread Baptiste Jonglez
From: Álvaro Fernández Rojas Signed-off-by: Álvaro Fernández Rojas (cherry picked from commit 658e68f85c2645e0132edc6b30a9c76cc17292de) --- package/firmware/ath10k-ct-firmware/Makefile | 524 +++ package/firmware/ath10k-firmware/Makefile| 446 2 files change

Re: [PATCH 19.07 7/8] ath10k-ct-firmware: add htt-mgt variants

2020-09-04 Thread Baptiste Jonglez
Hi, On 03-09-20, Adrian Schmutzler wrote: > > > These HTT firmwares are not used in default openwrt images, but they > > > could be used downstream: it does not seem wise to distribute a > > > different firmware variant under the same package name. > > > > Those compiled out features are not used

Re: Upcoming 19.07.4 and 18.07.9 stable releases

2020-09-04 Thread Baptiste Jonglez
the DMA burst size has a > different meaning and instruction depending on the generation. Do you have more details, references? A commit? > Cheers, > > Nick > > On Sun, Aug 30, 2020 at 1:45 PM Baptiste Jonglez > wrote: > > > > On 29-08-20, Baptiste Jonglez w

Re: [PATCH 19.07 v2 6/6] ath10k-ct-firmware: update firmware images

2020-09-06 Thread Baptiste Jonglez
Tested-by: Baptiste Jonglez [QCA9886, QCA9887] On 03-09-20, Baptiste Jonglez wrote: > From: Michael Yartys > > Not a large change from last time, but should fix at least one rare wave-2 > crash. > > Tested on Netgear R7800. > > Signed-off-by: Michael Yartys > Sign

Re: Upcoming 19.07.4 and 18.07.9 stable releases

2020-09-08 Thread Baptiste Jonglez
Hi, Images for 19.07.4 have been built. Thomas, could you update the ToH accordingly? When the download page is also updated, I will announce it, probably tomorrow. 18.06.9 will follow soon. Thanks, Baptiste On 30-07-20, Baptiste Jonglez wrote: > Hi, > > New point releases for

OpenWrt 19.07.4 service release

2020-09-09 Thread Baptiste Jonglez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, The OpenWrt community is proud to announce the newest service release in the 19.07 stable series: OpenWrt 19.07.4. It focuses on stability and device support. Selected highlights of this service release are: * fix regression in libubox causin

[PATCH opkg] libopkg: fix md5sum calculation

2020-09-13 Thread Baptiste Jonglez
ation, unconditionally enable sha256 support") Signed-off-by: Alexander Ryzhov [Add commit description] Signed-off-by: Baptiste Jonglez --- libopkg/file_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libopkg/file_util.c b/libopkg/file_util.c index 3a1761e..8e698cc 10

Re: [PATCH opkg 0/5] Purge packages from cache when they have incorrect checksum

2020-09-13 Thread Baptiste Jonglez
and 19.07. Thanks, Baptiste On 25-08-20, Baptiste Jonglez wrote: > From: Baptiste Jonglez > > The motivation of this patch series is to fix FS#2690. Because packages > are continuously rebuilt, the ImageBuilder ends up with old packages in > its cache, and fails because checksums d

<    1   2   3   >