Hi, On 03-09-20, Adrian Schmutzler wrote: > > > These HTT firmwares are not used in default openwrt images, but they > > > could be used downstream: it does not seem wise to distribute a > > > different firmware variant under the same package name. > > > > Those compiled out features are not used by any ath10k driver as far as I > > know. > > If the driver doesn't use it, I don't see how anything else could... > > > > Its still worth testing, but I think that diet variant is probably the best > > choice.
Yes, introducing that diet variant in master seems like a good idea. It will be part of the next 20.XX stable release. As Adrian also pointed out, the problem is backporting it to the 19.07 branch: it might break user expectations. > My point mainly was that it's against the idea of a stable branch to suddenly > rename firmware variants in a .4 revision. > > So, it would be better to use patches 1-4, drop the htt renames (5,7) and > then just rebase patches 6 and 8 for the 19.07 branch. I've sent a v2 with this approach, everything works fine on a QCA9886. I will try to test it a bit more on different hardware this week-end. More testing is welcome. Thanks, Baptiste
signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
