Re: [OpenWrt-Devel] [PATCH uhttpd] client: allow keep-alive for POST requests

Hi Wes, > Are there *new* security implications of allowing keep-alive? I don't see any immediate concerns. You can trigger resource intensive calls via GET, HEAD, PATCH, PUT or DELETE as well, all of them were allowed for keep-alive previously, only POST was filtered for unknown reasons. > Slow

Re: [OpenWrt-Devel] [PATCH uhttpd] client: allow keep-alive for POST requests

Hi Wes, > That sounds ideal. Is this with or without the "[OpenWrt-Devel] [PATCH > ustream-ssl] ustream-openssl: clear error stack before SSL_read/SSL_write" > patch? it is including the error stack patch. Without it, I wasn't even able to fully load the page most of the time. Regards, Jo si

Re: [OpenWrt-Devel] [PATCH] ubus: lua binding does not allow a reply with 64 bit numbers

Hi, applied with slight changes in https://git.openwrt.org/?p=project/ubus.git;a=commitdiff;h=171469e3138cce191892e20b6fd35b52c9368064 - thanks! ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@li

[OpenWrt-Devel] Merged: session: deny access if password loginis disabled

Merged into project/rpcd.git, branch master at http://git.lede-project.org/?p=project/rpcd.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Repository for release or snapshot build configuration?

Hi Lars, see https://git.openwrt.org/?p=buildbot.git;a=blob;f=docker/docker-compose.yml for an example configuration of the build infrastructure. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@l

Re: [OpenWrt-Devel] [PATCH] busybox: remove date -k patch

Hi, > The kernel generally only cares about the timezone in a few places: last time I checked, iptables xt_time was affected. Without a properly set timezone, rules will kick in at unexpected times and --utc / --localtz / --kerneltz will not work as expected. Did you runtime test this? ~ Jo s

Re: [OpenWrt-Devel] [RFC PATCH] ath79: clarify purpose of factory image

Hi, +1 from me. I think the approach makes sense. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] libuci help

Hi, first of all, dashes are not allowed in section names. Unfortunately, libuci does not really perform any argument validation so it'll happily allow invalid names in various places but fail later on, as you've observed. Furthermore, I suggest to create a named section directly instead of doing

[OpenWrt-Devel] [PATCH] target: drop 616-net_optimize_xfrm_calls.patch

: Jo-Philipp Wich --- .../616-net_optimize_xfrm_calls.patch | 20 --- .../616-net_optimize_xfrm_calls.patch | 20 --- .../616-net_optimize_xfrm_calls.patch | 20 --- 3 files changed, 60 deletions(-) delete mode 100644 target/l

[OpenWrt-Devel] [PATCH v2] generic: drop 616-net_optimize_xfrm_calls.patch

: Jo-Philipp Wich --- .../616-net_optimize_xfrm_calls.patch | 20 --- .../616-net_optimize_xfrm_calls.patch | 20 --- .../616-net_optimize_xfrm_calls.patch | 20 --- 3 files changed, 60 deletions(-) delete mode 100644 target/l

Re: [OpenWrt-Devel] [PATCH fstools V3 1/2] Revert "block: mount_action: handle mount/umount deps"

Hi Rafał, instead of reverting the hierarchical mount handling, isn't fixing the unintended mounts just a matter of doing a prefix compare during vlist_for_first_to_element() traversal? Assuming that `the_dev` refers to the block we do want to mount and `dev` is the iterator pointing to each `dev

Re: [OpenWrt-Devel] [PATCH v2 0/6] build: update scritps/config to kconfig-v5.6

Hi Eneas, I am sorry but I had to completely revert the kconfig bump. It thoroughly broke the package repository builds since multiple days and the fatal recursive dependencies make it a no-go for master, at least as far as our build infrastructure is concerned. Right now, a single malformed feed

Re: [OpenWrt-Devel] [PATCH v2 0/6] build: update scritps/config to kconfig-v5.6

Hi Eneas, > I'm really sorry--and embarrassed, really--to have caused all this > trouble. I'll see what I can do from here, but I'm not familiar > enough with the build bot system to do much on my own--and that was > the origin of all problems. no need to be embarrassed, I just figured that reve

Re: [OpenWrt-Devel] Port labels for DSA targets/devices

Hi, I'd also prefer approach #2 to eventually allow for some generic configuration and port layout discovery mechanism without the need for shipping mappings for each device. In case we cannot go this route and need to stick to whatever mixture upstream or the vendors are using, I propose to ret

Re: [OpenWrt-Devel] Port labels for DSA targets/devices

Hi, > Note that DSA devices might have additional separate devices labelled ethX > as well, additional to the switch ports. do these fullfill a similar role to swconfig's "CPU ports" ? > E.g. ucidef_set_interfaces_lan_wan > "lan1 lan2 lan3 lan4 lan5 lan6" "eth0 eth2" > > So, this might become c

Re: [OpenWrt-Devel] Jsonfilter, return partial subobject?

Hi, > [...] > What I want to do is return a JSON string with this representation: > [ >     { "interface" : "lan", "uptime" : 1 }, >     ... > ] > > E.g., I want to filter the json not down to a single value, but to a > collection of key-value pairs by excluding items that don't match. that

Re: [OpenWrt-Devel] Sysupgrade and Failed to kill all processes

Hi Michael, > [...] > > Now that the very rough summary is out of the way, I have 4 questions. > > 1) I notice that the shell script /lib/upgrade/stage2 is doing a tight loop > with kill -9 to terminate processes. However, it's only looping a maximum of > 10 times, and its going as fast as the s

Re: [OpenWrt-Devel] Sysupgrade and Failed to kill all processes

Hi, > > That loop-kill-all thing should be a kind of last resort really, what's > actually needed is some kind of "init 1" procd equivalent which shuts > down all > services in a more or less clean manner. > > > Oddly enough, the /lib/upgrade/stage2 script has some aspect of this.

Re: [OpenWrt-Devel] Ubus based service watchdog?

Hi, I like the ubus watchdog ping/pong idea. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 1/1] firewall3: harden string functions that might overflow

Hi, the sprintf() to snprintf() changes are fine to me. Please omit the conversions to strlcpy() and please don't use fmemopen(). ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH usign] Always pad fingerprints to 16 characters

Hi, > Fingerprints were not padded with zeros. [...] > > Signed-off-by: Matthias Schiffer Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.

Re: [OpenWrt-Devel] [PATCH v2 4/4] build: use zstd for SDK and ImageBuilder tarballs

Hi, I tend to NAK this as it has the potential to interrupt a lot of downstream tooling. Up until now I also never heard about about Zstd - while this doesn't mean anything in the grand scheme of things I think it is a bit too "new" to be used widely yet. Seems tar only supports it since beginning

Re: [OpenWrt-Devel] Problems with e-mail DMARC policy, and other usability issues

Hi, > ... does it though? I know it does traditionally, but... is that really > the only way? IFF you keep this, then yeah, sure, all the other > justifications are fine, but it's clearly not working well. in the past we did rewrite the sender to the list mail address and (iirc) added the origi

Re: [OpenWrt-Devel] iwinfo: DFS channels are not listed

Hi, since nobody really uses the `restricted` field (apart from LuCI itself I believe) and since I'd like to avoid changing the ABI, I would be fine with changing the condition to NO_IR || DFS or even just DFS. Initially the restricted flag was supposed to give a hint to the ui which channels are

Re: [OpenWrt-Devel] [PATCH uclient v2] uclient-fetch: add option to read POST data from file

Hi Gio, Daniel, > [...] > --- > v2: make it compile, handle errors, add usage info, fix typos > > uclient-fetch.c | 31 +-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/uclient-fetch.c b/uclient-fetch.c > index a06be5d..6119328 100644 > --- a/u

Re: [OpenWrt-Devel] [PATCH v3] uclient-fetch: add option to read POST data from file

86/64. > > Signed-off-by: Gioacchino Mazzurco > Signed-off-by: Daniel Golle Acked-by: Jo-Philipp Wich > --- > v3: use 1024 bytes buffer instead of 1000, use sizeof() > As original wget also only supports "application/x-www-form-urlencoded" > as Content-Type for the

[OpenWrt-Devel] Merged: Use autoclear for overlay loopbackdevice

Merged into project/fstools.git, branch master at http://git.openwrt.org/?p=project/fstools.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: hostapd: fix compilation of wpa_supplicant

Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH RFC procd] service: add "init_action" ubus method for /etc/init.d/ scripts

Hi, in addition to the inline comments, I'd personally prefer to see such functionality as rpcd plugin, not in procd itself. Not all init scripts are procd enabled and not all procd processes have init scripts, due to that I think that init script enumeration methods should reside elsewhere since

Re: [missing subjects]

Hi, I think this was a misconfiguration in mailman (global "from_is_list" was set to "Wrap message"). Let's see if this reply mail looks better. Regards, Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-d

[RFC PATCH] Introduce UCI support for configuring DSA VLAN filter rules

de to reduce the amount of required external dependencies and to allow for improved performance when processing large configurations. Open questions/topics: - Ensure that the chosen configuration approach actually works with DSA_TAG_PROTO_NONE switches - Consider changing the types of the UCI

[PATCH 1/1] dsaconfig: introduce package for UCI configuration of VLAN filter rules

by default, and to set VLAN port membership, tagging state and PVID as specified by UCI on each port and on the switch bridge device itself, allowing logical interfaces to reference port VLAN groups by using "switch0.N" as ifname, where N denotes the VLAN ID. Signed-off-by: Jo-Philip

[RFC PATCH v2 1/1] dsaconfig: introduce package for UCI configuration of VLAN filter rules

fault, and to set VLAN port membership, tagging state and PVID as specified by UCI on each port and on the switch bridge device itself, allowing logical interfaces to reference port VLAN groups by using "switch0.N" as ifname, where N denotes the VLAN ID. Signed-off-by: Jo-Philipp Wich

[RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

s since v1: - Rename switch, switch_vlan and switch_port sections to dsa, dsa_vlan and dsa_port respectively - Forcibly move DSA ports to the switch bridge if they're part of another bridge yet - Disallow VLAN ID 0 - Properly display unassigned ports as empty in "dsacon

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi, > [...] > Isn't it conceptually more correct in this case for the vlan filtering > to be configured as part of the "interface" in uci? > Ie I configure an interface of type "bridge" which bridges the switch > ports, then the vlan filtering is a configuration property of this > interface (just

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi, > [...] > The same feeling is still with this DSA proposal. The syntax "lan2.t > lan2 lan3 lan5" is unstructured and it does not help too. What is unstructured about it? The fact that it is not a uci list? That can be easily changed. > The use of "switch0" for cpu interface is good and I thi

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi, > Changes: > - The device is created as a netifd bridge > - Bridge vlan sections should always refer to the bridge instead of > automatically be applied to the first one > - Use = instead of . to mark tagging modifiers. "." is already used > for vlan interface names and reusing it here c

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi, > If we can't come up with a working automatic scheme, maybe we could have > an option to disable the cpu port per vlan? Having a default-enabled "option self" or "option local" was my idea as well. Any idea which name fits better? ~ Jo ___ openwr

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi, > I'm not sure whether using an asterisk is wise here, as it might pose > interesting problems when people use scripts to set/evaluate uci > config (as you have to be extra careful to not have it treated as a > wildcard.) I'd be happy if we could find another symbol here. hm, can you elaborat

Re: [PATCH] iftop: fix compilation with GCC 10

Hi, I've sent a fix using extern declarations upstream, lets see what happens. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt

Re: [PATCH] iftop: fix compilation with GCC 10

Hi, > Where? I don't see a merge request on the git link referenced in the Makefile. sent a patch to the author using git send-email. Couldn't figure out how to open a MR on that Gitlab thing after looking for 30 seconds. ~ Jo ___ openwrt-devel mailin

Re: [PATCH umdns] service.c: fix build on gcc 10

Hi, > Signed-off-by: Kevin Darbyshire-Bryant Acked-by: Jo-Philipp Wich ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH uhttpd] ubus: parse "call" method params only for relevant call

Hi, > There is no point in parsing "call" specific params for other ("list") > method calls. This is a minor cleanup that doesn't change uhttpd ubus > behaviour. > > Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich signature.as

Re: [PATCH firewall3] zones: apply tcp mss clamping also on ingress path

Hi Yousong, On 7/23/20 6:05 AM, Yousong Zhou wrote: > Fixes FS#3231 > > Signed-off-by: Yousong Zhou > --- > zones.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/zones.c b/zones.c > index 68b02ab..d5e756c 100644 > --- a/zones.c > +++ b/zones.c > @@ -580,6 +580,14 @@ print_i

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi, > One thing which is a bit awkward as long as the bridge itself is > configured as an interface, is that as far as I have understood, > creating a tagged interface to the bridge requires first setting up an > interface for the bridge, e.g. with protocol Unmanaged, and then > setting up one or

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi, > Related to this, is it possible to add a wireless interface to a > bridge specifying a non-default PVID? I would have expected that something like config bridge-vlan option device mybridge0 option vlan 100 option ports 'wlan0:u*' achieves that effect. The wlan0 interface would be a

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi, yeah I forgot to elaborate that in my last mail. The problem of dynamic / not explicitly addressable wifi interface names in the network config remains. The best solution I can think of is fixing the wifi ifnames using "option ifname" in the wifi-iface sections (which causes some very interes

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi, > 1. Have VLAN devices on top of vlan-enabled bridges to define hotplug > ops where applicable, so LAN could be a plain VLAN interface switch0.1 > instead of its own bridge. > 2. With these wrapper hotplug ops, a default VLAN would be passed as > well, unless overwritten by other VLAN settings

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi again, > What about spelling out the dependency explicitly? Instead of overloading the > meaning of "option network", add an "option bridge" instead which reuses the > existing vlan notation followed by a vlan id spec as defined by the "option > ports" notation for bridge devices, e.g. That sh

Re: [PATCH v2 firewall3] zones: apply tcp mss clamping also on ingress path

Hi, > Fixes FS#3231 > > Signed-off-by: Yousong Zhou Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinf

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi Luiz, I mostly agree with your proposal (though I'd call "device_for" simply "bridge" instead but that's details). I don't think everything can be simply switched in one go but I do think your proposal could be broken down into the following measures. The simple things: - Rename "config wif

Re: [RFC] Writing sysupgrade.tgz directly to overlay for block-device sysupgrade

Hi David, > Instead of using the overlay filesystem du jour, perhaps it makes more > sense to simply put the tarball itself, raw, on the loop device > immediately after the end of the squashfs? I suppose the limiting factor for the maximum backup size would be the amount of available RAM then? Be

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Hi Felix, > [...] > > For a simple default config, you could have this: > > # network > config device option type bridge # I assume this is needed as well > option name switch0 > > config bridge-vlan > option vlan 1 > option ports "lan1 lan2 lan3 lan4" > > conf

Re: [PATCH 0/3] Support TLS/SSL and WPA3-Personal/SAE by default

Hi, >> How stable is the ABI of wolfssl? > > I assume, that we're going to find the answer in the upcoming years :-) see https://abi-laboratory.pro/index.php?view=timeline&l=wolfssl for the historic track record. Compared to OpenSSL here: https://abi-laboratory.pro/index.php?view=timeline&l=open

Re: [PATCH] kernel: add missing config symbol

Hi, > Signed-off-by: Stijn Tintel Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: github private respositories

Hi, > Is there a way to compile github private repositories as package in openwrt? PKG_SOURCE_URL:=https://githubuser:githubp...@github.com/project/repo.git or PKG_SOURCE_URL:=g...@github.com:project/repo.git or PKG_SOURCE_URL:=ssh://g...@github.com/project/repo.git The first one only works

Re: [PATCH V2 uhttpd] ubus: add new RESTful API

Hi, > Regarding parsing events stream, event names with spaces seem to be OK: > https://html.spec.whatwg.org/multipage/server-sent-events.html#parsing-an-event-stream To me it feels quirky to separate the path and the type of the event by space. Personally I'd only report the type as "event:" an

Re: [PATCH uhttpd] ubus: rename JSON-RPC format related functions

Hi, > Use "_json_rpc_" in their names so it's clear they are related to the > JSON-RPC format. This cleans up code a bit and will allow adding more > formats in the future. > > Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich signature.asc Descript

Re: [PATCH 3/4] build: image: remove strange useless comment

Hi Adrian, > compat_version=$(if $(DEVICE_COMPAT_VERSION),$(DEVICE_COMPAT_VERSION),1.0) > json_quote=$(subst ','\'',$(subst ",\",$(1))) > -#")') This commit was most likely added to aid text editors with naive syntax highlighting capabilities that fail to properly detect the end of the string d

Merged: tools/firmware-utils: use UTC for image timestamps

Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: jsonfilter and queries with '-' in them

Hi, as already implied by Dirk, you need to use bracket notation for labels that are not valid variable identifiers. So instead of `@.foo-bar` use `@["foo-bar"]`. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing li

Re: jsonfilter and queries with '-' in them

Hi, > Could you write a little bit about the underlying cause of this just > so I can understand better? it is basically mimicking JavaScript object access syntax where labels after a dot must be valid identifiers. In JS, an expression `obj.foo-bar.baz` would be interpreted as `obj.foo` minus `b

Merged: options: fix parsing of boolean attributes

Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: Announcement: Removal of 4.14 kernel from master

Hi, > Why is ar71xx no longer going to be supported? because development shifted towards the upstream-approved and device tree based ath79 target. > This includes Netgear WNDR-3700-v4 which is a very popular and reliable router > in the OpenWRT community. The Netgear WNDR-3700-v4 is supported b

Re: [PATCH] tools: always create $STAGING_DIR/usr/{include,lib}

Hi, > rules.mk always passes these as -I/-L to the toolchain. > > Fixes rare errors like: > cc1: error: staging_dir/target-aarch64_cortex-a53_musl/usr/include: No such > file or directory [-Werror=missing-include-dirs] > > Signed-off-by: Andre Heider NAK - I'd prefer if we remove the faulty/r

Re: [PATCH] tools: always create $STAGING_DIR/usr/{include,lib}

Hi, > Isn't that breaking some packages which currently use `/usr/lib`? > > packages.git/boost: > https://github.com/openwrt/packages/blob/e2e152da599ceeacf06b4a045b5b391107d194df/libs/boost/Makefile#L485 I don't see how. The code you quoted creates the destination directory directly in the line

Re: [PATCH] tools: always create $STAGING_DIR/usr/{include,lib}

Hi, > Pretty much all packages stage into staging_dir/target-*/usr - I don't > think there are any -I/-L flags we can remove. we're patching the gcc specs [1], [2] to implicitly add $STAGING_DIR/usr/lib to the link- and $STAGING_DIR/usr/include to the CPP flags. There is no need to globally pass

Re: UCI: Making a config read-only?

Hi, > Is there a way to truly make a configuration read only in UCI, so that > changes are rejected, and not stored in /tmp/.uci/ ? there is no such facility implemented in uci or libuci. ~ Jo signature.asc Description: OpenPGP digital signature ___

Re: [PATCH] libcxxabi: fix compilation under the SDK

Hi, > + $(MAKE) -C $(TOPDIR)/$(if > $(CONFIG_IN_SDK),feeds/base/)package/libs/libcxx prepare this looks like an ugly hack, also the feed is not guaranteed to reside in feeds/base/ - the user can theoretically change the name of the base feed. Why does this package need to trigger an prepare

Re: [OpenWrt-Devel] [PATCHv3] mdadm: revised mdadm config & init logic

Hi, comments inline. On 1/23/20 3:56 AM, Rosen Penev wrote: > From: Joseph Tingiris > > This is a significant revision of /etc/init.d/mdadm. It adds new > features, support for new configuration options, safer error > handling, (configurable) verbose output, and contains multiple bug > fixes.

[PATCH 2/2] rules.mk: simplify FAKEROOT command line

Since fakeroot is patched to discover related ressources relative to the STAGING_DIR_HOST environment variable, there is no need to pass the path to faked or the preload library manually anymore. Signed-off-by: Jo-Philipp Wich --- rules.mk | 7 +-- 1 file changed, 1 insertion(+), 6

[PATCH 1/2] fakeroot: make fakeroot script relocatable

invoke fakeroot and subsequently allows us to drop OS X specific logic. Signed-off-by: Jo-Philipp Wich --- tools/fakeroot/patches/000-relocatable.patch | 25 1 file changed, 25 insertions(+) create mode 100644 tools/fakeroot/patches/000-relocatable.patch diff --git a/tools

Re: [PATCH 2/2] rules.mk: simplify FAKEROOT command line

Hi, please disregard, I made a logical mistake and forgot that the OS X check is about the *.dylib vs. *.so extension, not the library location. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@li

Re: [PATCH 2/2] rules.mk: simplify FAKEROOT command line

Hi again, > please disregard, I made a logical mistake and forgot that the OS X check is > about the *.dylib vs. *.so extension, not the library location. actually it seems fine after all since the proper extension is embedded in the fakeroot script according to whats applicable to the host system

Merged: zram-swap: default to lzo instead of lzo-rle compression

Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] scripts: bundle-libraries.sh: fix broken SDK compiler

Hi Petr, instead of meddling with the file permissions (which might cause unwanted side effects for .so's that *are* supposed to be executable) I'd suggest to simply skip *.so files by name. Something along the lines of: case "$BIN" in *.so|*.so.[0-9]*) : ;; *) [ -n "$LDD" ] && [ -x "$BI

Re: [PATCH v2] scripts: bundle-libraries.sh: fix broken SDK compiler

*) > + file "$bin" | grep -sqE "ELF.*(executable|interpreter)" && > return 0 Apart from this apparently inconsistent indentation (tabs vs. spaces?) - LGTM. Assuming the white space is straightened out... Acked-by: Jo-Philipp Wich ___

Re: [PATCH] fw4: fix ipset comment field from bool to string

Hi, the patch was whitespace mangled and didn't apply. After fixing it up manually, the Signed-off-by didn't match the author. Also the fixed option wasn't use anywhere so the fix was rather incomplete (or not useful by itself). It is superseded by https://git.openwrt.org/39e8c70 now. Regards, J

Re: [PATCH] fw4: add a range of icmpv6 types

Hi, the patch was white-space mangled and the Signed-off-by didn't match the author. It also introduced syntax errors in fw4.uc so it seems it hasn't been runtime tested at all. Superseded by https://git.openwrt.org/e6e82a5 and https://git.openwrt.org/30ee17a. signature.asc Description: OpenP

Re: [PATCH] ubus: added ubus_handle_events function that "guaranties" execution of all polled events

Hi, > In case of previous setup or calling flow ctx->cancel_poll is set to true > function ubus_handle_event may process ONLY ONE request, though the comment > says it processes events: > > /* call this for read events on ctx->sock.fd when not using uloop */ static > inline void ubus_handle_event

Re: Intention on moving board-2 blob to a separate repo

Hi Ansuel, this makes a lot of sense imho. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[RFC netifd 2/2] interface-ip: allow configuring routes without explicit interface

-Philipp Wich --- interface-ip.c | 16 interface-ip.h | 3 +++ system-linux.c | 3 +++ 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/interface-ip.c b/interface-ip.c index fee29a9..d2fe385 100644 --- a/interface-ip.c +++ b/interface-ip.c @@ -405,6 +405,7

[RFC netifd 1/2] interface-ip: mask out host bits in IPv4 route targets

figuration. Signed-off-by: Jo-Philipp Wich --- interface-ip.c | 4 1 file changed, 4 insertions(+) diff --git a/interface-ip.c b/interface-ip.c index a06a514..fee29a9 100644 --- a/interface-ip.c +++ b/interface-ip.c @@ -441,6 +441,10 @@ interface_ip_add_route(struct interface *iface, struct

Re: firewall4: loopback device is ACCEPTED before include chain-prepend input

Hi, > [...] > Is there a reason why this decision was made, to add the custom include after > the loopback interface? Performance considerations, mostly. It violates pola though since it deviates from the behavior of other chain includes, so I'm okay with moving the include before the loopback ch

Re: Are we still use md5 as default as password hash?

Hi, Does the following do the trick? you will also need to enable additional ciphers in musl libc (disabling the crypt size hack). ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/open

Re: Are we still use md5 as default as password hash?

Hi, you will also need to enable additional ciphers in musl libc (disabling the crypt size hack). Please disregard that remark, it has already been pointed out that the hack is disabled by default since quite some time. ~ Jo ___ openwrt-devel m

Re: ustream-ssl ABI_VERSION usage

Hi Paul, While working on using APK instead of OPKG, I started to look into ABI versions of different packages and found that ustream-ssl always install libustream-ssl.so , with no ABI version attached. $(INSTALL_DATA) $(PKG_INSTALL_DIR)/usr/lib/libustream-ssl.so $(1

Re: [PATCH] base-files: sysupgrade: include uci-defaults script disabling services

Hi Rafał, Extend sysupgrade to check for disabled services, generate uci-defaults script disabling them and include it in backup. Cc: Christian Marangi Cc: Jo-Philipp Wich Cc: Jonas Gorski Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich

Re: [PATCH 1/3] base-files: sysupgrade: add tar.sh with helpers for building archives

Hi Rafał, thanks for taking are of this. Please find some comments below. Am 2/26/24 um 15:14 schrieb Rafał Miłecki: From: Jo-Philipp Wich This allows building uncompressed tar archives from shell scripts (and compressing them later if needed) Signed-off-by: Rafał Miłecki --- package

Re: [PATCH V2 1/3] base-files: sysupgrade: add tar.sh with helpers for building archives

Hi Rafał, comments inline. Sorry for the bikeshedding ahead. ~ Jo [...] + +__tar_print_padding() { + dd if=/dev/zero bs=$1 count=1 2>/dev/null $1 may be 0 which is an invalid value for `bs=`: root@OpenWrt:~# dd bs=0 dd: number 0 is not in 1..2147483647 range A value of "0" is val

Re: [PATCH V3 1/3] base-files: sysupgrade: add tar.sh with helpers for building archives

Hi, [...] This allows building uncompressed tar archives from shell scripts (and compressing them later if needed) Signed-off-by: Rafał Miłecki Signed-off-by: Jo-Philipp Wich ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [PATCH V3 2/3] base-files: sysupgrade: use tar helper to include installed_packages.txt

s own limitations (mount points). Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH V3 3/3] base-files: sysupgrade: add uci-defaults script disabling services #2

Hi, [...] Extend sysupgrade to check for disabled services, generate uci-defaults script disabling them and include it in backup. Cc: Christian Marangi Cc: Jo-Philipp Wich Cc: Jonas Gorski Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich ~ Jo

Re: here we are again: real name 'discussion'

Hi, [resent to list] a) It's a policy change and not a code change. Policy changes require a vote Then take a(nother) vote. https://lists.openwrt.org/pipermail/openwrt-devel/2024-January/042063.html b) Just because the kernel changed their interpretation of DCO requirements doesn't mean t

Re: [PATCH 1/7] lldpd: fixed interface(s) parsing

Hi, For interface type parameters, the man page documents patterns: ``` *,!eth*,!!eth1 uses all interfaces, except interfaces starting with "eth", but including "eth1". ``` at some point, uci configuration was meant to provide a somewhat sane config abstraction over various damon specific na

Re: [PATCH 3/7] lldpd: fix restart

Hi, redirection broke in 5364fe0f01ca11b47c55d78f756d3176748dd0c2 why did this slip through in the first place? Seems that neither the submitter (you) nor the comitter actually runtime tested those changes described as " No functionality/behaviour changes; code is synonymous". ~ Jo __

Re: [PATCH 4/7] lldpd: note about capabilities

Hi, What's the purpose of this isolated comment? Either we're shipping version >= v1.0.15 so this code is guaranteed to work or we don't, in which case the code should not be there. We're not putting such comments next to all other option handling code either. ~ Jo _

Re: [PATCH 5/7] lldpd: make capabilities advertisement controllable

Hi, comment below. Am 4/2/24 um 15:02 schrieb Paul Donald: Defaults to off. Only available from >= 1.0.15 These capabilities are sent in TLV. Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 7 +++ 1 file changed, 7 insertions(+) diff --git a/package/

Re: [PATCH 6/7] lldpd: make management address advertisement controllable

Hi, comment below. Am 4/2/24 um 15:02 schrieb Paul Donald: Defaults to off. Available from >= 0.7.15 These are sent in TLV Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 6 ++ 1 file changed, 6 insertions(+) diff --git a/package/network/services/lld

Re: [PATCH 6/7] lldpd: make management address advertisement controllable

Hi, comment below. Am 4/2/24 um 15:02 schrieb Paul Donald: Defaults to off. Available from >= 0.7.15 These are sent in TLV Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 6 ++ 1 file changed, 6 insertions(+) diff --git a/package/network/services/lld

<    1   2   3   4   5   6   7   8   9   10   >