Re: [OpenWrt-Devel] [PATCH 2/2] ath79: add support for Fritz!Box 4020

2018-08-13 Thread Mathias Kresin
13.08.2018 08:23, John Crispin: Hi this following chunk need to be annotated and sent upstream. also using initvals might not be the best option. please also check if there is a binding doc and add this new property. You might want to name the property "lines-initial-states" as defined for

Re: [OpenWrt-Devel] openwrt/packages: [RFC] Regarding preferences re: switch to codeload

2018-08-13 Thread Jo-Philipp Wich
Hi, personally I'm opposed to the entire code load thing. First of all I was unable to reproduce the tarballs offered by Github. Github seems to use an extended tar (pax) format while we pack our SCM clones using the more traditional ustar format, however even using `tar -cp -H pax --numeric-own

Re: [OpenWrt-Devel] openwrt/packages: [RFC] Proposed flattening of menuconfig menus

2018-08-13 Thread Karl Palsson
"Daniel F. Dickinson" wrote: > Posting on list as I think the discussion should include as > folks as possible in the discussion. > > https://github.com/openwrt/packages/issues/6745 > > > Especially when getting started with OpenWrt finding things in menuconfig > > is complicated by the second

Re: [OpenWrt-Devel] openwrt/packages: [RFC] Proposed flattening of menuconfig menus

2018-08-13 Thread Daniel F. Dickinson
On 2018-08-13 06:19 AM, Karl Palsson wrote: > > "Daniel F. Dickinson" wrote: >> Posting on list as I think the discussion should include as >> folks as possible in the discussion. >> >> https://github.com/openwrt/packages/issues/6745 >> >>> Especially when getting started with OpenWrt finding thi

[OpenWrt-Devel] [PATCH 2/2] kernel: bump 3.18 to 3.18.118

2018-08-13 Thread Koen Vandeputte
Refreshed all patches. Compile-tested on: adm5120, adm8668, au1000, mcs814x, ppc40x, ppc44x, xburst Runtime-tested on: none Signed-off-by: Koen Vandeputte --- include/kernel-version.mk | 4 +- .../patches-3.18/007-adm5120_pci.patch| 2 +- .../101-cfi_fixup_macronix

[OpenWrt-Devel] [PATCH 1/2] ar7: remove linux 3.18 support

2018-08-13 Thread Koen Vandeputte
This target is on 4.9 currently. It seems the support for this old kernel never got dropped. Signed-off-by: Koen Vandeputte --- target/linux/ar7/config-3.18 | 129 .../001-mips-ar7-fix-serial.patch | 23 -- ...re-the-port-type-s-FCR-value-is-used.patch | 4

Re: [OpenWrt-Devel] [PATCH] uci: do not access invalid memory when updating an existing section

2018-08-13 Thread Yousong Zhou
On Sun, 12 Aug 2018 at 14:41, Enrico Mioso wrote: > > If a new section with the same name and type of an old one is found, a > memory reallocation happens. Still, the options list for the section is > not reinitialized, hence a stale pointer is being used. > > Signed-off-by: Enrico Mioso > --- >

Re: [OpenWrt-Devel] openwrt/packages: [RFC] Regarding preferences re: switch to codeload

2018-08-13 Thread John Crispin
On 13/08/18 11:45, Jo-Philipp Wich wrote: So TLDR; I prefer a locally reproducible, cached tarball of a given SCM clone over an opaque Github offer. I would like to second that notion     John ___ openwrt-devel mailing list openwrt-devel@lists.open

[OpenWrt-Devel] RFT: ar71xx/mac80211 update

2018-08-13 Thread John Crispin
Hi, as 19.01 will probably use v4.14 as baseline and ath79 wont be a full replacement for ar71xx by then we decided to bump ar71xx to v4.14. This is available for testing inside my staging tree -> https://git.openwrt.org/?p=openwrt/staging/blogic.git;a=shortlog;h=refs/heads/staging The tree

[OpenWrt-Devel] [PATCH] ath79: Add support of Tp_Link MR-3040 v2

2018-08-13 Thread Dmitry Tunin
Add support for the ar71xx supported Tp_link MR-3040 v2 to ath79. Signed-off-by: Dmitry Tunin --- .../linux/ath79/base-files/etc/board.d/02_network | 1 + .../linux/ath79/dts/ar9331_tplink_tl-mr3040-v2.dts | 161 + target/linux/ath79/image/tiny-tp-link.mk | 10 +

Re: [OpenWrt-Devel] [PATCH] ath79: Add support of Tp_Link MR-3040 v2

2018-08-13 Thread Mathias Kresin
2018-08-13 18:28 GMT+02:00 Dmitry Tunin : > Add support for the ar71xx supported Tp_link MR-3040 v2 to ath79. > > Signed-off-by: Dmitry Tunin > --- > .../linux/ath79/base-files/etc/board.d/02_network | 1 + > .../linux/ath79/dts/ar9331_tplink_tl-mr3040-v2.dts | 161 > + >

Re: [OpenWrt-Devel] [PATCH] ath79: Add support of Tp_Link MR-3040 v2

2018-08-13 Thread Dmitry Tunin
13.08.2018 19:34, Mathias Kresin пишет: 2018-08-13 18:28 GMT+02:00 Dmitry Tunin : Add support for the ar71xx supported Tp_link MR-3040 v2 to ath79. Signed-off-by: Dmitry Tunin --- .../linux/ath79/base-files/etc/board.d/02_network | 1 + .../linux/ath79/dts/ar9331_tplink_tl-mr3040-v2.dt

Re: [OpenWrt-Devel] [PATCH] ath79: Add support of Tp_Link MR-3040 v2

2018-08-13 Thread Dmitry Tunin
13.08.2018 19:34, Mathias Kresin пишет: 2018-08-13 18:28 GMT+02:00 Dmitry Tunin : Add support for the ar71xx supported Tp_link MR-3040 v2 to ath79. Signed-off-by: Dmitry Tunin --- .../linux/ath79/base-files/etc/board.d/02_network | 1 + .../linux/ath79/dts/ar9331_tplink_tl-mr3040-v2.dt

Re: [OpenWrt-Devel] openwrt/packages: [RFC] Regarding preferences re: switch to codeload

2018-08-13 Thread Rosen Penev
On Mon, Aug 13, 2018 at 2:45 AM Jo-Philipp Wich wrote: > > Hi, > > personally I'm opposed to the entire code load thing. > > First of all I was unable to reproduce the tarballs offered by Github. > > Github seems to use an extended tar (pax) format while we pack our SCM > clones using the more tra

Re: [OpenWrt-Devel] openwrt/packages: [RFC] Regarding preferences re: switch to codeload

2018-08-13 Thread Daniel F. Dickinson
On 2018-08-13 01:45 PM, Rosen Penev wrote: >> Furthermore I dislike the idea of tailoring download mechanisms around a >> specific proprietary service. This I agree with >> >> If the allegations about hash changes for unknown reasons are correct, >> then this raises a huge red flag for me > I ca

[OpenWrt-Devel] automated hardware test setup

2018-08-13 Thread Alexander Couzens
Hi, I've won the prototype fund to work for the next 6 months on building up an automated hardware testing infrastructure [0]. I'll use LAVA [1] for it. The rough idea is to bootstrap an infrastructure for hw tests which also allow the community to contribute. Documentation is part of project wh

Re: [OpenWrt-Devel] [PATCH] uci: do not access invalid memory when updating an existing section

2018-08-13 Thread Enrico Mioso
Hello, and thank you for your help, and review. I agree on not changing behaviour. the problem is not actually a memory leak, but the fact that ptr->s->options seems to not be a valid pointer at that point. At least, this is what valgrind suggested, if I am not wrong or interpreting wrongly the o

Re: [OpenWrt-Devel] [PATCH] uci: do not access invalid memory when updating an existing section

2018-08-13 Thread Yousong Zhou
On Tue, 14 Aug 2018 at 04:56, Enrico Mioso wrote: > > Hello, and thank you for your help, and review. > I agree on not changing behaviour. the problem is not actually a memory leak, > but the fact that ptr->s->options seems to not be a valid pointer at that > point. > At least, this is what valg

Re: [OpenWrt-Devel] [PATCH] uci: do not access invalid memory when updating an existing section

2018-08-13 Thread Enrico Mioso
Hello! First of all, thank you very very much for your patience and review. You are right, my patch introduces an unintended change in behaviour, and actually does not solve the problem. That day I didn't see this. However, I think it is still useful to report what happens here, even just for t