Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-30 Thread Sergey Ryazanov
> > To: Adrian Schmutzler ; Denis Kalashnikov > > > > Cc: OpenWrt Development List ; Gabor > > Juhos ; Koen Vandeputte > > > > Subject: Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G > > > > Hello Adrian and Denis, > > > > s

RE: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-30 Thread Adrian Schmutzler
#x27;Gabor Juhos' ; 'Sergey Ryazanov' > > Subject: Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G > > > On 23.05.21 11:01, Adrian Schmutzler wrote: > > ... > >> diff --git a/target/linux/ath79/image/mikrotik.mk > >> b/targe

RE: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-30 Thread Adrian Schmutzler
Vandeputte > > Subject: Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G > > Hello Adrian and Denis, > > sorry for interfering with your conversation, I would like to discuss the best > way to document not yet finished functionality. Please find my question an

Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-27 Thread Koen Vandeputte
On 23.05.21 11:01, Adrian Schmutzler wrote: ... diff --git a/target/linux/ath79/image/mikrotik.mk b/target/linux/ath79/image/mikrotik.mk index 74f8603b5a..0072ec527d 100644 --- a/target/linux/ath79/image/mikrotik.mk +++ b/target/linux/ath79/image/mikrotik.mk @@ -9,6 +9,15 @@ define Device/mikr

Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-26 Thread Denis K
> I am just curious, why did you place beeper and LEDs in the root node, > but specify latch and NAND as the AHB bus child nodes? Ack, you are right. > > + /* NAND control gpios */ > > + read-gpios = <&gpio_latch 3 GPIO_ACTIVE_HIGH>; > > + rdy-gpios = <&g

Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-26 Thread Denis K
Hello Sergey > the device tree has a dualistic > nature, on one hand it is a place for driver configuration, on the > other hand it is a way to document board stuff interconnections I agree with you here, but I don't think that I should insist on this.

Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-26 Thread Denis K
Hello Adrian > > +&spi { > > + status = "okay"; > > + > > + compatible = "qca,ar7100-spi"; > > + > > + cs-gpios = <0>, <&gpio_latch 0 GPIO_ACTIVE_LOW>; > > Are you sure you need cs-gpios here? We've removed it everywhere else (for > &spi node): > https://github.com/openwrt/openwrt/com

Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-24 Thread Sergey Ryazanov
On Fri, May 21, 2021 at 2:05 PM Denis Kalashnikov wrote: > > This board has been supported in the ar71xx. > > Links: > * https://mikrotik.com/product/RB912UAG-2HPnD > * https://mikrotik.com/product/RB912UAG-5HPnD > * https://openwrt.org/toh/hwdata/mikrotik/mikrotik_rb912uag-2hpnd > * https://openw

Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-24 Thread Sergey Ryazanov
Hello Adrian and Denis, sorry for interfering with your conversation, I would like to discuss the best way to document not yet finished functionality. Please find my question and proposal below. On Sun, May 23, 2021 at 12:01 PM Adrian Schmutzler wrote: [skipped] >> + beeper { >> +

RE: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-23 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Denis Kalashnikov > Sent: Freitag, 21. Mai 2021 13:05 > To: openwrt-devel@lists.openwrt.org > Cc: Gabor Juhos ; Koen Vandeputte > ; Sergey Ryazanov > > Subject: [RFC v2 3/3] ath7