Re: [PATCH v2] ramips: fix at803x patch again

2021-06-12 Thread David Bauer
Hi John, On 6/12/21 12:51 AM, John Thomson wrote: On Fri, 11 Jun 2021, at 08:10, David Bauer wrote: Can you be more precise in terms of which issues are you facing? The PHY capabilities on the AR8333 now read 1000B-X as a supported link mode, so fiber operation should be possible. Can you shar

Re: [PATCH v2] ramips: fix at803x patch again

2021-06-11 Thread John Thomson
On Fri, 11 Jun 2021, at 08:10, David Bauer wrote: > Can you be more precise in terms of which issues are you facing? The > PHY capabilities on > the AR8333 now read 1000B-X as a supported link mode, so fiber > operation should be possible. > > Can you share the capabilities advertised with curre

Re: [PATCH v2] ramips: fix at803x patch again

2021-06-11 Thread David Bauer
Hi, On 6/11/21 8:08 AM, DENG Qingfang wrote: > Hi David, > > Unfortunately, the issue is still not resolved, according to Minqiang. > Reverting your 2 commits and applying my patch fixes the issue. Can you be more precise in terms of which issues are you facing? The PHY capabilities on the AR83

Re: [PATCH v2] ramips: fix at803x patch again

2021-06-10 Thread DENG Qingfang
Hi David, Unfortunately, the issue is still not resolved, according to Minqiang. Reverting your 2 commits and applying my patch fixes the issue. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/op

Re: [PATCH v2] ramips: fix at803x patch again

2021-06-08 Thread DENG Qingfang
Hi René, On Mon, Jun 7, 2021 at 2:44 AM René van Dorst wrote: > Thank for fixing. > But I can't apply this patch clean on top of the current master > 04a260911ca0f10a0e37c487c220e1aae3623dda. > Which commit/branch are you using? David's patches have been applied to master, you can test it now.

Re: [PATCH v2] ramips: fix at803x patch again

2021-06-06 Thread René van Dorst via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Quoting DENG Qingfang : Commit

Re: [PATCH v2] ramips: fix at803x patch again

2021-06-06 Thread DENG Qingfang
Hi, On Sat, Jun 5, 2021 at 12:19 AM David Bauer wrote: > > See the commit "generic: backport at803x fixes" in my staging tree [0]. Your patch still adds .config_aneg to AR8035, not AR8031. > > I'll test this later this weekend on my AC Lite. > > [0] https://git.openwrt.org/?p=openwrt/staging/bl

Re: [PATCH v2] ramips: fix at803x patch again

2021-06-04 Thread John Thomson
On Fri, 4 Jun 2021, at 16:19, David Bauer wrote: > See the commit "generic: backport at803x fixes" in my staging tree [0]. > [0] https://git.openwrt.org/?p=openwrt/staging/blocktrron.git;a=summary This (efbaa6c8bd4c atop master) would not compile for me with 5.4? CONFIG_TARGET_ramips=y CONFIG_TARG

Re: [PATCH v2] ramips: fix at803x patch again

2021-06-04 Thread David Bauer
Hi, On 6/4/21 10:57 AM, DENG Qingfang wrote: > Hi, > > On Fri, Jun 4, 2021 at 3:37 PM David Bauer wrote: >> As the original patch still has to be backported to 21.02, I'd propose >> to remove my hacks and instead properly backport c329e5af and 8f7e8762 >> from upstream. >> >> This would remove t

Re: [PATCH v2] ramips: fix at803x patch again

2021-06-04 Thread DENG Qingfang
Hi, On Fri, Jun 4, 2021 at 3:37 PM David Bauer wrote: > As the original patch still has to be backported to 21.02, I'd propose > to remove my hacks and instead properly backport c329e5af and 8f7e8762 > from upstream. > > This would remove the need to hack around the first hack and hopefully > les

Re: [PATCH v2] ramips: fix at803x patch again

2021-06-04 Thread David Bauer
Hi, On 6/4/21 7:12 AM, DENG Qingfang wrote: > Commit 8222f8e1b9be overrides AR8031's PHY features, making its SFP > link status detection unavailable. To fix that, do not override it in > ramips patch. As the original patch still has to be backported to 21.02, I'd propose to remove my hacks and i

[PATCH v2] ramips: fix at803x patch again

2021-06-03 Thread DENG Qingfang
Commit 8222f8e1b9be overrides AR8031's PHY features, making its SFP link status detection unavailable. To fix that, do not override it in ramips patch. Commit 6d4ef6792612 also moves .config_aneg to AR8035 by mistake, fix that as well. Reported-by: CHEN Minqiang Fixes: 8222f8e1b9be ("ath79: fix