Re: [PATCH 2/2] iproute2: add support for link set

2022-01-22 Thread Marek BehĂșn
On Sat, 22 Jan 2022 09:38:01 + Rui Salvaterra wrote: > Hi, Ansuel, > > On Sat, 22 Jan 2022 at 01:08, Ansuel Smith wrote: > > > > > > So.. how should we proceed with this? From what I understand the idea is to > > merge this ASAP. > > But not a moment sooner. ;) I'm sure we agree that th

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-22 Thread Rui Salvaterra
Hi, Ansuel, On Sat, 22 Jan 2022 at 01:08, Ansuel Smith wrote: > > > So.. how should we proceed with this? From what I understand the idea is to > merge this ASAP. But not a moment sooner. ;) I'm sure we agree that this patch won't be merged upstream in its current form, according to the comment

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-21 Thread Ansuel Smith
> > On Fri, Jan 21, 2022 at 09:14:50PM +, Rui Salvaterra wrote: > > On Fri, 21 Jan 2022 at 21:11, Ansuel Smith wrote: > > > > > > Should we follow the suggestion and add a specific attribute just for DSA? > > I believe that would be the right thing to do, but I'd like to know > > what Daniel a

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-21 Thread Daniel Golle
On Fri, Jan 21, 2022 at 09:14:50PM +, Rui Salvaterra wrote: > On Fri, 21 Jan 2022 at 21:11, Ansuel Smith wrote: > > > > Should we follow the suggestion and add a specific attribute just for DSA? > I believe that would be the right thing to do, but I'd like to know > what Daniel and Marek think

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-21 Thread Rui Salvaterra
On Fri, 21 Jan 2022 at 21:11, Ansuel Smith wrote: > > > Should we follow the suggestion and add a specific attribute just for DSA? I believe that would be the right thing to do, but I'd like to know what Daniel and Marek think about it too. ___ openwrt

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-21 Thread Ansuel Smith
> > Hi, Ansuel, > > After reading the patch more carefully, I have to say I'm really not fond of > it in its current form, especially considering that the original feedback > from Stephen Hemminger and Vladimir Oltean [1] hasn't been addressed. To be > honest, overloading the IFLA_LINK attribute

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-21 Thread Rui Salvaterra
[Apologies for resending, Gmail turned my message into HTML behind my back.] Hi, Ansuel, After reading the patch more carefully, I have to say I'm really not fond of it in its current form, especially considering that the original feedback from Stephen Hemminger and Vladimir Oltean [1] hasn't bee

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-20 Thread Rui Salvaterra
Hi again, On Thu, 20 Jan 2022 at 15:56, Rui Salvaterra wrote: > > Nice, but we'll need to do the same for BusyBox's ip applet. Let's not > force everyone who needs multi-CPU DSA to install iproute2's ip just > for this case. ;) Just to clarify, I'll take care of the BusyBox side of things, don't

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-20 Thread Rui Salvaterra
Hi, Ansuel, On Thu, 20 Jan 2022 at 15:11, Ansuel Smith wrote: > > Add support for link set useful to set CPU port for dsa drivers. > > Signed-off-by: Ansuel Smith > --- > ...-iplink_allow_to_change_iplink_value.patch | 94 +++ > 1 file changed, 94 insertions(+) > create mode 10

[PATCH 2/2] iproute2: add support for link set

2022-01-20 Thread Ansuel Smith
Add support for link set useful to set CPU port for dsa drivers. Signed-off-by: Ansuel Smith --- ...-iplink_allow_to_change_iplink_value.patch | 94 +++ 1 file changed, 94 insertions(+) create mode 100644 package/network/utils/iproute2/patches/191-iplink_allow_to_change_iplink_