On Fri, Jan 21, 2022 at 09:14:50PM +0000, Rui Salvaterra wrote: > On Fri, 21 Jan 2022 at 21:11, Ansuel Smith <ansuels...@gmail.com> wrote: > > > > Should we follow the suggestion and add a specific attribute just for DSA? > I believe that would be the right thing to do, but I'd like to know > what Daniel and Marek think about it too.
While adding a new attribute for the DSA CPU port linked means more added complexity, I still believe it's the right thing to do if that's what would be acceptable upstream and hence significantly reduce the burden of having to maintain and forward-port the patch locally in the long run. Personally I perceive the use of the existing 'set link' attribute to be sound and aligned with it's use in other contexts, but that's most certainly a matter of taste. _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
