RE: [PATCH] tools: Add PKG_VERSION to sstrip

2020-07-22 Thread mail
> > This obviously applies to all the similar patches you sent in parallel. > > Despite, note that the common practice for PKG_RELEASE is to use plain > integer numbers, so no major.minor. I don't think that's as important as my > first point, but I'd say only deviate from the plain integer numbers

Re: [PATCH] tools: Add PKG_VERSION to sstrip

2020-07-22 Thread Paul Spooren
] tools: Add PKG_VERSION to sstrip Comparing the in tree stored source file of sstrip suggests it's version 2.0[0], reflect that in the Makefile. note that conceptually, PKG_VERSION is for _external_ packages: https://openwrt.org/docs/guide-developer/packages#buildpackage_variables "P

RE: [PATCH] tools: Add PKG_VERSION to sstrip

2020-07-22 Thread mail
Hi Paul, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Paul Spooren > Sent: Donnerstag, 23. Juli 2020 00:15 > To: openwrt-devel@lists.openwrt.org > Cc: Paul Spooren > Subject: [PATCH] tools: Add

[PATCH] tools: Add PKG_VERSION to sstrip

2020-07-22 Thread Paul Spooren
Comparing the in tree stored source file of sstrip suggests it's version 2.0[0], reflect that in the Makefile. Motivation is the tracking of changes in the buildsystem, which requires versioning of packages. [0]: https://github.com/BR903/ELFkickers/commit/df4426a0f0ada861064d75c08cbebaac7c16b3ae