> > This obviously applies to all the similar patches you sent in parallel. > > Despite, note that the common practice for PKG_RELEASE is to use plain > integer numbers, so no major.minor. I don't think that's as important as my > first point, but I'd say only deviate from the plain integer numbers when > having a reason (since, actually, if the code remains untouched for several > years, nobody will maintain a reasonable major/minor versioning anyway, > and it's easier to just bump by "1" on each change). > > > > Personally, to be honest, I'd just add PKG_RELEASE := 1 to all of the > previously unversioned packages. > Isn't it cleaner to state the upstream version of a package in the Makefile > even if the code is stored locally? I know sstrip is locally patch-hacked but > I > think it's better to state version 2.0 instead of release 1. Let's say > version 3.1a > brings some legit binary size improvements, no one could tell by reading > release 1.
If there really is an upstream version and the local code is still in a state where tracking that version makes sense, I'm all in for using that. I'd even use PKG_VERSION and PKG_RELEASE then, as for any real package with upstream content. If the code is truly local, or in a state where it cannot be compared with an "upstream" version reasonably, I'd go for plain PKG_RELEASE. Best Adrian > >> Motivation is the tracking of changes in the buildsystem, which > >> requires versioning of packages. > >> > >> [0]: > >> > https://github.com/BR903/ELFkickers/commit/df4426a0f0ada861064d75c08c > >> bebaac7c16b3ae#diff-d3ba694d91432a068d5d3b36abf8cd0f > >> > >> Signed-off-by: Paul Spooren <m...@aparcar.org> > >> --- > >> tools/sstrip/Makefile | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/tools/sstrip/Makefile b/tools/sstrip/Makefile index > >> 180bd1743e..99be063f4c 100644 > >> --- a/tools/sstrip/Makefile > >> +++ b/tools/sstrip/Makefile > >> @@ -7,6 +7,7 @@ > >> include $(TOPDIR)/rules.mk > >> > >> PKG_NAME:=sstrip > >> +PKG_VERSION:=2.0 > >> > >> include $(INCLUDE_DIR)/host-build.mk > >> > >> -- > >> 2.25.1 > >> > >> > >> _______________________________________________ > >> openwrt-devel mailing list > >> openwrt-devel@lists.openwrt.org > >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
