Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-14 Thread Bjørn Mork
Jordan Geoghegan writes: > This isn't about 500 bytes of space anymore is it? FWIW, I believe it is. It is about the sum of all the 500 bytes of space contributed by each feature which doesn't qualify as strictly necessary. The upside is that OpenWrt runs on devices with almost no RAM and fla

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-14 Thread Jordan Geoghegan
On 2020-07-14 02:54, Bjørn Mork wrote: Jordan Geoghegan writes: 'tr' is a standard system utility, I wasn't expecting such pushback against making it behave as every other modern implementation does. OpenWrt exists because it is different from every other distribution. https://openwrt.org/

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-14 Thread Bjørn Mork
Jordan Geoghegan writes: > 'tr' is a standard system utility, I wasn't expecting such pushback > against making it behave as every other modern implementation does. OpenWrt exists because it is different from every other distribution. https://openwrt.org/about describes it as "all the features

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-14 Thread Jordan Geoghegan
On 2020-07-14 02:08, Petr Štetiar wrote: Jordan Geoghegan [2020-07-13 23:06:30]: Also, the use of "tr 'a-z'..." is unsafe for exotic locales Buildsystem sets LC_ALL=C explicitly, so whats the issue here? I've reported that 'tr' behaves abnormally, that's about all I can do. If you guys w

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-14 Thread Petr Štetiar
Jordan Geoghegan [2020-07-13 23:06:30]: > Also, the use of "tr 'a-z'..." is unsafe for exotic locales Buildsystem sets LC_ALL=C explicitly, so whats the issue here? ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.o

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-14 Thread Petr Štetiar
Jordan Geoghegan [2020-07-13 22:44:05]: > scripts/mkits.sh > 59:ARCH_UPPER=$(echo "$ARCH" | tr '[:lower:]' '[:upper:]') What's a problem here? It's running on host, so this classes are supported. > ryzen$ rg "tr '\[" > utils/lxc/patches/010-Remove-distro-check.patch > 43:-with_distro=`echo ${wi

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Jordan Geoghegan
On 2020-07-13 22:56, Rosen Penev wrote: On Mon, Jul 13, 2020 at 10:44 PM Jordan Geoghegan wrote: On 2020-07-13 22:17, Rosen Penev wrote: On Mon, Jul 13, 2020 at 12:14 PM Jordan Geoghegan wrote: On 2020-07-13 08:36, Petr Štetiar wrote: Magnus Kroken [2020-07-13 15:49:30]: Hi, Suppor

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Rosen Penev
On Mon, Jul 13, 2020 at 10:44 PM Jordan Geoghegan wrote: > > > > On 2020-07-13 22:17, Rosen Penev wrote: > > On Mon, Jul 13, 2020 at 12:14 PM Jordan Geoghegan > > wrote: > >> > >> > >> On 2020-07-13 08:36, Petr Štetiar wrote: > >>> Magnus Kroken [2020-07-13 15:49:30]: > >>> > >>> Hi, > >>> > >>

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Jordan Geoghegan
On 2020-07-13 22:17, Rosen Penev wrote: On Mon, Jul 13, 2020 at 12:14 PM Jordan Geoghegan wrote: On 2020-07-13 08:36, Petr Štetiar wrote: Magnus Kroken [2020-07-13 15:49:30]: Hi, Support for character classes (e.g. [:upper:] and [:lower:]) and equivalence classes (e.g. [=a=]) in the tr

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Rosen Penev
On Mon, Jul 13, 2020 at 12:14 PM Jordan Geoghegan wrote: > > > > On 2020-07-13 08:36, Petr Štetiar wrote: > > Magnus Kroken [2020-07-13 15:49:30]: > > > > Hi, > > > >> Support for character classes (e.g. [:upper:] and [:lower:]) and > >> equivalence classes (e.g. [=a=]) in the tr utility are requ

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Jordan Geoghegan
On 2020-07-13 08:36, Petr Štetiar wrote: Magnus Kroken [2020-07-13 15:49:30]: Hi, Support for character classes (e.g. [:upper:] and [:lower:]) and equivalence classes (e.g. [=a=]) in the tr utility are required by POSIX. This change increases package size by approx. 500 bytes. where does O

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Petr Štetiar
Magnus Kroken [2020-07-13 15:49:30]: Hi, > Support for character classes (e.g. [:upper:] and [:lower:]) and > equivalence classes (e.g. [=a=]) in the tr utility are required by POSIX. > This change increases package size by approx. 500 bytes. where does OpenWrt claims, that it's fully POSIX com

[PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Magnus Kroken
Support for character classes (e.g. [:upper:] and [:lower:]) and equivalence classes (e.g. [=a=]) in the tr utility are required by POSIX. This change increases package size by approx. 500 bytes. Size before: 208372 busybox_1.31.1-1_mips_24kc.ipk Size after: 208895 busybox_1.31.1-1_mips_24kc.ipk