* Felix Fietkau [10.11.2013 14:36]:
> > also every script which needs an action has to fork, e.g.
> > in '/etc/hotplug.d/iface/50-olsrd' we call
> >
> > /etc/init.d/olsrd restart
> >
> > maybe we can just source 'rc.common' once in '/sbin/hotplug-call'
> > and so we can call just 'restart' when
* Felix Fietkau [10.11.2013 16:24]:
> > if there are no files, than the call is e.g.:
> >
> > command . /etc/hotplug.d/iface/*
> >
> > (which throws an error, but does not hurt). the call
> I'd prefer preventing unnecessary logspam.
>
> > test -f $file && . $file
> >
> > is racy anyway. just u
On 2013-11-10 16:16, Bastian Bittorf wrote:
> * Felix Fietkau [10.11.2013 16:13]:
>> > for FILE in /etc/hotplug.d/$1/*; do (
>> >command . "$FILE"
>> > ); done
>> >
>> > because we know, that the directory exists
>> > and there is no need to fork "ls" and there
>> > is no need to check for a
* Felix Fietkau [10.11.2013 16:13]:
> > for FILE in /etc/hotplug.d/$1/*; do (
> > command . "$FILE"
> > ); done
> >
> > because we know, that the directory exists
> > and there is no need to fork "ls" and there
> > is no need to check for a file if we use 'command'
> > (a builtin). FILE shoul
* Felix Fietkau [10.11.2013 15:22]:
> You could try this patch to see if it makes a difference wrt. boot time:
>
> ---
> --- a/package/system/procd/files/hotplug.json
> +++ b/package/system/procd/files/hotplug.json
> @@ -69,8 +69,14 @@
> [ "exec", "/etc/rc.button/%BUTTON%" ]
>
On 2013-11-10 16:02, Bastian Bittorf wrote:
> * Felix Fietkau [10.11.2013 15:22]:
>> We could then also make it check if the /etc/hotplug.d/$SUBSYSTEM
>> directory exists before issuing a call to /sbin/hotplug-call.
>
> this sounds good. so in /sbin/hotplug-call there is
> everytime the check
>
* Felix Fietkau [10.11.2013 15:22]:
> We could then also make it check if the /etc/hotplug.d/$SUBSYSTEM
> directory exists before issuing a call to /sbin/hotplug-call.
this sounds good. so in /sbin/hotplug-call there is
everytime the check
[ \! -z "$1" -a -d /etc/hotplug.d/$1 ] && {
...
On 2013-11-10 14:30, Felix Fietkau wrote:
> On 2013-11-10 14:25, Bastian Bittorf wrote:
>> * Felix Fietkau [10.11.2013 13:13]:
>>> For it to matter, I'm more interested in the absolute time saved than
>>> relative differences on a completely unrealistic number of iterations.
>>> In the case you're
On 2013-11-10 14:25, Bastian Bittorf wrote:
> * Felix Fietkau [10.11.2013 13:13]:
>> For it to matter, I'm more interested in the absolute time saved than
>> relative differences on a completely unrealistic number of iterations.
>> In the case you're describing, it's still only saving about 7 ms p
On 2013-11-10 13:41, Bastian Bittorf wrote:
> * Felix Fietkau [10.11.2013 13:13]:
>> > 3 sec vs. 70 sec...
>> > this was done on a strong board, on a weak board the difference is much
>> > bigger.
>> > This is only _one_ little optimization, and there are a lot of...
>> For it to matter, I'm more
* Felix Fietkau [10.11.2013 13:13]:
> For it to matter, I'm more interested in the absolute time saved than
> relative differences on a completely unrealistic number of iterations.
> In the case you're describing, it's still only saving about 7 ms per
> interface-up event, that's not a lot.
i did
* Felix Fietkau [10.11.2013 13:13]:
> > 3 sec vs. 70 sec...
> > this was done on a strong board, on a weak board the difference is much
> > bigger.
> > This is only _one_ little optimization, and there are a lot of...
> For it to matter, I'm more interested in the absolute time saved than
> relat
On 2013-11-10 08:09, Bastian Bittorf wrote:
> * Felix Fietkau [10.11.2013 08:00]:
>> > hotplug-call: script: /etc/hotplug.d/iface/00-netstate READY: 1194
>> > hotplug-call: script: /etc/hotplug.d/iface/15-teql START: 1194
>> > hotplug-call: script: /etc/hotplug.d/iface/15-teql READY: 1194
>> > hot
* Felix Fietkau [10.11.2013 08:00]:
> > hotplug-call: script: /etc/hotplug.d/iface/00-netstate READY: 1194
> > hotplug-call: script: /etc/hotplug.d/iface/15-teql START: 1194
> > hotplug-call: script: /etc/hotplug.d/iface/15-teql READY: 1194
> > hotplug-call: script: /etc/hotplug.d/iface/30-6relay
On 2013-11-09 21:27, Bastian Bittorf wrote:
> i recognized that a "simple" 'ifup lan' can be
> very expensive for a router with low ressources,
> below a typcal call/execution trace:
>
> hotplug-call: $1 = 'iface' START: 1139
> hotplug-call: $1 = 'net' START: 1141
> hotplug-call: script: /etc/hotp
i recognized that a "simple" 'ifup lan' can be
very expensive for a router with low ressources,
below a typcal call/execution trace:
hotplug-call: $1 = 'iface' START: 1139
hotplug-call: $1 = 'net' START: 1141
hotplug-call: script: /etc/hotplug.d/iface/00-netstate START: 1139
hotplug-call: script:
16 matches
Mail list logo
