Re: [OpenWrt-Devel] [PATCH v2] wireguard-tools: fix version indicator

2020-05-12 Thread Petr Štetiar
Paul Fertser [2020-05-11 17:43:56]: Hi, > On Mon, May 11, 2020 at 04:25:42PM +0200, Petr Štetiar wrote: > > > If we execute `wg --version` we get a diffrent version string that does > > > not match with the version string in the openwrt makefile. > > > > > > Current version string: > > > `wiregu

Re: [OpenWrt-Devel] [PATCH v2] wireguard-tools: fix version indicator

2020-05-12 Thread Florian Eckert
Hello Paul Thank you for your thoughts. ok, but I fail to see why this patch should be maintained by OpenWrt, this looks like it should be fixed upstream. Thanks. I think this is not possible every project does have his own rules. I only noticed this with wireguard so I will send the changes

Re: [OpenWrt-Devel] [PATCH v2] wireguard-tools: fix version indicator

2020-05-11 Thread Paul Fertser
On Mon, May 11, 2020 at 05:43:56PM +0300, Paul Fertser wrote: > Probably the right way to solve this would be to have means to > override the default git describe behaviour (and force specific > version string instead) by a configure (or similar) flag. Another (probably sick) idea: after cloning f

Re: [OpenWrt-Devel] [PATCH v2] wireguard-tools: fix version indicator

2020-05-11 Thread Paul Fertser
Hello, I'm not talking about this specific patch but rather about the general problem I'm aware of, in this specific case it might be not applicable. On Mon, May 11, 2020 at 04:25:42PM +0200, Petr Štetiar wrote: > > If we execute `wg --version` we get a diffrent version string that does > > not m

Re: [OpenWrt-Devel] [PATCH v2] wireguard-tools: fix version indicator

2020-05-11 Thread Petr Štetiar
Florian Eckert [2020-05-11 13:37:02]: Hi, > If we execute `wg --version` we get a diffrent version string that does > not match with the version string in the openwrt makefile. > > Current version string: > `wireguard-tools vreboot-13159-gac5caa2718 > -https://git.zx2c4.com/wireguard-tools/` >

[OpenWrt-Devel] [PATCH v2] wireguard-tools: fix version indicator

2020-05-11 Thread Florian Eckert
If we execute `wg --version` we get a diffrent version string that does not match with the version string in the openwrt makefile. Current version string: `wireguard-tools vreboot-13159-gac5caa2718 -https://git.zx2c4.com/wireguard-tools/` Corrected versions string: `wireguard-tools v1.0.20200319