Re: [OpenWrt-Devel] [PATCH 4/4] ppp: add new protocol PPPoSSH.

2014-04-23 Thread Felix Fietkau
On 2014-04-23 14:30, Jo-Philipp Wich wrote: > Hi. > > I think you should reuse option names used by other protocols, we > already have far too much variation and abbreviation styles for common > option names - see my comments inline below. > >> This patch adds protocol support for PPP over SSH.

Re: [OpenWrt-Devel] [PATCH 4/4] ppp: add new protocol PPPoSSH.

2014-04-23 Thread Yousong Zhou
On 23 April 2014 20:30, Jo-Philipp Wich wrote: > Hi. > > I think you should reuse option names used by other protocols, we > already have far too much variation and abbreviation styles for common > option names - see my comments inline below. Thank you, jow. You are right on this. :) > >> This

Re: [OpenWrt-Devel] [PATCH 4/4] ppp: add new protocol PPPoSSH.

2014-04-23 Thread Jo-Philipp Wich
Hi. I think you should reuse option names used by other protocols, we already have far too much variation and abbreviation styles for common option names - see my comments inline below. > This patch adds protocol support for PPP over SSH. The protocol name is > 'pppossh' with the following optio

[OpenWrt-Devel] [PATCH 4/4] ppp: add new protocol PPPoSSH.

2014-04-23 Thread Yousong Zhou
This patch adds protocol support for PPP over SSH. The protocol name is 'pppossh' with the following options. - sshserver, required, SSH server name - sshport, SSH server port - sshuser, required, SSH login username - identityfile, required, client private key file. - localip, local ip addre