On 2014-04-23 14:30, Jo-Philipp Wich wrote: > Hi. > > I think you should reuse option names used by other protocols, we > already have far too much variation and abbreviation styles for common > option names - see my comments inline below. > >> This patch adds protocol support for PPP over SSH. The protocol name is >> 'pppossh' with the following options. >> >> - sshserver, required, SSH server name > > Should be "server", as used by pptp already. > >> - sshport, SSH server port > > Should be just "port" to follow the naming style of the other opts. > >> - sshuser, required, SSH login username > > Should be "username" as used by pppoe, 6in4, dhcpv6, pptp, ... Be careful with "username", as it may be used by the generic ppp setup code.
- Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
