Re: [OpenWrt-Devel] [PATCH 2/2] Prevent more gzip timestamps

2015-07-14 Thread Florian Fainelli
On 14/07/15 15:05, Reiner Herrmann wrote: > On Sun, Jul 12, 2015 at 12:06:01PM -0700, Florian Fainelli wrote: >> 2015-07-12 9:41 GMT-07:00 Reiner Herrmann : >>> To improve reproducibility, prevent the inclusion of timestamps >>> in the gzip header. >> >> This looks fine to me, this also unveils a l

Re: [OpenWrt-Devel] [PATCH 2/2] Prevent more gzip timestamps

2015-07-14 Thread Reiner Herrmann
On Sun, Jul 12, 2015 at 12:06:01PM -0700, Florian Fainelli wrote: > 2015-07-12 9:41 GMT-07:00 Reiner Herrmann : > > To improve reproducibility, prevent the inclusion of timestamps > > in the gzip header. > > This looks fine to me, this also unveils a lot of repetition in how we > invoke gzip and i

Re: [OpenWrt-Devel] [PATCH 2/2] Prevent more gzip timestamps

2015-07-14 Thread John Crispin
On 12/07/2015 21:06, Florian Fainelli wrote: > 2015-07-12 9:41 GMT-07:00 Reiner Herrmann : >> To improve reproducibility, prevent the inclusion of timestamps >> in the gzip header. > > This looks fine to me, this also unveils a lot of repetition in how we > invoke gzip and its parameters, would

Re: [OpenWrt-Devel] [PATCH 2/2] Prevent more gzip timestamps

2015-07-12 Thread Florian Fainelli
2015-07-12 9:41 GMT-07:00 Reiner Herrmann : > To improve reproducibility, prevent the inclusion of timestamps > in the gzip header. This looks fine to me, this also unveils a lot of repetition in how we invoke gzip and its parameters, would you mind factoring this in a variable such that we contro

[OpenWrt-Devel] [PATCH 2/2] Prevent more gzip timestamps

2015-07-12 Thread Reiner Herrmann
To improve reproducibility, prevent the inclusion of timestamps in the gzip header. Signed-off-by: Reiner Herrmann --- docs/adding.tex| 2 +- include/image.mk | 2 +- package/Makefile | 2 +- target/image