On 14/07/15 15:05, Reiner Herrmann wrote: > On Sun, Jul 12, 2015 at 12:06:01PM -0700, Florian Fainelli wrote: >> 2015-07-12 9:41 GMT-07:00 Reiner Herrmann <rei...@reiner-h.de>: >>> To improve reproducibility, prevent the inclusion of timestamps >>> in the gzip header. >> >> This looks fine to me, this also unveils a lot of repetition in how we >> invoke gzip and its parameters, would you mind factoring this in a >> variable such that we control how gzip options are set globally? >> Eventually someone will want to be able to turn back on timestamps and >> original names in how gzip generates compressed files, and we might as >> well have a single location to fix this. > > The commands that are currently available in variables are named > just in uppercase (FIND, TAR, etc.). > But gzip also interprets the variable GZIP to parse additional > options, so naming the variable for the command also GZIP will > probably cause problems.
Ah good point. How about GZIP_CMD then? > Or would it be better to just globally export GZIP with the > default parameters (which would then differ from the currents > semantics of having the command inside the variable)? We could do that, I am just wondering if this would make it a bit more difficult to debug in case we forgot to patch a given Makefile or that we do reset the environment/do not inherit it. -- Florian _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
