Re: [OpenWrt-Devel] [PATCH-v6]samba 3.0.37 update

2011-11-29 Thread Jo-Philipp Wich
Hi. > Should we put the option back? Or should this option be placed somewhere > else? > In any case it seems required. Problem with hardcoding br-lan is that it must not always be a bridge (lan can be unbridged by default as well, for example on the Dockstar which ironically is a NAS appliance

Re: [OpenWrt-Devel] [PATCH-v6]samba 3.0.37 update

2011-11-28 Thread Maarten Bezemer
On Sunday 27 November 2011 19:31:42 Jo-Philipp Wich wrote: > Applied in r29343 and r29344 - thank you! > > ~ Jow In https://dev.openwrt.org/changeset/29347 you removed the 'interfaces' setting from smb.conf.template. Without this settings smbd won't startup without showing any kind of error. Wh

Re: [OpenWrt-Devel] [PATCH-v6]samba 3.0.37 update

2011-11-27 Thread Oliver Ertl
On 11/27/2011 10:52 PM, Maarten Bezemer wrote: > On Sunday 27 November 2011 19:31:42 Jo-Philipp Wich wrote: >> Applied in r29343 and r29344 - thank you! >> > Phew finally... It was quite some work, but thanks to all comments it came out > nice! Thanks for applying. > > If/when I feel like it, I'll

Re: [OpenWrt-Devel] [PATCH-v6]samba 3.0.37 update

2011-11-27 Thread Hauke Mehrtens
On 11/27/2011 10:52 PM, Maarten Bezemer wrote: > On Sunday 27 November 2011 19:31:42 Jo-Philipp Wich wrote: >> Applied in r29343 and r29344 - thank you! >> > Phew finally... It was quite some work, but thanks to all comments it came > out > nice! Thanks for applying. > > If/when I feel like it,

Re: [OpenWrt-Devel] [PATCH-v6]samba 3.0.37 update

2011-11-27 Thread Maarten Bezemer
On Sunday 27 November 2011 19:31:42 Jo-Philipp Wich wrote: > Applied in r29343 and r29344 - thank you! > Phew finally... It was quite some work, but thanks to all comments it came out nice! Thanks for applying. If/when I feel like it, I'll see whether it is possible to update to an even newer v

Re: [OpenWrt-Devel] [PATCH-v6]samba 3.0.37 update

2011-11-27 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Applied in r29343 and r29344 - thank you! ~ Jow -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7Sgg4ACgkQdputYINPTPNZSwCcC5a/F1dcVPq6tz0Zpws9YRcV TvUAn1u5

Re: [OpenWrt-Devel] [PATCH-v6]samba 3.0.37 update

2011-11-27 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, the patch looks very well. Testing it atm and will commit it if there are no issues. ~ Jow -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7SesoACgkQd