Re: [OpenWrt-Devel] [PATCH] upgrade: nand: fix board_name assumtions

2019-05-21 Thread Bjørn Mork
Petr Štetiar writes: > Jeff Kletsky [2019-05-20 20:42:16]: > >> Having spent quite a bit of time today thinking about the impact of >> board-name changes, I can see use cases where the running system doesn't >> know a priori what the range of acceptable tar-dir values are. > > Well it makes me w

Re: [OpenWrt-Devel] [PATCH] upgrade: nand: fix board_name assumtions

2019-05-21 Thread Petr Štetiar
Jeff Kletsky [2019-05-20 20:42:16]: > Having spent quite a bit of time today thinking about the impact of > board-name changes, I can see use cases where the running system doesn't > know a priori what the range of acceptable tar-dir values are. Well it makes me wonder, why you just don't do fol

Re: [OpenWrt-Devel] [PATCH] upgrade: nand: fix board_name assumtions

2019-05-20 Thread Jeff Kletsky
(imgtec.com addresses removed as mail to them bounces) On 5/20/19 6:42 AM, Jeff Kletsky wrote: On 5/20/19 3:14 AM, Bjørn Mork wrote: nand_do_platform_check assumes that the current board name is used as-is in the tar file sysupgrade directory. This fails for any image supporting multiple devi

Re: [OpenWrt-Devel] [PATCH] upgrade: nand: fix board_name assumtions

2019-05-20 Thread Jeff
On 5/20/19 6:42 AM, Jeff Kletsky wrote: cc-ing primary Imgtec / pistachio / Creator Ci40 contributors identified Note that all five imgtec.com email addresses found in the commit log bounce. The pistachio and the Ci40 do not seem to appear on the imgtec.com site, nor do related downloads at h

Re: [OpenWrt-Devel] [PATCH] upgrade: nand: fix board_name assumtions

2019-05-20 Thread Jeff Kletsky
cc-ing primary Imgtec / pistachio / Creator Ci40 contributors identified On 5/20/19 3:14 AM, Bjørn Mork wrote: nand_do_platform_check assumes that the current board name is used as-is in the tar file sysupgrade directory. This fails for any image supporting multiple device names, and it also f

[OpenWrt-Devel] [PATCH] upgrade: nand: fix board_name assumtions

2019-05-20 Thread Bjørn Mork
nand_do_platform_check assumes that the current board name is used as-is in the tar file sysupgrade directory. This fails for any image supporting multiple device names, and it also fails if the board_name contains a comma. Signed-off-by: Bjørn Mork --- This is a local workaround I'va had lying