Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

2019-02-25 Thread Bjørn Mork
Zefir Kurtisi writes: > But to clarify your point: it is possible to have kernel modules with > colliding > symbols. Just add two drivers which export 'foo()', both will be built and > installed, but loading the second will fail. At least this is my observation, > there are no mechanisms in plac

Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

2019-02-25 Thread Zefir Kurtisi
On 2/25/19 7:13 PM, Bjørn Mork wrote: > Zefir Kurtisi writes: > >> On 2/25/19 3:23 PM, Piotr Dymacz wrote: >>> Hello Zefir, >>> >>> On 25.02.2019 15:08, Zefir Kurtisi wrote: re-post, missed CC On 2/25/19 2:52 PM, Bjørn Mork wrote: > Zefir Kurtisi writes: > >> Some kern

Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

2019-02-25 Thread Zefir Kurtisi
On 2/25/19 6:18 PM, Piotr Dymacz wrote: > [snip] > > I'm more worried here about breaking existing {users, downstream projects, > etc.} > code and how the things have been working for years. > I believe, kernel modules were always (or at least since 2013~2014 when the > kmodloader was introduced)

Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

2019-02-25 Thread Bjørn Mork
Zefir Kurtisi writes: > On 2/25/19 3:23 PM, Piotr Dymacz wrote: >> Hello Zefir, >> >> On 25.02.2019 15:08, Zefir Kurtisi wrote: >>> re-post, missed CC >>> >>> On 2/25/19 2:52 PM, Bjørn Mork wrote: Zefir Kurtisi writes: > Some kernel modules have colliding symbol naming T

Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

2019-02-25 Thread Piotr Dymacz
Hello Zefir, On 25.02.2019 16:06, Zefir Kurtisi wrote: [snip] Hm, I gave an example in the commit message and if it helps, I can post the related log-output to prove my claim. But you might mean something else? But the 'qcawifi' is not part of the kernel and OpenWrt project. The QSDK [1] i

Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

2019-02-25 Thread Zefir Kurtisi
On 2/25/19 3:23 PM, Piotr Dymacz wrote: > Hello Zefir, > > On 25.02.2019 15:08, Zefir Kurtisi wrote: >> re-post, missed CC >> >> On 2/25/19 2:52 PM, Bjørn Mork wrote: >>> Zefir Kurtisi writes: >>> Some kernel modules have colliding symbol naming >>> >>> This is not true. >>> >>> >>> Bjørn >>

Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

2019-02-25 Thread Piotr Dymacz
Hello Zefir, On 25.02.2019 15:08, Zefir Kurtisi wrote: re-post, missed CC On 2/25/19 2:52 PM, Bjørn Mork wrote: Zefir Kurtisi writes: Some kernel modules have colliding symbol naming This is not true. Bjørn Hm, I gave an example in the commit message and if it helps, I can post the r

Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

2019-02-25 Thread Zefir Kurtisi
re-post, missed CC On 2/25/19 2:52 PM, Bjørn Mork wrote: > Zefir Kurtisi writes: > >> Some kernel modules have colliding symbol naming > > This is not true. > > > Bjørn > Hm, I gave an example in the commit message and if it helps, I can post the related log-output to prove my claim. But yo

Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

2019-02-25 Thread Bjørn Mork
Zefir Kurtisi writes: > Some kernel modules have colliding symbol naming This is not true. Bjørn ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

2019-02-25 Thread Zefir Kurtisi
Some kernel modules have colliding symbol naming and can't be loaded at the same time. This was observed e.g. with qcawifi and mac80211, where function names overlap. Therefore, the decision which kernel modules to use has to be made at build time, resulting in different FW variants. An alternativ