Hello Zefir,
On 25.02.2019 16:06, Zefir Kurtisi wrote:
[snip]
Hm, I gave an example in the commit message and if it helps, I can post the
related log-output to prove my claim. But you might mean something else?
But the 'qcawifi' is not part of the kernel and OpenWrt project.
The QSDK [1] is based on OpenWRT and is open source. During development of
ath10k
(and earlier ath9k), qca-wifi code has been ported to the other side (and maybe
vice-versa). That's why some exported kernel symbols in the drivers overlap.
The 'qca-wifi' driver is closed source.
If the argument to not consider the proposed change is based on politics (i.e.
'it
is for something not being part of OpenWRT core'), I'm fine dropping it and
keeping the change privately. But I'm pretty sure there are use cases where it
would be helpful to disable kernel-modules in the uci-default processing - as an
example of fully supported by OpenWRT, think of selecting mainline or
Candelatech's ath10k driver based on installed HW.
I'm more worried here about breaking existing {users, downstream
projects, etc.} code and how the things have been working for years.
I believe, kernel modules were always (or at least since 2013~2014 when
the kmodloader was introduced) loaded _before_ applying default UCI
configuration (please, correct me if I'm wrong here).
Based on above, your change should be considered as a major and a
potential reason for regressions and breaking a "well known" boot
sequence/order.
--
Cheers,
Piotr
Cheers,
Zefir
[1] https://www.codeaurora.org/project/qsdk
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
