[OpenWrt-Devel] [RESEND][PATCH] Fix uninitialised variable causing 1-wire to not bind to GPIO

2015-05-11 Thread Andrew McDonnell
--- package/kernel/w1-gpio-custom/src/w1-gpio-custom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/package/kernel/w1-gpio-custom/src/w1-gpio-custom.c b/package/kernel/w1-gpio-custom/src/w1-gpio-custom.c index fc2f842..2018f58 100644 --- a/package/kernel/w1-gpio-custom/src/w1-gpio-custom.c

[OpenWrt-Devel] [PATCH] kernel: fix uninitialised variable causing 1-wire to not bind to GPIO

2015-05-01 Thread Andrew McDonnell
This patch fixes a bug where 1-wire fails with an error instead of binding to the requested GPIO pin: "gpio_request_one (ext_pullup_enable_pin) failed" --- package/kernel/w1-gpio-custom/src/w1-gpio-custom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/package/kernel/w1-gpio-custom/src/w1-g

[OpenWrt-Devel] [PATCH] iwinfo: Fix incorrect buffer allocation in nl80211_get_ifcomb_cb()

2014-12-11 Thread Andrew McDonnell
This fixes a buffer overwrite, I found it when building with SSP enabled --- iwinfo_nl80211.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/iwinfo_nl80211.c b/iwinfo_nl80211.c index 2731b2b..be58c56 100644 --- a/iwinfo_nl80211.c +++ b/iwinfo_nl80211.c @@ -2446,15 +244

[OpenWrt-Devel] OpenWRT and grsecurity experiments and ponderings

2014-12-05 Thread Andrew McDonnell
Hi all noticing that CC may be coming at some point, and whilst recently taking the latest turunk for a spin, I noticed that the kernel 3.14.25 matched the current grsecurity patch (which is in long term support against 3.14) so I thought I'd see what it would take to apply it to OpenWRT. It

Re: [OpenWrt-Devel] Missing 'noexecstack' in uClibc MIPS builds

2014-10-03 Thread Andrew McDonnell
9:14, Catalin Patulea wrote: On Wed, Oct 1, 2014 at 6:42 PM, Andrew McDonnell wrote: It seems that OpenWRT sets the relevant flag to require uClibc to build with NOEXECSTACK set. This is good. (For one introduction to NOEXECSTACK, see http://wiki.gentoo.org/wiki/Hardened/GNU_stack_quickstart )

[OpenWrt-Devel] [PATCH][toolchain] Fix broken implementation of NOEXECSTACK flag for MIPS architectures for gcc-linaro-4.8

2014-10-03 Thread Andrew McDonnell
This patch ensures that libgcc_s.so properly honours the NOEXECSTACK flag for MIPS builds, when gcc-linaro-4.8 is the chosen C compiler. Signed-off-by: Andrew McDonnell --- Extended Summary: NOEXECSTACK is a security hardening feature of Linux that prevents execution of arbitrary code for some

[OpenWrt-Devel] [PATCH][BB, toolchain] Fix broken implementation of NOEXECSTACK flag for MIPS architectures for gcc-linaro-4.8

2014-10-03 Thread Andrew McDonnell
This patch ensures that libgcc_s.so properly honours the NOEXECSTACK flag for MIPS builds, when gcc-linaro-4.8 is the chosen C compiler. Signed-off-by: Andrew McDonnell --- Extended Summary: NOEXECSTACK is a security hardening feature of Linux that prevents execution of arbitrary code for some

[OpenWrt-Devel] Missing 'noexecstack' in uClibc MIPS builds

2014-10-01 Thread Andrew McDonnell
Hi, I have been taking a look at some of the OpenWRT security hardening and discovered something puzzling. It seems that OpenWRT sets the relevant flag to require uClibc to build with NOEXECSTACK set. This is good. (For one introduction to NOEXECSTACK, see http://wiki.gentoo.org/wiki/Harden

[OpenWrt-Devel] Is this a bug? Busybox package can ignore TARGET_LDFLAGS

2014-09-19 Thread Andrew McDonnell
I noticed whilst playing with some settings that busybox seems to not honour any settings in the global TARGET_LDFLAGS variable (file: package/utils/busybox) I tested this by checking the build log and noting that an additional linker flag I patched into rules.mak was being ignored. I was wond

[OpenWrt-Devel] [PATCH][toolchain] Fix missing help text in DEVEL config menu

2014-09-10 Thread Andrew McDonnell
This patch completes missing help text for some options under CONFIG_DEVEL. Provides help for BINARY_FOLDER and DOWNLOAD_FOLDER, and reduces ambiguity in the help for BUILD_SUFFIX with an example. Signed-off-by: Andrew McDonnell --- Patch resend; this time with tab characters fixed and a

[OpenWrt-Devel] [PATCH/RFC] build: fix missing help text in DEVEL config menu

2014-08-21 Thread Andrew McDonnell
This patch completes missing help text for some options under CONFIG_DEVEL. Provides help for BINARY_FOLDER and DOWNLOAD_FOLDER, and reduces ambiguity in the help for BUILD_SUFFIX with an example. Signed-off-by: Andrew McDonnell --- Warning: my email client also seems to be munging tabs into

[OpenWrt-Devel] Problem using 'dumpinfo' target

2014-08-16 Thread Andrew McDonnell
Hi, I seem to be hitting the bug described in detail here : https://dev.openwrt.org/ticket/14697 This is against Barrier Breaker latest git. Specifically, running any of the following : make DUMP=1 make DUMP=1 dumpinfo produces various error messages, because $(FIND_L) is never set to anyth

Re: [OpenWrt-Devel] [PATCH] ar71xx: Allow for activation of second mdio bus in ar7242 / ag71xx driver

2013-05-14 Thread Andrew McDonnell
DIR632 thanks again --Andrew On 14/05/13 23:03, Felix Fietkau wrote: > On 2013-05-14 3:22 PM, Andrew McDonnell wrote: >> Hi Felix >> >> at this stage I have had no luck getting eth1 to work so I have deliberately >> left out all the code attempting to make eth1 wor

Re: [OpenWrt-Devel] [PATCH] ar71xx: adds kernel target for the D-Link DIR-632-A1.

2013-05-14 Thread Andrew McDonnell
Hi Felix I can resubmit this without those, but I wont be able to test it for a couple of days and would prefer to wait until I have tested it, is that OK? thanks for the feedback --Andrew On 14/05/13 22:56, Felix Fietkau wrote: > On 2013-05-14 3:13 PM, Andrew McDonnell wrote: >>

Re: [OpenWrt-Devel] [PATCH] ar71xx: Allow for activation of second mdio bus in ar7242 / ag71xx driver

2013-05-14 Thread Andrew McDonnell
ing and instrumenting the working source code in DD-WRT. --Andrew On 14/05/13 22:39, Felix Fietkau wrote: > On 2013-05-14 2:30 PM, Andrew McDonnell wrote: >> >> This patch allows a board to enable the mdio bus on the second ethernet port >> provided by the AR7242 (as used in the D-L

Re: [OpenWrt-Devel] [PATCH] ar71xx: adds kernel target for the D-Link DIR-632-A1.

2013-05-14 Thread Andrew McDonnell
only ones directly copied as such --Andrew On 14/05/13 22:32, Felix Fietkau wrote: > On 2013-05-14 2:44 PM, Andrew McDonnell wrote: >> >> This patch adds a kernel target for the D-Link DIR-632-A1. >> >> Note that the CONFIG_MTD_CFI_I2 and BANK changes are duplicated from D

Re: [OpenWrt-Devel] [PATCH] ar71xx: Allow platform configurable tx/rx ring size in ag71xx

2013-05-14 Thread Andrew McDonnell
dont deeply understand some of the code, but I am following proven working software and testing by transferring multiple large files. --Andrew On 14/05/13 22:28, Felix Fietkau wrote: > On 2013-05-14 2:33 PM, Andrew McDonnell wrote: >> >> This patch allows the platform to config

[OpenWrt-Devel] [PATCH] ar71xx: Add platform machine support for the D-Link DIR-632-A1

2013-05-14 Thread Andrew McDonnell
all use cases that do not require a separate WAN port. Tested succesfully: LEDs, 2x switches, wireless, eth0, USB2. Signed-off-by: Andrew McDonnell --- .../ar71xx/files/arch/mips/ath79/mach-dir-632-a1.c | 391 1 files changed, 391 insertions(+), 0 deletions(-) diff --git a

[OpenWrt-Devel] [PATCH] ar71xx: adds kernel target for the D-Link DIR-632-A1.

2013-05-14 Thread Andrew McDonnell
This patch adds a kernel target for the D-Link DIR-632-A1. Note that the CONFIG_MTD_CFI_I2 and BANK changes are duplicated from DD-WRT and the D-Link firmware; I think it is because this uses a different flash chip (mx25l6405d) from many of the other similar devices. Signed-off-by: Andrew

[OpenWrt-Devel] [PATCH] ar71xx: add image build support for the D-Link DIR-632-A1

2013-05-14 Thread Andrew McDonnell
-off-by: Andrew McDonnell --- target/linux/ar71xx/image/Makefile | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/target/linux/ar71xx/image/Makefile b/target/linux/ar71xx/image/Makefile index c6b4dc4..73e256d 100644 --- a/target/linux/ar71xx/image/Makefile +++ b

[OpenWrt-Devel] [PATCH] ar71xx: Add board profile for the D-Link DIR-632-A1

2013-05-14 Thread Andrew McDonnell
This patch adds a board profile for the D-Link DIR-632-A1, specifically, ensures that USB support is built in by default. Signed-off-by: Andrew McDonnell --- target/linux/ar71xx/generic/profiles/d-link.mk | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a

[OpenWrt-Devel] [PATCH] ar71xx: Add user space support for the D-Link DIR-632-A1

2013-05-14 Thread Andrew McDonnell
This patch adds user space supoprt for the D-Link DIR-632-A1, specifically provides default LED behaviour and default bridge configuration and boot board platform check. Signed-off-by: Andrew McDonnell --- target/linux/ar71xx/base-files/etc/diag.sh |3 +++ .../ar71xx/base-files/etc

[OpenWrt-Devel] [PATCH] ar71xx: Allow platform configurable tx/rx ring size in ag71xx

2013-05-14 Thread Andrew McDonnell
defaults remain in place. This change allows the DIR-632-A1 to set the ring sizes to the same values as is done in the DD-WRT ag7240 driver. Signed-off-by: Andrew McDonnell --- .../mips/include/asm/mach-ath79/ag71xx_platform.h |3 +++ .../net/ethernet/atheros/ag71xx/ag71xx_main.c |6

[OpenWrt-Devel] [PATCH] ar71xx: Allow for activation of second mdio bus in ar7242 / ag71xx driver

2013-05-14 Thread Andrew McDonnell
connecting eth1 to ag71xx-mdio.1 when registering eth1 with ath79 platform data. Please note this superseded prior email with missing subject(!) Signed-off-by: Andrew McDonnell --- .../linux/ar71xx/files/arch/mips/ath79/dev-eth.c | 19 +-- 1 files changed, 13 insertions(+), 6

[OpenWrt-Devel] [PATCH] ar71xx:

2013-05-14 Thread Andrew McDonnell
connecting eth1 to ag71xx-mdio.1 when registering eth1 with ath79 platform data. Signed-off-by: Andrew McDonnell --- .../linux/ar71xx/files/arch/mips/ath79/dev-eth.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/target/linux/ar71xx/files/arch/mips

[OpenWrt-Devel] [PATCH] ar71xx: Add missing GPIO function bits for AR7242

2013-05-14 Thread Andrew McDonnell
bits are necessary to enable the test pin GPIOs although I havent had a chance to scientifically verify this. Signed-off-by: Andrew McDonnell --- .../902-MIPS-ath79-ar7274-gpio-functions.patch | 26 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/target

[OpenWrt-Devel] [PATCH] ar71xx: WARN instead of BUG when an invalid speed indicated via platform data of ag71xx

2013-05-14 Thread Andrew McDonnell
dir632a1) for which u-boot has broken TFTP and you dont have nearby a suitable browser/operating system combination for restoring the firmware via the factory recovery mechanism. Signed-off-by: Andrew McDonnell --- .../linux/ar71xx/files/arch/mips/ath79/dev-eth.c |4 +++- 1 files changed, 3

Re: [OpenWrt-Devel] [PATCH] ar71xx: Add AG7240+S26+8309 network driver to enable support of DIR-632-A1 (supersedes previous emails for this patch)

2013-05-14 Thread Andrew McDonnell
get the rest of the board into the trunk if at all possible. hope this helps, Andrew On 30/04/13 21:41, Jonas Gorski wrote: > On Tue, Apr 30, 2013 at 1:58 PM, Andrew McDonnell > wrote: >> >> This patch adds ethernet and switch support - ag7240 ethernet driver >> inco

Re: [OpenWrt-Devel] [PATCH] ar71xx: Add AG7240+S26+8309 network driver to enable support of DIR-632-A1 (supersedes previous emails for this patch)

2013-04-30 Thread Andrew McDonnell
since - but I wanted to get the board support out for others to test out. On 30/04/13 21:41, Jonas Gorski wrote: > On Tue, Apr 30, 2013 at 1:58 PM, Andrew McDonnell > wrote: >> >> This patch adds ethernet and switch support - ag7240 ethernet driver >> incorporating

[OpenWrt-Devel] [PATCH] ar71xx: Add support for DIR-632-A1 router (supersedes previous emails for this patch)

2013-04-30 Thread Andrew McDonnell
This patch adds board support for the D-link DIR-632-A1. Requires other patch adding AG7240+S26+8309 support for Ethernet; tested net, wlan, USB, buttons and LEDs Signed-off-by: Andrew McDonnell --- target/linux/ar71xx/base-files/etc/diag.sh |3 + .../ar71xx/base-files/etc/uci

[OpenWrt-Devel] [PATCH 1/2] [ar71xx] Support for DIR-632-A1 - board support

2013-04-25 Thread Andrew McDonnell
This patch adds board support for the D-link DIR 632 router (hardware version A1) based on trunk r36419. Signed-off-by: Andrew McDonnell --- This patch alone does not enable ethernet and switch support; patch 2/2 following adds support for the AG7242+RTL8309+S26 necessary to complete support

Re: [OpenWrt-Devel] [PATCH] [ar71xx] Add support for D-link DIR, 632 A1 router

2013-04-20 Thread Andrew McDonnell
In follow up, in further testing it seems the problem with the switch and the LEDS have resolved themselves - I have confirmed in my latest image that USB LED works, WLAN LED works, WAN LED works, and devices on the switch can ping each other. So only the minor issue of changing the colour of the

[OpenWrt-Devel] [PATCH] [ar71xx] Add support for D-link DIR 632 A1 router

2013-04-20 Thread Andrew McDonnell
This patch adds support for the D-link DIR 632 router (hardware version A1) Signed-off-by: Andrew McDonnell --- Notes: This patch is 420kb. Maybe I am doing something wrong :-| Given the entirety is to add support for a single device I am not sure how to logically split it - perhaps

[OpenWrt-Devel] Porting of D-link DIR-632-A1 router - patches coming soon

2013-04-20 Thread Andrew McDonnell
Hello all, After a few late nights I have managed to get this router working under OpenWRT. This is my first contribution to OpenWRT, so far I have posted to the DIR632 forum and added Debricking instructions to the related wiki page, now I am about to work my way through the OpenWrt patch submis