[OpenWrt-Devel] [PATCH] mvebu: split base-files across subtargets

2020-01-17 Thread Adrian Schmutzler
For the mvebu target in particular, there is a lot of files in base-files that are only relevant for one subtarget. Improve overview and reduce size per subtarget by moving/splitting base-files depending on the subtarget they belong to. While at it, consolidate 01_leds by using the model part of t

[OpenWrt-Devel] [PATCH 2/2] mvebu: use SOC to derive DEVICE_DTS

2020-01-17 Thread Adrian Schmutzler
This introduces the SOC variable to mvebu target to derive some of the DEVICE_DTS variables based on the SOC prefix and the device definition name. Since DTS names and compatible are inconsistent also in the kernel for this target, the scheme cannot be applied to all devices, though. While at it,

[OpenWrt-Devel] [PATCH 1/2] mvebu: move subtarget image Makefile switch to parent Makefile

2020-01-17 Thread Adrian Schmutzler
This moves the if conditions for choosing which image Makefiles are used to the parent image/Makefile. It seems more convenient to have "codeflow" in the parent while the subtarget-specific files only contain the definitions. Signed-off-by: Adrian Schmutzler --- target/linux/mvebu/image/Makefile

[OpenWrt-Devel] [PATCH] zynq: derive DEVICE_DTS from device definition name

2020-01-17 Thread Adrian Schmutzler
In zynq target, the DEVICE_DTS variable is always set consistent with the model part of the device definition name. This patch replaces the redundant definitions for the individual devices with a common recipe. Signed-off-by: Adrian Schmutzler --- target/linux/zynq/image/Makefile | 5 + 1 f

[OpenWrt-Devel] [PATCH] kirkwood: exploit BOARD_NAME to set DEVICE_DTS and SUPPORTED_DEVICES

2020-01-17 Thread Adrian Schmutzler
Due to the history of the target, all devices added before a certain point have the same device string in BOARD_NAME, DEVICE_DTS and added to SUPPORTED_DEVICES. Thus, we can set this one automatically for all devices where BOARD_NAME is specified, removing the explicit DEVICE_DTS and SUPPORTED_DEV

[OpenWrt-Devel] [PATCH] octeon: apply vendor_model scheme to device definition/image name

2020-01-17 Thread Adrian Schmutzler
This updates the device definition name for octeon target to provide more useful names for the images and be consistent with the increasing number of targets following that scheme. Since the target is not using device tree yet, this does not touch board_name and thus sets BOARD_NAME in image Makef

[OpenWrt-Devel] [PATCH] octeon: remove redundant network setup

2020-01-17 Thread Adrian Schmutzler
No need to have specific setup when default case does the same. Signed-off-by: Adrian Schmutzler --- target/linux/octeon/base-files/etc/board.d/01_network | 4 1 file changed, 4 deletions(-) diff --git a/target/linux/octeon/base-files/etc/board.d/01_network b/target/linux/octeon/base-file

[OpenWrt-Devel] [PATCHv2] base-files/functions.sh: use command -v instead of which

2020-01-17 Thread Rosen Penev
which must be executed. command -v is a shell builtin. https://github.com/koalaman/shellcheck/wiki/SC2230 Signed-off-by: Rosen Penev --- v2: enclose command -v in $(). package/base-files/files/lib/functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/base

[OpenWrt-Devel] [PATCHv2] base-files/functions.sh: use grep -q instead of []

2020-01-17 Thread Rosen Penev
It's cleaner and faster as it does not need to do extra work. Also removed $() to avoid executing the output. The shell can handle it. https://github.com/koalaman/shellcheck/wiki/SC2143 Signed-off-by: Rosen Penev --- v2: Fixed &&/|| typo. package/base-files/files/lib/functions.sh | 8

Re: [OpenWrt-Devel] OpenWrt 20.X release plans

2020-01-17 Thread David Bauer
Hello, On 1/17/20 11:14 AM, Andreas Ziegler wrote: > Hi, > > although i'm more a user than a developer, i would also prefer a sooner > release based on 4.19 over a later release based on 5.4. I have the same feeling. The state of many targets on 4.19 is pretty good IMHO. So i think a timely rele

[OpenWrt-Devel] build: Add KBUILD_HOSTLDLIBS

2020-01-17 Thread Hauke Mehrtens
In Linux kernel commit 8377bd2b9ee1 ("kbuild: Rename HOST_LOADLIBES to KBUILD_HOSTLDLIBS") HOST_LOADLIBES was renamed to KBUILD_HOSTLDLIBS. This patch adapts the OpenWrt kernel build to this new variable. Without this change the kernel host tools would not link against the libraries found in the st

[OpenWrt-Devel] [PATCH procd v4] instance: fix pidfile and seccomp attributes double free

2020-01-17 Thread Petr Štetiar
Commit a5af33ce9a16 ("instance: strdup string attributes") has introduced duplication of various string attributes in order to fix use-after-free, but missed handling of `pidfile` and `seccomp` attribute cases in instance_config_move() where the new value of `pidfile` or `seccomp` is being copied/a

Re: [OpenWrt-Devel] [PATCH v4] ath79: add support for TP-Link TL-MR6400

2020-01-17 Thread Adrian Schmutzler
Hi, > -Original Message- > From: Filip Moc [mailto:l...@moc6.cz] > Sent: Freitag, 17. Januar 2020 13:53 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org; Enrico Mioso > Subject: Re: [PATCH v4] ath79: add support for TP-Link TL-MR6400 > > Hi, > > thanks for patch. Good to s

Re: [OpenWrt-Devel] [PATCH v4] ath79: add support for TP-Link TL-MR6400

2020-01-17 Thread Filip Moc via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Hi, thanks for patch. Good to se

Re: [OpenWrt-Devel] OpenWrt 20.X release plans

2020-01-17 Thread Tom Psyborg
On 16/01/2020, Hauke Mehrtens wrote: > Hi, > > I meet with jow about 2 weeks ago and we talked about a lot of OpenWrt > related stuff, one of the topics was the release after 19.07. > > As the 19.07 release is now done, I would like to follow up on this topic. > > We thought that the time between

Re: [OpenWrt-Devel] [PATCH] ath79: add support for TP-Link TL-MR6400

2020-01-17 Thread Adrian Schmutzler
Hi, I've just sent an updated patch ("v4") to the list. Some comments below. > -Original Message- > From: Filip Moc [mailto:l...@moc6.cz] > Sent: Donnerstag, 16. Januar 2020 22:27 > To: Adrian Schmutzler > Cc: 'Enrico Mioso' ; openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Deve

[OpenWrt-Devel] [PATCH v4] ath79: add support for TP-Link TL-MR6400

2020-01-17 Thread Adrian Schmutzler
From: Enrico Mioso This device is an LTE router supported in ar71xx so far. As per original commit, hardware specifications (v1.0 EU): - SoC: QCA9531 - Flash: Winbond W25Q64FV (8MiB) - RAM: EtronTech EM6AB160TSE-5G (64MiB) - Wireless: SoC platform only (2.4GHz b/g/n, 2x internal antenna) - Ethern

Re: [OpenWrt-Devel] [PATCH 2/7] base-files/functions.sh: use grep -q instead of []

2020-01-17 Thread Adrian Schmutzler
Hi, > - [ -z "$(echo $grp | cut -d: -f4 | grep $2)" ] || return > - [ -n "$(echo $grp | grep ":$")" ] && delim="" > + echo "$grp" | cut -d: -f4 | grep -q $2 || return > + echo "$grp" | grep -q ":$" || delim="" logic (&& ||) seems to be inverted here. Just send the fixed one as st

Re: [OpenWrt-Devel] OpenWrt 20.X release plans

2020-01-17 Thread Andreas Ziegler
Hi, although i'm more a user than a developer, i would also prefer a sooner release based on 4.19 over a later release based on 5.4. Maybe it's the same problem, too atheros-centric ;-) Regards Andreas Michal Cieslakiewicz wrote on 16.01.20 19:43: > Hi! > > Speaking as a small part-time contri

Re: [OpenWrt-Devel] [PATCH 3/7] base-files/functions.sh: use command -v instead of $(which)

2020-01-17 Thread Felix Fietkau
On 2020-01-17 05:43, Rosen Penev wrote: > $(which) must be executed. command -v is a shell builtin. > > https://github.com/koalaman/shellcheck/wiki/SC2230 > > Signed-off-by: Rosen Penev > --- > package/base-files/files/lib/functions.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)