Re: [OpenWrt-Devel] Any interest in a 'ct' iperf3?

2019-10-28 Thread Petr Štetiar
Ben Greear [2019-10-28 14:42:32]: Hi Ben, > found and fixed a bunch of issues apart from lack of time, do you've any other good reason to not upstream those changes? :-) > and of course possibly added some new bugs. As always, those could be probably spotted by another pair of eyes during ups

Re: [OpenWrt-Devel] Network broken with kernels 5.2+

2019-10-28 Thread Mathias Kresin
28/10/2019 23:01, Rafał Miłecki: Using OpenWrt with kernels 5.2+ results in broken network. Interfaces seem OK but I cannot ping my router anymore. This regression is caused by the upstream commit commit b424e432e770d6dd572765459d5b6a96a19c5286 (refs/bisect/bad) Author: Michal Kubecek Date:

[OpenWrt-Devel] v5.4 as next kernel

2019-10-28 Thread John Crispin
Hi, should we use v5.4 as our next kernel ? John ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] rpcd: uci: fix segfault and double free on set method

2019-10-28 Thread Yousong Zhou
Hi Daniel, On Mon, 28 Oct 2019 at 18:32, Daniel Danzberger wrote: > > Invalid reuse of pointers from uci_ptr can cause the rcpd to segfault on > already freed memory. > This bug could be trigged by calling 'set' with emtpy values on multiple non > existing or already cleard options. > > For exa

Re: [OpenWrt-Devel] Network broken with kernels 5.2+

2019-10-28 Thread Hauke Mehrtens
On 10/28/19 11:01 PM, Rafał Miłecki wrote: > Using OpenWrt with kernels 5.2+ results in broken network. Interfaces > seem OK but I cannot ping my router anymore. > > This regression is caused by the upstream commit > > commit b424e432e770d6dd572765459d5b6a96a19c5286 (refs/bisect/bad) > Author: Mi

Re: [OpenWrt-Devel] [PATCH, v2] procd sysupgrade: close input side of pipe before reading

2019-10-28 Thread Rafał Miłecki
On Mon, 28 Oct 2019 at 17:52, Dustin Lundquist wrote: > > On Oct 27, 2019, at 6:44 AM, Rafał Miłecki wrote: > > > > You also need to drop close(fds[1]); that is placed inside the "if > > (!tok)" block. > > > When /usr/libexec/validate_firmware_image is not present on the system > procd will hang

[OpenWrt-Devel] Network broken with kernels 5.2+

2019-10-28 Thread Rafał Miłecki
Using OpenWrt with kernels 5.2+ results in broken network. Interfaces seem OK but I cannot ping my router anymore. This regression is caused by the upstream commit commit b424e432e770d6dd572765459d5b6a96a19c5286 (refs/bisect/bad) Author: Michal Kubecek Date: Thu May 2 16:15:10 2019 +0200

[OpenWrt-Devel] Any interest in a 'ct' iperf3?

2019-10-28 Thread Ben Greear
We added iperf3 support to our network testing tool, so we could more easily use generic third-party systems as remote traffic endpoints. While doing this, I ended up getting iperf3 to compile for and run stable on windows, found and fixed a bunch of issues, and of course possibly added some new

Re: [OpenWrt-Devel] [PATCH] ath79: add support for ZyXEL NWA1123-NI

2019-10-28 Thread 'Patrick Supper'
Hello, ### Regarding the cal-data of the pcie-wifi (AR9382): It seems to me it has some kind of EEPROM, from OEM-BootLog: wmac-wifi: "Using Cal data from Flash 0xbfff" Note that you are currently using art 0x1000, so 0xff1000 inside flash?! ART-Partition starts at 0xff in flash. Cal

Re: [OpenWrt-Devel] [PATCH, v2] procd sysupgrade: close input side of pipe before reading

2019-10-28 Thread Dustin Lundquist
> On Oct 27, 2019, at 6:44 AM, Rafał Miłecki wrote: > > You also need to drop close(fds[1]); that is placed inside the "if > (!tok)" block. When /usr/libexec/validate_firmware_image is not present on the system procd will hang indefinitely on the read() since the input side of the pipe is sti

Re: [OpenWrt-Devel] [PATCH] octeontx: fix thunderx BGX underflow irq name

2019-10-28 Thread Tim Harvey
On Sun, Oct 27, 2019 at 6:33 AM Hauke Mehrtens wrote: > > On 10/25/19 11:27 PM, Tim Harvey wrote: > > request_irq requires irq names to be static/allocated and not on the stack > > It would be nice if this patch could also go to the mainline Linux > kernel, so we do not have to maintain it any mor

Re: [OpenWrt-Devel] [PATCH] hotplug: Allow renaming wireless phy devices.

2019-10-28 Thread Ben Greear
On 10/27/19 6:35 AM, John Crispin wrote: On 17/12/2018 17:48, gree...@candelatech.com wrote: From: Ben Greear uci set wireless.@wifi-device[0].phyname=wiphy0 Then reboot and/or re-plug that device, and this will name the phy wiphy0 instead of phy0, phy1, etc. This can help keep phy names con

Re: [OpenWrt-Devel] improved handling of contributions [Was: Re: patches from 2018]

2019-10-28 Thread Bjørn Mork
Petr Štetiar writes: >> 2. Those where there never was any feedback >> However, I do not think it's fair to just close an old submission without >> any developer (or others people's) feedback (category 2), just because >> nobody is interested in it. > > And whats the point to keep them lingering

Re: [OpenWrt-Devel] [PATCH] ath79: add support for ZyXEL NWA1123-NI

2019-10-28 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of 'Patrick Supper' > Sent: Freitag, 25. Oktober 2019 21:50 > To: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: add support for ZyXEL NWA1123-NI > >

[OpenWrt-Devel] improved handling of contributions [Was: Re: patches from 2018]

2019-10-28 Thread Petr Štetiar
Adrian Schmutzler [2019-10-28 13:17:34]: Hi, > 1. Those where the submitter left track after (initial) feedback > I would even choose a relatively short time span for that (e.g. one month). so this probably means PRs with `needs changes` tag and defined inactivity, right? > 2. Those where ther

Re: [OpenWrt-Devel] patches from 2018

2019-10-28 Thread Adrian Schmutzler
> I don't see how that would help, since the commiter's responsibility > is to review the code and make sure it doesn't break the build. And > having the patch itself is already a pointer there is an interest in > certain feature/fix/whatever. Also, at least once during the past > year, you were ni

Re: [OpenWrt-Devel] patches from 2018

2019-10-28 Thread Tom Psyborg
On 28/10/2019, Petr Štetiar wrote: > John Crispin [2019-10-27 14:34:04]: > > Hi, > >> I'd like to close all patches pending from 2018 in patchwork, there are >> ~25 >> and a quick try on some showed none of the apply anymore. > > thank you for cleaning up the backlog, really appreciate the effort

Re: [OpenWrt-Devel] patches from 2018

2019-10-28 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Petr Štetiar > Sent: Montag, 28. Oktober 2019 12:58 > To: John Crispin ; Tom Psyborg > Cc: OpenWrt Development List > Subject: Re: [OpenWrt-Devel] patches from 2018 > > John C

Re: [OpenWrt-Devel] patches from 2018

2019-10-28 Thread Petr Štetiar
John Crispin [2019-10-27 14:34:04]: Hi, > I'd like to close all patches pending from 2018 in patchwork, there are ~25 > and a quick try on some showed none of the apply anymore. thank you for cleaning up the backlog, really appreciate the effort. You're just mentioning Patchwork(PW), but I thi

Re: [OpenWrt-Devel] [PATCH 1/2] ath79: Remove legacy GL.iNet GL-AR300M NAND target

2019-10-28 Thread Adrian Schmutzler
Hi, after the recent changes (base-files split, new nand devices), I don't see a benefit anymore in removing ar300m-nand first and then adding it again. I'd vote for removing this patch and doing the small remainder of it in "ath79: GL-AR300M: Provide NAND support", as this will be clearer _now

[OpenWrt-Devel] [PATCH] rpcd: uci: fix segfault and double free on set method

2019-10-28 Thread Daniel Danzberger
Invalid reuse of pointers from uci_ptr can cause the rcpd to segfault on already freed memory. This bug could be trigged by calling 'set' with emtpy values on multiple non existing or already cleard options. For example: ubus call uci set '{"config":"network","section":"wan","values":{"proto":

Re: [OpenWrt-Devel] [PATCH 0/6] buildsystem: Activate PIE ASLR for some packages

2019-10-28 Thread Daniel Engberg
On 2019-10-27 18:44, Hauke Mehrtens wrote: This is a follow up patch on this discussion on the mailing list: https://patchwork.ozlabs.org/patch/1041647/ This allows to activate PIE only for some packages where we thing it is necessary and not only globally for all of them. Hauke Mehrtens (6):