Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

2015-12-24 Thread John Crispin
On 24/12/2015 17:55, Tathagata Das wrote: > > > > > Thank you for help John. > > I have followed those step and send the patch again. Please check. > well, we never received that mail i am afraid. John > On 24-12-2015 21:24, John Crispin wrote: > >> hi >> >> first format the p

[OpenWrt-Devel] [PATCH 3/3] ath10k: bypass otp check at initialization (needed for TP-Link Archer C2600)

2015-12-24 Thread Josh Bendavid
There is a patch added here to ath10k to bypass some checks on startup. I believe this is related to the calibration data being provided in external files (dumped from the ART mtd partition at init time) rather than directly from the pcie board. The patch and related discussion is from here:

[OpenWrt-Devel] [PATCH 2/3] ipq806x: add device tree for TP-Link Archer C2600

2015-12-24 Thread Josh Bendavid
The device tree file is similar to the current ap148 dts, with sata and nand removed, and buttons/led's added. Signed-off-by: Josh Bendavid --- ...qcom-add-TP-Link-Archer-C2600-device-tree.patch | 300 + ...qcom-add-TP-Link-Archer-C2600-device-tree.patch | 300 +++

[OpenWrt-Devel] [PATCH 1/3] ipq806x: add support for TP-Link Archer C2600 image building and ath10k initialization

2015-12-24 Thread Josh Bendavid
Add initial support for Archer C2600 to Makefiles, profiles, led/network config, and hotplug script, along with needed modifications to tplink-safeloader in firmware-tools. This is sufficient to build a working factory image flashable both from stock web ui and bootloader tftp recovery. Sysup

[OpenWrt-Devel] [PATCH] config: Add option to make crypto default when there is an config option for it

2015-12-24 Thread openwrt
From: Daniel Dickinson This package is primarily for the packages and other feeds as base already builds both encrypted/ssl versions and non-encrypted/ssl versions of packages where there is the options and/or already uses encryption where it is an option. In the feeds there are number of packag

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Daniel Dickinson
Security is ultimately all about making it cost too much (of at least time, money, effort, requirements, social factors) to break in. Even so-called 'real' security vs. security in depth and security by obscurity is really on the same spectrum. That is why those who make bald statements about

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Sami Olmari
-1 to default key... > at the moment the user *is* used to a key mismatch, because > every box comes up with 192.168.1.1 and another key. No need to generate another weak point just because there can be another similar one... More general, should a bad guy have physical access to an device, be i

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Bastian Bittorf
* Michael Richardson [24.12.2015 22:14]: > 2) if the user is "used" to a key mismatch, and they type their password in, >the password has just been compromised. this is indeed true for IPv6/linklocal > A better approach is that the ssh daemon should start, open port 22, and then > do SSHv2 t

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Bastian Bittorf
* Michael Richardson [24.12.2015 22:14]: > >> > till the real keys are generated? it can last several minutes on some > >> > routers and it feels like the box is broken. also: if really > something > >> > goes wrong during key generating we can at least login. > >> > >> you ha

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Bastian Bittorf
* Michael Richardson [24.12.2015 22:14]: > 1) when the "default" key is being used, the box can be impersonated. hmmm, it can - but you need another box on the same wire with the same IP 192.168.1.1 > 2) if the user is "used" to a key mismatch, and they type their password in, >the password

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Michael Richardson
Bastian Bittorf wrote: >> > while we are at it: what about including default private keys for SSH >> > till the real keys are generated? it can last several minutes on some >> > routers and it feels like the box is broken. also: if really something >> > goes wrong during key gener

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Michael Richardson
Bastian Bittorf wrote: >> >while we are at it: what about including default private keys for SSH >> >till the real keys are generated? it can last several minutes on some >> >routers and it feels like the box is broken. also: if really something >> >goes wrong during key generatin

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Bastian Bittorf
* John Crispin [24.12.2015 21:15]: > > while we are at it: what about including default private keys for SSH > > till the real keys are generated? it can last several minutes on some > > routers and it feels like the box is broken. also: if really something > > goes wrong during key generating we

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Michael Richardson
Daniel Dickinson wrote: > At the present time it is actually not possible to using /bin/login from > within the preinit context and therefore making passwords required during > failsafe is not currently possible. It sounds like we really need /bin/singleuserlogin. Could we use a pass

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Bastian Bittorf
* Imre Kaloz [24.12.2015 21:15]: > >while we are at it: what about including default private keys for SSH > >till the real keys are generated? it can last several minutes on some > >routers and it feels like the box is broken. also: if really something > >goes wrong during key generating we can at

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

2015-12-24 Thread Tathagata Das
Thank you for help John. I have followed those step and send the patch again. Please check. On 24-12-2015 21:24, John Crispin wrote: > hi > > first format the patch > > git format-patch HEAD~1 > > this will give you your patch as 0001-$some_name.patch > > then call this command to send

[OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2P, fix led support for WRTnode platform

2015-12-24 Thread xzmu
Signed-off-by: xzmu --- .../linux/ramips/base-files/etc/board.d/02_network | 2 + target/linux/ramips/base-files/etc/diag.sh | 5 ++ target/linux/ramips/base-files/lib/ramips.sh | 6 ++ .../ramips/base-files/lib/upgrade/platform.sh | 2 + target/linux/ramips/dts/WRTNODE2.dt

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

2015-12-24 Thread John Crispin
hi first format the patch git format-patch HEAD~1 this will give you your patch as 0001-$some_name.patch then call this command to send the patch git send-email --to openwrt-devel@lists.openwrt.org 0001-my_fix.patch John On 24/12/2015 14:31, Tathagata Das wrote: > > > > > I hav

Re: [OpenWrt-Devel] [PATCH] V2 ar71xx : Add Support for the Bitmain Antrouter R1

2015-12-24 Thread L. D. Pinney
​Sorry the diff stat doesn't seem to match maybe I used 'diff --stat' rather than '​diff origin/master --stat' target/linux/ar71xx/base-files/etc/board.d/01_leds| 5 target/linux/ar71xx/base-files/etc/board.d/02_network | 1 + target/linux/ar71xx/base-files/etc/diag.sh

Re: [OpenWrt-Devel] [PATCH] V2 ar71xx : Add Support for the Bitmain Antrouter R1

2015-12-24 Thread Yousong Zhou
Hi, On 24 December 2015 at 09:32, L. D. Pinney wrote: > This patch adds support for the Bitmain Antrouter R1 > > http://wiki.openwrt.org/toh/bitmain/r1 > > Signed-off-by: L. D. Pinney > --- > > V2 Corrects naming errors in Profile in V1 > > target/linux/ar71xx/base-files/etc/board.d/01_leds

Re: [OpenWrt-Devel] [PATCH] use NTP server received via DHCP

2015-12-24 Thread Yousong Zhou
Hi, amine On 23 December 2015 at 00:00, amine ahd wrote: > The current state of NTP is to load the list of NTP servers > from the static file /etc/config/system. > This patch allows ntpd to get NTP servers from DHCP. > ntpd will restart whenever the list of NTP servers is changed. > > Signed-off-

Re: [OpenWrt-Devel] [PATCH v2 12/12] lantiq: use devicename:colour:function led naming scheme

2015-12-24 Thread John Crispin
On 24/12/2015 13:28, Mathias Kresin wrote: > The leds of the following boards are not renamed due to lack of > manuals/informations: > > - ARV7519PW > - ARV7510PW22 > - ARV4510PW i have these here so i'll take care of those boards > > The leds of the ARV4518PWR01* boards are unchanged, since

Re: [OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R add led support for wrtnode platform

2015-12-24 Thread John Crispin
On 24/12/2015 10:16, Piotr Dymacz wrote: > Hello, > > Small comment inline, below. > > Plus: > 1. This patch is not for trunk, so you should add "CC" prefix in the subject. small addition. for us to merge board support into CC it needs to first be merged into trunk. i cannot accept a patch for

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

2015-12-24 Thread John Crispin
Hi, your mail client replaced all tabs with spaces. please consider using git to send patches. it will save you a lot of time. John On 24/12/2015 11:21, Tathagata Das wrote: > Add support for the Netgear D7800 and build appropriate sysupgrade and > factory images. > > Known issues: > .

[OpenWrt-Devel] [PATCH] ledtrig-netdev: add support for renamed devices

2015-12-24 Thread Mathias Kresin
The ppp0 interface is renamed after the connection is established. Due to a missing NETDEV_REGISTER event, the ledtrig-netdev isn't aware of the renamed interface and literally ignores the device (no tx/rx indication, led isn't switched off with 'ifdown wan'). Signed-off-by: Mathias Kresin ---

[OpenWrt-Devel] [PATCH v2 12/12] lantiq: use devicename:colour:function led naming scheme

2015-12-24 Thread Mathias Kresin
The leds of the following boards are not renamed due to lack of manuals/informations: - ARV7519PW - ARV7510PW22 - ARV4510PW The leds of the ARV4518PWR01* boards are unchanged, since the leds doesn't match the leds from the manual or pictures (e.g. there shouldn't be a wps led). Signed-off-by: Ma

[OpenWrt-Devel] [PATCH v2 11/12] lantiq: add support for indicating the boot state using three leds

2015-12-24 Thread Mathias Kresin
The BTHOMEHUBV5A has a RGB power led, where every colour is perfect to indicate the current boot state. This patch adds support for such cases. The existing led sequences should be the same as before. Boards which are using a led different from power (like TDW89x0) are changed to switch of the le

[OpenWrt-Devel] [PATCH v2 06/12] lantiq: ARV752DPW - fix dts file

2015-12-24 Thread Mathias Kresin
Use the same led logic and labels as the OEM firmware (red = okay, blue = failure). Add the red internet led. Remove missing usb led workaround. The workaround shouldn't be in the default configuration. Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/ARV752DPW.dts | 22 +-

[OpenWrt-Devel] [PATCH v2 07/12] lantiq: define default leds in dts files

2015-12-24 Thread Mathias Kresin
- ARV7525PW: use the power led as dsl led as done by the stock firmware - FRITZ3370: use the info led as internet led - FRITZ7320: use the power led as dsl led as done by the stock firmware Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/ARV4510PW.dts | 24 +---

[OpenWrt-Devel] [PATCH v2 10/12] lantiq: use dsl led defined in DTS

2015-12-24 Thread Mathias Kresin
dsl_control (dsl_notify.sh) is the only process which is aware of the state of the atm/ptm interface. Use the dsl led exclusive for the dsl line state. On boards which don't have a distinct internet and a dsl led, let the netdev status of the atm interface trigger the shared led. Triggering the s

[OpenWrt-Devel] [PATCH v2 08/12] lantiq: use default leds defined in DTS

2015-12-24 Thread Mathias Kresin
Remove all now double defined leds from the led board file. Use pppoe as default for all broadband connections, since it's the default in OpenWrt now. Rename the the wifi leds to make sure, the not applicable default values get overwritten. Signed-off-by: Mathias Kresin --- target/linux/lantiq/

[OpenWrt-Devel] [PATCH v2 09/12] lantiq: use power leds defined in DTS

2015-12-24 Thread Mathias Kresin
Use the power leds defined in the dts file instead of hardcoded led names. Signed-off-by: Mathias Kresin --- target/linux/lantiq/base-files/etc/diag.sh | 34 +- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/target/linux/lantiq/base-files/etc/diag.sh

[OpenWrt-Devel] [PATCH v2 05/12] lantiq: ARV752DPW22 - fix dts file

2015-12-24 Thread Mathias Kresin
No need to switch (and keep) on all leds at boot. Use the same led logic and labels as the OEM firmware (red = okay, blue = failure). Add the red internet led. Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/ARV752DPW22.dts | 34 - 1 file changed, 12 in

[OpenWrt-Devel] [PATCH v2 00/12] lantiq: switch to devicename:colour:function naming scheme

2015-12-24 Thread Mathias Kresin
I chose to use Device Tree Source files to define some common used leds. This way it's possible to prevent the bloating (as it can be seen on other tragets) of the led board.d file as well as the diag.sh file. No need to carry dozen of - unrelated - board specific led definitions with each board.

[OpenWrt-Devel] [PATCH v2 02/12] lantiq: BTHOMEHUBV2B - remove missing usb led workaround

2015-12-24 Thread Mathias Kresin
The workaround shouldn't be in the default configuration. Signed-off-by: Mathias Kresin --- target/linux/lantiq/base-files/etc/board.d/01_leds | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/lantiq/base-files/etc/board.d/01_leds b/target/linux/lantiq/base-files/etc/board.d/01_le

[OpenWrt-Devel] [PATCH v2 04/12] lantiq: DGN1000B - fix typo in dts file

2015-12-24 Thread Mathias Kresin
Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/DGN1000B.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/lantiq/dts/DGN1000B.dts b/target/linux/lantiq/dts/DGN1000B.dts index 4ccab93..199d3a9 100644 --- a/target/linux/lantiq/dts/DGN1000B.dts +++ b/ta

[OpenWrt-Devel] [PATCH v2 03/12] lantiq: ARV4518PWR01* move redundant parts to dtsi

2015-12-24 Thread Mathias Kresin
Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/ARV4518PWR01.dts | 179 + target/linux/lantiq/dts/ARV4518PWR01.dtsi | 184 ++ target/linux/lantiq/dts/ARV4518PWR01A.dts | 179 + 3 files changed, 186 inse

[OpenWrt-Devel] [PATCH v2 01/12] lantiq: P2812HNUFX - move leds to dtsi

2015-12-24 Thread Mathias Kresin
Beside the used labels, they are the same on both boards. Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/P2812HNUF1.dts | 61 - target/linux/lantiq/dts/P2812HNUF3.dts | 53 target/linux/lantiq/dts/P2812HNUFX.dtsi | 61

[OpenWrt-Devel] [PATCH] base-files: Allow to disable failsafe mode

2015-12-24 Thread openwrt
From: Daniel Dickinson Failsafe mode while convenient for development and experimentation can reasonbly considered a major security loophole (by giving an easy way to gain passwordless root access to the device), therefore we add the ability to build images with failsafe mode disable, either thro

[OpenWrt-Devel] pre-Xmas security patch #2

2015-12-24 Thread openwrt
The following patch allows the a user to disable failsafe mode either via a menuconfig option or by passing NOFAILSAFE=1 on the command line. This allows production use of openwrt to avoid a major security loophole that allows easy access to passwordless root access given physical access to the de

[OpenWrt-Devel] [PATCH] dnsmasq: fix warning with poll.h include on musl

2015-12-24 Thread Kevin Darbyshire-Bryant
Warning is: #warning redirecting incorrect #include to Signed-off-by: Kevin Darbyshire-Bryant --- .../230-fix-poll-h-include-warning-on-musl.patch | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 package/network/services/dnsmasq/patches/230-fix-poll-h-incl

[OpenWrt-Devel] [PATCH] base-files image: Require login even on console

2015-12-24 Thread openwrt
From: Daniel Dickinson Passwordless root login is undesirable by default on any platform, therefore make requiring a login to gain root (or any other user) even on hardware console the default. This is an opt-out option that can by disabled at image generation time by passing the variable PASSWO

[OpenWrt-Devel] V2: pre-Xmas bonus security patch

2015-12-24 Thread openwrt
Hi all, I have corrected this issue with failsafe mounting root (it was due to inadvertently removing the lock that prevents preinit from running to completion so that it stays in failsafe mode). It turns out that it is not going to be possible to make failsafe require passwords at this time. Th

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread Daniel Dickinson
Hi Imre, On 23/12/15 07:05 AM, Imre Kaloz wrote: Hi Daniel, On Wed, 23 Dec 2015 07:58:59 +0100, Daniel Dickinson wrote: I am reworking this (requiring console login) as couple of packages for the packages feed, although it may require an image.mk or packages Makefile hook in order to embed a

[OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

2015-12-24 Thread Tathagata Das
Add support for the Netgear D7800 and build appropriate sysupgrade and factory images. Known issues: . USB ports are not working . DSL is not added Signed-off-by: Tathagata Das From 41487fc5f03abbd24c1a979c1c0e59a5f7da2898 Mon Sep 17 00:00:00 2001 From: Tathagata Das Date: Thu, 24 De

Re: [OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R add led support for wrtnode platform

2015-12-24 Thread Piotr Dymacz
Hello, Small comment inline, below. Plus: 1. This patch is not for trunk, so you should add "CC" prefix in the subject. 2. Both models are very similar, my suggestion is to use common dtsi (ex. Lenovo Y1). Cheers, Piotr 2015-12-24 9:56 GMT+01:00 xzmu : > Signed-off-by: xzmu > --- > .../linux/

[OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R add led support for wrtnode platform

2015-12-24 Thread xzmu
Signed-off-by: xzmu --- .../linux/ramips/base-files/etc/board.d/02_network | 2 + target/linux/ramips/base-files/etc/diag.sh | 5 + target/linux/ramips/base-files/lib/ramips.sh | 6 ++ .../ramips/base-files/lib/upgrade/platform.sh | 2 + target/linux/ramips/dts/WRTNODE2

Re: [OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R

2015-12-24 Thread John Crispin
Hi, the patch is badly formatted. please read the SubmittingPatches howto. things to look out for are * subject prefix * description that reflects hte actual patch content * your signed-off line is at the end of the patch. please put it above the tear line instead. you should consider using "git

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

2015-12-24 Thread John Crispin
On 23/12/2015 17:32, Bastian Bittorf wrote: > * Daniel Curran-Dickinson [23.12.2015 17:27]: >> I'm implementing without mount_root - that means passwordless >> failsafe unless user has preconfigured passwords in their image. >> OTOH if they have configured passwords in their image then they will