Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email )
Change subject: dco: only pass struct context to init function
Rarely I have seen a single ("simple!") patch cause *so* much build break
e-mails... :-o - but anyway, v4 is good now, and passes compile on all
platforms. It also passes actual client/server testing with DCO on
Linux, and my critical stare-at-code test...
Your patch has been applied to the mast
cron2 has uploaded a new patch set (#5) to the change originally created by
ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dco: only pass struct context to init function
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email )
Change subject: dco: only pass struct context to init function
..
dco: only pass struct context to init function
Future DCO code will req
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1101?usp=email
to review the following change.
Change subject: ssl_openssl: Fix type of sslopts argument to SSL_CTX_set_options
..
Attention is currently required from: cron2, flichtenheld, mrbff, plaisthos,
stipa.
Hello cron2, flichtenheld, plaisthos, stipa,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/809?usp=email
to look at the new patch set (#22).
The following approvals
Attention is currently required from: cron2, flichtenheld, mrbff, stipa.
Hello cron2, flichtenheld, plaisthos, stipa,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/808?usp=email
to look at the new patch set (#21).
The following approvals got outdate
Attention is currently required from: cron2, flichtenheld, mrbff, plaisthos,
stipa.
Hello cron2, flichtenheld, plaisthos, stipa,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/810?usp=email
to look at the new patch set (#22).
The following approvals
Attention is currently required from: cron2, flichtenheld, stipa.
mrbff has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/808?usp=email )
Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle
PUSH UPDATE control messages to allow options updat
Meeting summary for 23 July 2025:
*
*Updated: Release 2.7*
We planned for an alpha3 this week but decided to postpone because
for DCO and push_update we have some fixes coming in.
Float with DCO on Linux and Windows is now in and working. FreeBSD
patch is in review.
For multis
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
mrbff has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/810?usp=email )
Change subject: PUSH_UPDATE: Added update_option() function.
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
mrbff has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/809?usp=email )
Change subject: PUSH_UPDATE: Added remove_option() and do_update().
.
From: Antonio Quartulli
ovpn_handle_msg() is soon becoming the main entry point for parsing
*all* incoming netlink messages. For this reason it is essential
that this function is kept simple and slim.
Move all code parsing netlink multicast notifications to their own
helpers and then invoke them
Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1099?usp=email )
Change subject: dco_linux: factor out netlink notification code
...
Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email )
Change subject: dco_linux: fix async message reception
..
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email
to look at the new patch set (#4).
Change subject: dco: only pass struct
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1099?usp=email
to look at the new patch set (#4).
Change subject: dco_linux: factor out netlink notification
Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email )
Change subject: dco_linux: fix async message reception
..
Stared long and hard on the changes (some of the ugly bits just move around,
and are not new in this patch). Ran full client/server tests with Linux
DCO (passed).
Your patch has been applied to the master branch.
commit 0e0023fe48357150ef1c35b99451f6d3054e2c0b
Author: Antonio Quartulli
Date: W
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1099?usp=email )
Change subject: dco_linux: factor out netlink notification code
..
dco_linux: factor out netlink notification code
ovpn_handle_msg() is s
cron2 has uploaded a new patch set (#5) to the change originally created by
ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1099?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dco_linux: factor out netlink notification code
.
From: Antonio Quartulli
Future DCO code will require accessing the `multi` member of the
context object.
For this reason a pointer to the context has to be stored in the
DCO context along with the rest.
At this point, rather than making the call to ovpn_dco_init()
longer with more and more para
Hi,
Here's an implementation of the float notification handling for FreeBSD.
The OpenVPN bits are pretty trivial because it just extends existing mechanisms.
This does expect FreeBSD to actually send the notification, which requires this
patch: https://reviews.freebsd.org/D51468
There's a test
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1093?usp=email )
Change subject: multi: store multi_context address inside top instance
..
multi: store multi_context address inside top instance
Future m
cron2 has uploaded a new patch set (#2) to the change originally created by
ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1093?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: multi: store multi_context address inside top instance
..
The change is fairly trivial, but helps basically all sort of
"async things that need to access the multi context" later on.
I do look forward to crashing the new DCO code by running it in
"non multi" mode, though :-) (which is the risk that code changes
relying on this commit bring with them -
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email
to look at the new patch set (#3).
Change subject: dco_linux: fix async message reception
...
From: Kristof Provost
Signed-off-by: Kristof Provost
---
configure.ac | 9 +
src/openvpn/dco_freebsd.c | 68 ++
src/openvpn/dco_freebsd.h | 2 +
src/openvpn/multi.c| 2 +-
src/openvpn/ovpn_dco_freebsd.h | 1 +
5 fil
cron2 has uploaded a new patch set (#3) to the change originally created by
ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dco_linux: fix case statement by using proper error value
...
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email )
Change subject: dco_linux: fix case statement by using proper error value
..
dco_linux: fix case statement by using proper error value
A
Stared at the code, makes sense. Test compiled (after the explosion tonight,
you can never test enough :-) ).
Your patch has been applied to the master branch.
commit f1a2a37897a6517c4c321abb7bc343bf495c94e2
Author: Antonio Quartulli
Date: Wed Jul 23 08:20:06 2025 +0200
dco_linux: fix ca
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email )
Change subject: dco: only pass struct context to init function
.
Stared at the code, this is all "in netlink error handling", so the
changes makes sense.
Your patch has been applied to the master branch.
commit dfe71b0a397273efffabbc01d1f6a9933f607933
Author: Antonio Quartulli
Date: Wed Jul 23 08:30:30 2025 +0200
dco_linux: use M_FATAL instead of M_ERR
cron2 has uploaded a new patch set (#3) to the change originally created by
ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1096?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dco_linux: use M_FATAL instead of M_ERR in netlink error code
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1096?usp=email )
Change subject: dco_linux: use M_FATAL instead of M_ERR in netlink error code
paths
..
dco_linux: use M_FATAL instead of M_ERR in netlink
As mentioned every now and then, I'm not a big fan of patches that
move code around - we frequently use "git blame" to figure out why
certain code pieces came to be, and this gets more annoying if code
gets moved. This said, *if* code needs to move, I do prefer a patch
that has "no other changes"
cron2 has uploaded a new patch set (#3) to the change originally created by
ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1098?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dco_linux: rearrange functions
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1098?usp=email )
Change subject: dco_linux: rearrange functions
..
dco_linux: rearrange functions
In preparation for the implementation of a generic netli
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email )
Change subject: dco_linux: fix async message reception
..
Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email
to look at the new patch set (#3).
Change subject: dco: only pass struct
Attention is currently required from: flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1099?usp=email )
Change subject: dco_linux: factor out netlink notification code
..
42 matches
Mail list logo
