Attention is currently required from: cron2, flichtenheld, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/808?usp=email )
Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 21: (8 comments) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/0bc4e799_eafa8770 : PS19, Line 5567: apply_push_options(struct options *options, > please do not move that one around in options. […] Done http://gerrit.openvpn.net/c/openvpn/+/808/comment/010661f3_5e3b560e : PS19, Line 5654: > so I would call check_push_update_option_flags() from here, possibly moving > the "while isspace(*line […] Done File src/openvpn/options_util.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/47b8a262_12fab17a : PS19, Line 198: if (!line || !*line || !**line) > the use of a double pointer irritates me, because we never move the pointer, > instead `memmove()` the […] Done http://gerrit.openvpn.net/c/openvpn/+/808/comment/8e312009_6f3eacc1 : PS19, Line 231: > If there is whitespace here (`? route`) we'll fail with `pushed option is > not updateable: ' route' […] Done http://gerrit.openvpn.net/c/openvpn/+/808/comment/a777b4e8_51887b18 : PS19, Line 252: msg(D_PUSH, "Pushed option is not updatable: '%s'", *line); > Maybe add an " Ignoring. […] Done http://gerrit.openvpn.net/c/openvpn/+/808/comment/b521c226_07b2309a : PS19, Line 270: if (!o->pull_filter_list && !(is_update)) > So, if we call `check_push_update_option_flags()` from outside, we do not > need this extra dance, che […] Done http://gerrit.openvpn.net/c/openvpn/+/808/comment/4d43cf7c_4985502d : PS19, Line 276: while (isspace(*line)) > It makes sense to move that upwards to `apply_push_options()`, before calling > anything on the line. […] Done http://gerrit.openvpn.net/c/openvpn/+/808/comment/a7cb08ef_9c354e3e : PS19, Line 310: return true; > This duplication of the messages and `return true` looks a bit silly :-) - I > would suggest to do […] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 21 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Wed, 23 Jul 2025 17:11:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
