Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/792?usp=email
to review the following change.
Change subject: Manually reformat some long trailing comments
..
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/854?usp=email )
Change subject: Post tchar.h removal cleanup
..
Patch Set
From: Frank Lichtenheld
Remove some unused defines.
Change-Id: Ib3a166ead912beb2a591105c84d96d342664c05f
Signed-off-by: Frank Lichtenheld
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https:/
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/790?usp=email
to review the following change.
Change subject: Define a .clang-format file for the project
Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/838?usp=email
to look at the new patch set (#16).
The following approvals got outdated and were
Attention is currently required from: cron2, flichtenheld, plaisthos.
d12fk has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems
..
Attention is currently required from: plaisthos, stipa.
d12fk has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/837?usp=email )
Change subject: win: implement --dns option support with NRPT
..
Patch S
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/911?usp=email
to review the following change.
Change subject: socket: use remote proto when creating client so
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/840?usp=email
to look at the new patch set (#17).
Change subject: dns: don't publish en
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/830?usp=email )
Change subject: Remove uncrustify config and scripts, switch GHA
..
Set
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/854?usp=email )
Change subject: Post tchar.h removal cleanup
..
Post tchar.h removal cleanup
Remove some unused defines.
Change-Id: Ib3a166ead912beb2a591
cron2 has uploaded a new patch set (#5) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/854?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Post tchar.h removal cleanup
..
"Clean up the rest" - it looks a bit confusing at first, why the
UNICODE stuff is removed from service.h - but that's just because
"everything!" includes ../tapctl/basic.h, including service.h
Your patch has been applied to the master branch.
commit 6bb20fa8bebc29d8b3103662ffba4904d03e852d
Author
Attention is currently required from: d12fk, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/837?usp=email )
Change subject: win: implement --dns option support with NRPT
..
Patch S
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/830?usp=email
to review the following change.
Change subject: Remove uncrustify config and scripts, switch GHA
...
Attention is currently required from: d12fk, flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems
..
16 matches
Mail list logo