Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/911?usp=email
to review the following change.
Change subject: socket: use remote proto when creating client sockets
......................................................................
socket: use remote proto when creating client sockets
When creating a socket to connect to a remote (this happens
in client mode) always use the protocol specified for the
remote.
The listening protocol in this case is just ignored as it
does not make any sense.
Change-Id: I6d2ec69ac7a9ef5900d8f1d8541d6a19c9cb7df9
Signed-off-by: Antonio Quartulli <anto...@mandelbit.com>
---
M src/openvpn/socket.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/11/911/1
diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c
index 6b32e30..ad97830 100644
--- a/src/openvpn/socket.c
+++ b/src/openvpn/socket.c
@@ -1886,6 +1886,11 @@
const char *remote_host = o->ce.remote;
const char *remote_port = o->ce.remote_port;
+ if (remote_host)
+ {
+ proto = o->ce.proto;
+ }
+
if (c->mode == CM_CHILD_TCP || c->mode == CM_CHILD_UDP)
{
struct link_socket *tmp_sock = NULL;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/911?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6d2ec69ac7a9ef5900d8f1d8541d6a19c9cb7df9
Gerrit-Change-Number: 911
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <a...@unstable.cc>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
