[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Clean up use of TEXT() from DNS patches

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/910?usp=email to look at the new patch set (#2). Change subject: openvpnserv: Clean up use of TEXT() from DNS patches

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Clean up use of TEXT() from DNS patches

Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/910?usp=email ) Change subject: openvpnserv: Clean up use of TEXT() from DNS patches ..

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Clean up use of TEXT() from DNS patches

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/910?usp=email to review the following change. Change subject: openvpnserv: Clean up use of TEXT() from DNS patches ...

[Openvpn-devel] [patch]: debian lintian informational warning (Authorization)

trivial spelling error raised by lintian. -- g. Marc GPG: 827C FD74 BA46 8152 A041 F3A0 7A6A 4F17 5995 A65B Description: Fix spelling error in error message Author: Marc Leeman When packaging, lintian complains about a spelling error (informational). Last-Update: 2025-03-18 Index: salsa/gdbu

[Openvpn-devel] [M] Change in openvpn[master]: Post tchar.h removal cleanup

Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/854?usp=email ) Change subject: Post tchar.h removal cleanup .. Patch Set 3: Thi

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/text-removal.sh: Script to remove usage of tchar.h

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/852?usp=email ) Change subject: dev-tools/text-removal.sh: Script to remove usage of tchar.h .

[Openvpn-devel] [L] Change in openvpn[master]: Apply text-removal.sh script to Windows codebase

Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/853?usp=email ) Change subject: Apply text-removal.sh script to Windows codebase ..

[Openvpn-devel] [M] Change in openvpn[master]: Post tchar.h removal cleanup

Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/854?usp=email ) Change subject: Post tchar.h removal cleanup .. Patch Set 3: (1

[Openvpn-devel] [L] Change in openvpn[master]: options: Cleanup and simplify options_postprocess_verify_ce

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/832?usp=email ) Change subject: options: Cleanup and simplify options_postprocess_verify_ce ...

[Openvpn-devel] [L] Change in openvpn[master]: options: Cleanup and simplify options_postprocess_verify_ce

Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/832?usp=email ) Change subject: options: Cleanup and simplify options_postprocess_verify_ce ...

[Openvpn-devel] [PATCH v3] options: Cleanup and simplify options_postprocess_verify_ce

From: Frank Lichtenheld - Reuse the MUST_BE_UNDEF macro in more places - Add a second parameter so it actually reports the correct option name - Add MUST_BE_FALSE for similar cases - Reorder the checks for cert/key options to make more sense. Some of the checks could have never fired due to

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Clean up use of TEXT() from DNS patches

Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/910?usp=email ) Change subject: openvpnserv: Clean up use of TEXT() from DNS patches ..

[Openvpn-devel] [PATCH v3] Post tchar.h removal cleanup

From: Frank Lichtenheld Change-Id: Ib3a166ead912beb2a591105c84d96d342664c05f Signed-off-by: Frank Lichtenheld Acked-by: Lev Stipakov --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn

[Openvpn-devel] [PATCH applied] Re: openvpnserv: Clean up use of TEXT() from DNS patches

Everything very straightforward, TEXT to L"", adding "%s, __func__" which makes the lines wrap nicer, and some of them end up not wrapped at all. MinGW has nothing to complain either. Your patch has been applied to the master branch. commit f134eeb9c09a124127f64d64191e16a9ed7e105d Author: Frank

[Openvpn-devel] [PATCH applied] Re: Apply text-removal.sh script to Windows codebase

Stared-at-code, as did Lev (whose +2 got lost due to gerrit flag changes). Really 'just mechanically moving from TEXT("string") to L"string", "LPTSTR" to "LPWSTR" and so on'. I did a test compile on Ubuntu/MingW, and no warnings ensued. Your patch has been applied to the master branch. commit 2

[Openvpn-devel] [L] Change in openvpn[master]: options: Cleanup and simplify options_postprocess_verify_ce

cron2 has uploaded a new patch set (#4) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/832?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: options: Cleanup and simplify options_postprocess_verif

[Openvpn-devel] [L] Change in openvpn[master]: options: Cleanup and simplify options_postprocess_verify_ce

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/832?usp=email ) Change subject: options: Cleanup and simplify options_postprocess_verify_ce .. options: Cleanup and simplify options_postprocess_verify_ce

[Openvpn-devel] [PATCH applied] Re: options: Cleanup and simplify options_postprocess_verify_ce

I have thoroughly stared at the code, and the change definitly makes things easier to understand and more straightforward. I have not actively verified that all variants of invalid option combinations are still flagged - but that's why macros, to make sure the code always does the right thing. Bu

[Openvpn-devel] [M] Change in openvpn[master]: dns: clean up --dhcp-options when --dns is active

Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#5). Change subject: dns: clean up --dhcp-options when --

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Clean up use of TEXT() from DNS patches

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/910?usp=email ) Change subject: openvpnserv: Clean up use of TEXT() from DNS patches .. openvpnserv: Clean up use of TEXT() from DNS patches These are sli

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Clean up use of TEXT() from DNS patches

cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/910?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: openvpnserv: Clean up use of TEXT() from DNS patches ..

[Openvpn-devel] [PATCH v2] Apply text-removal.sh script to Windows codebase

From: Frank Lichtenheld Change-Id: I8f53c49b885c7c9e36a78ca434ec021e6dc347e0 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn

[Openvpn-devel] [PATCH v2] openvpnserv: Clean up use of TEXT() from DNS patches

From: Frank Lichtenheld These are slightly different and so not covered by my automatic conversion script. Use __func__ to make the actual string slightly shorter. Change-Id: If15862fe537496ac836fc443936ff8e7876a39c0 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Clean up use of TEXT() from DNS patches

Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/910?usp=email ) Change subject: openvpnserv: Clean up use of TEXT() from DNS patches ...