I have thoroughly stared at the code, and the change definitly makes things easier to understand and more straightforward.
I have not actively verified that all variants of invalid option combinations are still flagged - but that's why macros, to make sure the code always does the right thing. Buildbot says "it compiles fine, ship it" ;-) Your patch has been applied to the master branch. commit db48cea4f71005bd40499a4af901b91e4dff0569 Author: Frank Lichtenheld Date: Tue Mar 18 16:53:11 2025 +0100 options: Cleanup and simplify options_postprocess_verify_ce Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20250318155320.32573-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31155.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel