[Openvpn-devel] [M] Change in openvpn[master]: Allow having an extra function that is called when an env is freed

2025-03-08 Thread cron2 (Code Review)
cron2 has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/486?usp=email ) Change subject: Allow having an extra function that is called when an env is freed .. Abandoned The change that needs this is the one fo

[Openvpn-devel] [M] Change in openvpn[master]: Implement override-username

2025-03-08 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Implement override-username ...

[Openvpn-devel] [M] Change in openvpn[master]: Remove various unused function parameters

2025-03-08 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#5) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/862?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Remove various unused function parameters .

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-08 Thread cron2 (Code Review)
Attention is currently required from: d12fk, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: dns: don't publish env vars to non-dns scripts .

[Openvpn-devel] [M] Change in openvpn[master]: Handle missing DCO peer by restarting the session

2025-03-08 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/831?usp=email ) Change subject: Handle missing DCO peer by restarting the session .. Handle missing DCO peer by restarting the session Occasionally, CMD_D

[Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null

2025-03-08 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#12) to the change originally created by mattock. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Add lwip support to t_server_null ..

[Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null

2025-03-08 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email ) Change subject: Add lwip support to t_server_null .. Add lwip support to t_server_null Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d25

[Openvpn-devel] [PATCH applied] Re: Add lwip support to t_server_null

2025-03-08 Thread Gert Doering
Thanks for addressing my comments, and sorry for dragging my feet again. Now we have multisockets, so, looking forward to see more challenging t_server_null+lwip tests materialize in our build infra :-) Haven't tested it beyond what BB already did, and that is all green. Your patch has been appl

[Openvpn-devel] [M] Change in openvpn[master]: Remove various unused function parameters

2025-03-08 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/862?usp=email ) Change subject: Remove various unused function parameters .. Patc

[Openvpn-devel] [PATCH applied] Re: Remove various unused function parameters

2025-03-08 Thread Gert Doering
Stared-at-code, considered whether to keep some of the "this looks like something was planned for future enhancements" things, decided against it (like the multicast stuff) - we can bring the args back if someone really wants to work on that. Test compiled on MinGW, for good measure ;-) - but all

[Openvpn-devel] [M] Change in openvpn[master]: Keep exported certificate files for following calls

2025-03-08 Thread cron2 (Code Review)
cron2 has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/487?usp=email ) Change subject: Keep exported certificate files for following calls .. Abandoned "nobody asked for it, and it is quite a complex change"

[Openvpn-devel] [PATCH applied] Re: Handle missing DCO peer by restarting the session

2025-03-08 Thread Gert Doering
Thanks, and sorry for stalling since January. This is still not "really really" pretty, but I am still convinced that dealing with DCO related issues inside dco*.c is a better approach :-) I have not actually excercised the code (I do not have experienced the underlying issue yet, which smells l

[Openvpn-devel] [M] Change in openvpn[master]: Handle missing DCO peer by restarting the session

2025-03-08 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/831?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Handle missing DCO peer by restarting the session .

[Openvpn-devel] [M] Change in openvpn[master]: Remove various unused function parameters

2025-03-08 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/862?usp=email ) Change subject: Remove various unused function parameters .. Patc

[Openvpn-devel] [PATCH v4] Remove various unused function parameters

2025-03-08 Thread Gert Doering
From: Frank Lichtenheld Change-Id: Ia3b0f22b0049a111ce52b3c87dd08a843ea9a919 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn

[Openvpn-devel] [M] Change in openvpn[master]: Implement override-username

2025-03-08 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email ) Change subject: Implement override-username .. Patc

[Openvpn-devel] [M] Change in openvpn[master]: Remove various unused function parameters

2025-03-08 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/862?usp=email ) Change subject: Remove various unused function parameters .. Remove various unused function parameters Change-Id: Ia3b0f22b0049a111ce52b3c