Attention is currently required from: flichtenheld, ordex, plaisthos, stipa.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email ) Change subject: Implement override-username ...................................................................... Patch Set 8: (4 comments) Patchset: PS8: one minor nit (manpage), one major nit (*boom*). File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/872/comment/69b22c75_363de9cc : PS8, Line 421: --override-username this is missing the "username" argument http://gerrit.openvpn.net/c/openvpn/+/872/comment/e1365250_cc8b4a6a : PS8, Line 428: Also ``username-as-common-name`` will use the client provided username `--` missing before `username-as-common-name`, while all other opions referenced have it File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/872/comment/d4cf5d2c_a9aa9911 : PS8, Line 2692: && strcmp(multi->locked_username, options->override_username) != 0) I managed to SIGSEGV this on client connect... ``` #0 0x00007ffff7913ceb in ?? () from /lib64/libc.so.6 #1 0x0000555555594699 in override_locked_username (mi=mi@entry=0x555555709dc0) at multi.c:2698 #2 0x00005555555983d2 in multi_connection_established (m=0x7fffffffc490, ... (gdb) print multi->locked_original_username $1 = 0x0 (gdb) print multi->locked_username $2 = 0x0 (gdb) print options->override_username $3 = 0x55555570f658 "MyUsernameFromCCD" ``` the config is set up for testing - it has `auth-gen-token` in the main config, and `override-username mumble` in the client's CCD/. It does not have `auth-user-pass-verify` or `auth-user-pass-*` in the config. (The original config had `auth-user-pass-optional` + an `auth-user-pass-verify script`, but for the test I did not want the script, and openvpn disallowed having "just auth-user-pass[-optional] without a verify method"... so I removed the other one too) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/872?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia4095518d5e4447992a2974e0d7a159d79ba6b6f Gerrit-Change-Number: 872 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Sat, 08 Mar 2025 11:32:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
