cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/898?usp=email )
Change subject: get_default_gateway(): Prevent passing IPV4_INVALID_ADDR as a
destination
..
get_default_gateway(): Prevent passing IPV4_I
cron2 has uploaded a new patch set (#4) to the change originally created by
mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/898?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: get_default_gateway(): Prevent passing IPV4_INVALID_ADDR as a
There has been quite a bit of discussion about this one-liner on
#openvpn-devel - this is not a particularily pretty piece of code, nor
easy to understand. It's intended as a "do not break existing setups"
bandaid, while we spend more thoughts on making this work better, and
also clarify for ourse
From: Arne Schwabe
Change-Id: Ieb787a040f9eaf34d9d16996af1d63d7eae94944
Signed-off-by: Arne Schwabe
Acked-by: Frank Lichtenheld
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/89
Attention is currently required from: cron2, flichtenheld, mrbff, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/898?usp=email
to look at the new patch set (#2).
The following approvals got outdated an
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/895?usp=email )
Change subject: Add Android cmake building
..
Patch Set 2: Code-Review+2
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/896?usp=email )
Change subject: Add android build to Github Actions
..
Patch Set 3: Code
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/895?usp=email
to look at the new patch set (#3).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Ch
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/896?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review-1 by
From: Arne Schwabe
Change-Id: Ieb787a040f9eaf34d9d16996af1d63d7eae94944
Signed-off-by: Arne Schwabe
Acked-by: Frank Lichtenheld
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/89
From: Arne Schwabe
There is a mode to build with a real Android NDK that requires setting up cmake
to build with the NDK and so.
For quick&dirty compile tests that do not actually use the Android NDK on
Linux, -DFAKE_ANDROID on Linux can be
used to compile a binary using TARGET_ANDROID.
Change
Attention is currently required from: flichtenheld, mrbff, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/898?usp=email )
Change subject: get_default_gateway(): Make sure the get_default_gateway()
function never receives IPV4_INVALID_ADDR as a desti
From: Marco Baffo
Change-Id: I02afe6817433ca21aae76671c35151ec6a066933
Signed-off-by: Marco Baffo
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/898
This
Since I do not use cmake, I haven't tested this myself - but it looks
good and has an ACK from Frank.
Your patch has been applied to the master branch.
commit 6e16dc6216a9ce5a03292d64420d88582829c533
Author: Arne Schwabe
Date: Fri Feb 14 13:52:38 2025 +0100
Add Android cmake building
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/898?usp=email
to review the following change.
Change subject: get_dafault_gateway(): Make sure the get_default
Attention is currently required from: cron2, flichtenheld, plaisthos.
mrbff has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/898?usp=email )
Change subject: get_default_gateway(): Make sure the get_default_gateway()
function never receives IPV4_INVALID_ADDR as a desti
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/897?usp=email )
Change subject: Build on all four possible Android ABIs
..
Patch Set 1:
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/896?usp=email )
Change subject: Add android build to Github Actions
..
Patch Set 2: Code
Attention is currently required from: flichtenheld, mrbff, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/898?usp=email )
Change subject: get_dafault_gateway(): Make sure the get_default_gateway()
function never receives IPV4_INVALID_ADDR as a desti
cron2 has uploaded a new patch set (#4) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/895?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Add (fake) Android cmake building
.
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/895?usp=email )
Change subject: Add (fake) Android cmake building
..
Add (fake) Android cmake building
There is a mode to build with a real Android NDK th
Attention is currently required from: cron2, its_Giaan, ordex, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/764?usp=email
to look at the new patch set (#19).
The following approvals got outdated and
Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/874?usp=email
to look at the new patch set (#5).
The change is no longer submittable: check
Attention is currently required from: cron2, ordex, plaisthos.
its_Giaan has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/764?usp=email )
Change subject: Add support for simultaneous use of UDP and TCP sockets
...
Attention is currently required from: cron2, flichtenheld, mrbff, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/898?usp=email
to look at the new patch set (#3).
The following approvals got outdated an
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/894?usp=email
to look at the new patch set (#4).
Change subject: Fix warnings on Android about unused variables/methods
.
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/896?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+2 by
From: Marco Baffo
When using --redirect-gateway (IPv4) while connected to an IPv6 remote,
OpenVPN still attempts to determine the IPv4 default gateway,
so link_socket_current_remote() returns IPV4_INVALID_ADDR (0x)
as the destination, leading to unintended behavior:
- the IPv4 default ga
Attention is currently required from: flichtenheld, mrbff, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/898?usp=email )
Change subject: get_default_gateway(): Prevent passing IPV4_INVALID_ADDR as a
destination
.
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/896?usp=email )
Change subject: Add android build to Github Actions
..
Patch Set 4: Code
Tested on GHA, succeeds. v3 failed due to -Werror in effect, and
some of these warnings are in #ifdef messes that need careful pruning...
(gerrit #894, work in progress).
(Why are we doing this? To avoid commits like 3ddfe26e491... :-) )
Your patch has been applied to the master branch.
commit
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/896?usp=email )
Change subject: Add android build to Github Actions
..
Add android build to Github Actions
Change-Id: Ieb787a040f9eaf34d9d16996af1d63d7eae
cron2 has uploaded a new patch set (#5) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/896?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Add android build to Github Actions
...
33 matches
Mail list logo
