Attention is currently required from: flichtenheld, mrbff, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/898?usp=email )
Change subject: get_dafault_gateway(): Make sure the get_default_gateway()
function never receives IPV4_INVALID_ADDR as a destination.
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
Patchset:
PS1:
Typo in `get_dafault...` in the commit message, and please add a few words why
this is needed ("commit ... added using the remote VPN host address to query
the default gateway which fails when connecting using IPv6")
File src/openvpn/options.c:
http://gerrit.openvpn.net/c/openvpn/+/898/comment/4d8cea43_70bff5a2 :
PS1, Line 5876: get_default_gateway_ipv6(&rgi6, &remote_ipv6, &net_ctx);
this change is not needed. get_ip_addr() will return `0` on everything that is
not a valid IPv4 address (or can resolve to one).
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/898?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I02afe6817433ca21aae76671c35151ec6a066933
Gerrit-Change-Number: 898
Gerrit-PatchSet: 1
Gerrit-Owner: mrbff <ma...@mandelbit.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: mrbff <ma...@mandelbit.com>
Gerrit-Comment-Date: Fri, 14 Feb 2025 10:20:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
