[Openvpn-devel] [PATCH v11] Adapt socket handling to support listening on multiple sockets

2024-12-30 Thread Gert Doering
From: Antonio Quartulli Introduce internal changes preparing the server to handle multiple sockets concurrently for both TCP and UDP protocols. While no user-visible features are implemented yet, these modifications are essential for enabling future functionality such as l

[Openvpn-devel] [L] Change in openvpn[master]: Adapt socket handling to support listening on multiple sockets

2024-12-30 Thread cron2 (Code Review)
Attention is currently required from: its_Giaan, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email ) Change subject: Adapt socket handling to support listening on multiple sockets

[Openvpn-devel] [L] Change in openvpn[master]: Adapt socket handling to support listening on multiple sockets

2024-12-30 Thread cron2 (Code Review)
Attention is currently required from: its_Giaan, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email ) Change subject: Adapt socket handling to support listening on multiple sockets

[Openvpn-devel] [PATCH applied] Re: Adapt socket handling to support listening on multiple sockets

2024-12-30 Thread Gert Doering
Detailed discussion, review, etc. is all on gerrit (and linked in this thread). So not repeating all the details. Stared at the code and the incremental patches long and hard, and gave it a thorough test on the client/server testbed (which broke on v10), but now it succeeds. Your patch has been

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

2024-12-30 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: enable mode server on supported configuration

2024-12-30 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/812?usp=email ) Change subject: dco-win: enable mode server on supported configuration .. dco-win: enable mode server on supported configuration Enable dc

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: enable mode server on supported configuration

2024-12-30 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#7) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/812?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco-win: enable mode server on supported configuration ...

[Openvpn-devel] [PATCH applied] Re: dco-win: enable mode server on supported configuration

2024-12-30 Thread Gert Doering
Stared at code, test compiled on MinGW/Ubuntu. Looks good, paves the way... Your patch has been applied to the master branch. commit 7fac3716a9cb4d0c104d18b4dc939d73736a4ef3 Author: Lev Stipakov Date: Mon Dec 30 20:32:04 2024 +0100 dco-win: enable mode server on supported configuration

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

2024-12-30 Thread its_Giaan (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. its_Giaan has uploaded a new patch set (#10) to the change originally created by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config fil

[Openvpn-devel] [L] Change in openvpn[master]: Adapt socket handling to support listening on multiple sockets

2024-12-30 Thread its_Giaan (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email ) Change subject: Adapt socket handling to support listening on multiple sockets

[Openvpn-devel] [L] Change in openvpn[master]: Bind to multiple ipv4/ipv6 addresses

2024-12-30 Thread cron2 (Code Review)
Attention is currently required from: its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/764?usp=email ) Change subject: Bind to multiple ipv4/ipv6 addresses .. Patch Set 10

[Openvpn-devel] [XL] Change in openvpn[master]: multiproto: move generic event handling code in dedicated files

2024-12-30 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/763?usp=email ) Change subject: multiproto: move generic event handling code in dedicated files

[Openvpn-devel] [PATCH v6] dco-win: enable mode server on supported configuration

2024-12-30 Thread Gert Doering
From: Lev Stipakov Enable dco-win with mode server if driver supports it. Disable for proto TCP or older drivers. Change-Id: Iea4538cee075d50de836d1ef7652985186b2527c Signed-off-by: Lev Stipakov Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one develo

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: enable mode server on supported configuration

2024-12-30 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/812?usp=email ) Change subject: dco-win: enable mode server on supported configuration .

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

2024-12-30 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-30 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support

2024-12-30 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: dns: support running up/down script with privsep

2024-12-30 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email ) Change subject: dns: support running up/down script with privsep ..

[Openvpn-devel] [M] Change in openvpn[master]: dns: support running up/down script with privsep

2024-12-30 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#6). Change subject: dns: support running up/down script with pr

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: enable mode server on supported configuration

2024-12-30 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/812?usp=email ) Change subject: dco-win: enable mode server on supported configuration .

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: enable mode server on supported configuration

2024-12-30 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/812?usp=email to look at the new patch set (#6). The following approvals got outdated an