Re: [Openvpn-devel] [PATCH] Add calls to nvlist_destroy to avoid leaks

2024-11-04 Thread Gert Doering
Hi, so, I had the ACK from Kristof in GH#636 and was going to apply it, but "this patch does not compile" On Wed, Oct 30, 2024 at 10:31:57AM +, Rémi FARAULT via Openvpn-devel wrote: > if (remoteaddr) > { > -nvlist_add_nvlist(nvl, "remote", sockaddr_to_nvlist(remoteaddr)); >

[Openvpn-devel] [S] Change in openvpn[master]: send uname() release as IV_PLAT_VER= on non-windows versions

2024-11-04 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/793?usp=email ) Change subject: send uname() release as IV_PLAT_VER= on non-windows versions ...

[Openvpn-devel] [PATCH v4] send uname() release as IV_PLAT_VER= on non-windows versions

2024-11-04 Thread Gert Doering
This is highly system specific, as the content of the uname() structure elements is not specified very well - uname(3) says: release Release level of the operating system which translates to "IV_PLAT_VER=13.3-RELEASE-p6" (FreeBSD) or "IV_PLAT_VER=22.6.0" (macOS) - the latter being the