Hi, so, I had the ACK from Kristof in GH#636 and was going to apply it, but "this patch does not compile"
On Wed, Oct 30, 2024 at 10:31:57AM +0000, Rémi FARAULT via Openvpn-devel wrote:
> if (remoteaddr)
> {
> - nvlist_add_nvlist(nvl, "remote", sockaddr_to_nvlist(remoteaddr));
> + remote_nvl = sockaddr_to_nvlist(remoteaddr);
> + nvlist_add_nvlist(nvl, "remote", remove_nvl);
> }
There is an "remove" here, not "remote"...
Can you please fix & send a v2 ("git send-email -v2")?
While at it, please add all the stuff that's in the GH MR to the commit
message ;-) - I'm happy to do that for "infrequent contributors", but
project rules disallow me to change actual code. So when doing the
new version, you can just add:
----------------------------------------------------
Add calls to nvlist_destroy to avoid leaks
Some memory leaks were detected by valgrind on the openvpn daemon, using
DCO mode on a FreeBSD platform. The leaks are caused by missing
nvlist_destroy calls in the file dco_freebsd.c.
Calls to nvlist_destroy were added, sometimes using local variables to
store nvlist pointers temporarly. A valgrind run on the updated daemon
confirmed that the leaks were gone.
Github: OpenVPN/openvpn#636
Signed-off-by: R<A9>mi Farault <remi.fara...@stormshield.eu>
----------------------------------------------------
(sorry for the name mangling, I do my best to make the commit UTF8
correct, but to/from e-mail tends to be... interesting)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
