[Openvpn-devel] [PATCH applied] Re: Improve data channel crypto error messages

Stared a bit at the code, poked MaxF to do a more thorough review (thanks), did a test compile. Out of curiosity - are you really seeing that many "authentication errors on bad connections"? Aka "shouldn't lower-layer checksums not catch and drop packet corruptions"? Your patch has been applied

[Openvpn-devel] [S] Change in openvpn[master]: Improve data channel crypto error messages

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/774?usp=email ) Change subject: Improve data channel crypto error messages .. Improve data channel crypto error messages * Make decryption error messages

[Openvpn-devel] [S] Change in openvpn[master]: Improve data channel crypto error messages

cron2 has uploaded a new patch set (#2) to the change originally created by syzzer. ( http://gerrit.openvpn.net/c/openvpn/+/774?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by MaxF Change subject: Improve data channel crypto error messages ...

[Openvpn-devel] [L] Change in openvpn[master]: Bind to multiple ipv4/ipv6 addresses

Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/764?usp=email ) Change subject: Bind to multiple ipv4/ipv6 addresses .. Patch

Re: [Openvpn-devel] [PATCH applied] Re: Improve data channel crypto error messages

Am 17.10.2024 um 09:01 schrieb Gert Doering: Stared a bit at the code, poked MaxF to do a more thorough review (thanks), did a test compile. Out of curiosity - are you really seeing that many "authentication errors on bad connections"? Aka "shouldn't lower-layer checksums not catch and drop p

[Openvpn-devel] [M] Change in openvpn[master]: Remove a large number of unused structs and functions

Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/783?usp=email to review the following change. Change subject: Remove a large number of unused structs and functions

[Openvpn-devel] [M] Change in openvpn[master]: Remove unused methods write_key/read_key

Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/784?usp=email to review the following change. Change subject: Remove unused methods write_key/read_key .

[Openvpn-devel] [M] Change in openvpn[master]: Remove unused methods write_key/read_key

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/784?usp=email ) Change subject: Remove unused methods write_key/read_key .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Remove a large number of unused structs and functions

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/783?usp=email ) Change subject: Remove a large number of unused structs and functions .

[Openvpn-devel] [PATCH v1] Remove a large number of unused structs and functions

From: Arne Schwabe These have been found by Clion's Inspect Code functionality and have been verified by hand. A few functions like buf_read_u32 have been kept since they still feel being useful while currently not being used. Change-Id: I0d96ee06c355c6a5ce082af23921e329d3efae33 Signed-off-by:

[Openvpn-devel] [PATCH v1] Remove unused methods write_key/read_key

From: Arne Schwabe These were used in the key-method 1 that we remove by commit 36bef1b52 in 2020. That commit unfortunately missed that these methods were only used for directly sending/receiving key material over the control channel. Change-Id: Ib480e57b62ea33f2aea52bee895badaf5607b72d Signed

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/758?usp=email ) Change subject: pass link_socket object to i/o functions ...

[Openvpn-devel] [M] Change in openvpn[master]: event/multi: add event_arg object to make event handling more generic

Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/757?usp=email ) Change subject: event/multi: add event_arg object to make event handling more generic .

[Openvpn-devel] [S] Change in openvpn[master]: io_work: convert shift argument to uintptr_t

Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/759?usp=email ) Change subject: io_work: convert shift argument to uintptr_t ...

[Openvpn-devel] [S] Change in openvpn[master]: io_work: pass event_arg object to event handler in case of socket event

Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/760?usp=email ) Change subject: io_work: pass event_arg object to event handler in case of socket event ...

[Openvpn-devel] [XL] Change in openvpn[master]: multiproto: move generic event handling code in dedicated files

Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/763?usp=email ) Change subject: multiproto: move generic event handling code in dedicated files ...

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

Attention is currently required from: flichtenheld, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/758?usp=email ) Change subject: pass link_socket object to i/o functions ...

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/758?usp=email to look at the new patch set (#5). The following approvals got outdate

[Openvpn-devel] [S] Change in openvpn[master]: io_work: convert shift argument to uintptr_t

Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/759?usp=email to look at the new patch set (#5). The following approvals got outdate

[Openvpn-devel] [S] Change in openvpn[master]: if a local IPv6 address is provided, socket must be v6-only

Attention is currently required from: flichtenheld, ordex, plaisthos. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/761?usp=email to look at the new patch set (#5). Change subject: if a local IPv6 address is pr

[Openvpn-devel] [S] Change in openvpn[master]: override ai_family if 'local' numeric address was specified

Attention is currently required from: flichtenheld, ordex, plaisthos. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/762?usp=email to look at the new patch set (#5). Change subject: override ai_family if 'local'

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos. its_Giaan has uploaded a new patch set (#6) to the change originally created by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [S] Change in openvpn[master]: io_work: pass event_arg object to event handler in case of socket event

Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/760?usp=email to look at the new patch set (#5). The following approvals got outdate

[Openvpn-devel] [M] Change in openvpn[master]: event/multi: add event_arg object to make event handling more generic

Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/757?usp=email to look at the new patch set (#5). The following approvals got outdate

[Openvpn-devel] [L] Change in openvpn[master]: Adapt socket handling to support listening on multiple sockets

Attention is currently required from: flichtenheld, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email ) Change subject: Adapt socket handling to support listening on multiple sockets .

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

Attention is currently required from: flichtenheld, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files ...