[Openvpn-devel] [L] Change in openvpn[master]: Bind to multiple ipv4/ipv6 addresses

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/764?usp=email to review the following change. Change subject: Bind to multiple ipv4/ipv6 addresses ...

[Openvpn-devel] [M] Change in openvpn[master]: Refinement to handle simultaneous UDP and TCP connections

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/766?usp=email to review the following change. Change subject: Refinement to handle simultaneous UDP and TCP co

[Openvpn-devel] [S] Change in openvpn[master]: override ai_family if 'local' numeric address was specified

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/762?usp=email to review the following change. Change subject: override ai_family if 'local' numeric add

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/758?usp=email to review the following change. Change subject: pass link_socket object to i/o functions

[Openvpn-devel] [M] Change in openvpn[master]: event/multi: add event_arg object to make event handling more generic

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/757?usp=email to review the following change. Change subject: event/multi: add event_arg object to make

[Openvpn-devel] [S] Change in openvpn[master]: io_work: convert shift argument to uintptr_t

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/759?usp=email to review the following change. Change subject: io_work: convert shift argument to uintpt

[Openvpn-devel] [S] Change in openvpn[master]: mroute: properly print protocol at the end of the string

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/765?usp=email to review the following change. Change subject: mroute: properly print protocol at the end of th

[Openvpn-devel] [S] Change in openvpn[master]: if a local IPv6 address is provided, socket must be v6-only

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/761?usp=email to review the following change. Change subject: if a local IPv6 address is provided, sock

[Openvpn-devel] [S] Change in openvpn[master]: io_work: pass event_arg object to event handler in case of socket event

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/760?usp=email to review the following change. Change subject: io_work: pass event_arg object to event h

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

2024-09-23 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email ) Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn .

[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=email to look at the new patch set (#7). The following approvals got outdate

[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

2024-09-23 Thread its_Giaan (Code Review)
Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=email to look at the new patch set (#8). Change subject: Route: add support