[Openvpn-devel] [PATCH v11] Move to common backend_driver type in struct tuntap

2024-09-22 Thread Gert Doering
From: Arne Schwabe With the introduction of utun on macOS and DCO on Linux, FreeBSD and Windows, a lot of platforms have now more than one driver/backend for the tun interface but each one uses a different mechanism. Unify these approach with using a common enum that defines the driver_type. Cha

[Openvpn-devel] [M] Change in openvpn[master]: Move to common backend_driver type in struct tuntap

2024-09-22 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/738?usp=email ) Change subject: Move to common backend_driver type in struct tuntap ...

[Openvpn-devel] [M] Change in openvpn[master]: Move to common backend_driver type in struct tuntap

2024-09-22 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#12) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/738?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Move to common backend_driver type in struct tuntap .

[Openvpn-devel] [M] Change in openvpn[master]: Move to common backend_driver type in struct tuntap

2024-09-22 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/738?usp=email ) Change subject: Move to common backend_driver type in struct tuntap .. Move to common backend_driver type in struct tuntap With the introd

[Openvpn-devel] [PATCH applied] Re: Move to common backend_driver type in struct tuntap

2024-09-22 Thread Gert Doering
Stared-at-code, and fed to GHA to be sure I haven't overlooked anything in the windows builds. All the other platforms should be covered by gerrit and the t_client tests (especially MacOS and utun). Your patch has been applied to the master branch. commit d8490738e64a5bbf00d6f08af03fef58f7488140

[Openvpn-devel] [S] Change in openvpn[master]: Use print_tun_backend_driver instead of custom code to print type

2024-09-22 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/749?usp=email ) Change subject: Use print_tun_backend_driver instead of custom code to print type

[Openvpn-devel] [S] Change in openvpn[master]: Automatically enable ifconfig-exec/route-exec behaviour for afunix tu...

2024-09-22 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/750?usp=email ) Change subject: Automatically enable ifconfig-exec/route-exec behaviour for afunix tun/tap ...

[Openvpn-devel] [L] Change in openvpn[master]: Add siphash reference implementation

2024-09-22 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/29?usp=email ) Change subject: Add siphash reference implementation .. Patch Set 6

[Openvpn-devel] [L] Change in openvpn[master]: Remove support for compression on send

2024-09-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/755?usp=email to review the following change. Change subject: Remove support for compression on send .

[Openvpn-devel] [M] Change in openvpn[master]: Automatically enable --compress migrate on the server

2024-09-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/756?usp=email to review the following change. Change subject: Automatically enable --compress migrate on the server ..

[Openvpn-devel] [L] Change in openvpn[master]: Remove support for compression on send

2024-09-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/755?usp=email to look at the new patch set (#2). Change subject: Remove support for compression on send

[Openvpn-devel] [S] Change in openvpn[master]: Automatically enable --compress migrate on the server

2024-09-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/756?usp=email to look at the new patch set (#2). Change subject: Automatically enable --compress migrate on the server .

[Openvpn-devel] [L] Change in openvpn[master]: Remove support for compression on send

2024-09-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/755?usp=email to look at the new patch set (#3). Change subject: Remove support for compression on send