Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/750?usp=email )

Change subject: Automatically enable ifconfig-exec/route-exec behaviour for 
afunix tun/tap
......................................................................


Patch Set 10: Code-Review-1

(2 comments)

Patchset:

PS10:
overall I'm still fine with this patch, just this one hunk in tun.c wants to be 
in a different patch of the series, no?


File src/openvpn/tun.c:

http://gerrit.openvpn.net/c/openvpn/+/750/comment/6890a8dd_f59b1b89 :
PS10, Line 1747:     if (tt->backend_driver != DRIVER_AFUNIX && 
tt->backend_driver != DRIVER_NULL)
I think there is rebase corruption here - this should go into the "DRIVER_NULL" 
patch



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/750?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0a2957699757665d70514ba7cafe833443018ad6
Gerrit-Change-Number: 750
Gerrit-PatchSet: 10
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Mon, 23 Sep 2024 06:20:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to