[Openvpn-devel] [XS] Change in openvpn[master]: Route: remove uncorrect routes on exit.

2024-02-15 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/522?usp=email to review the following change. Change subject: Route: remove uncorrect routes on exit.

[Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: Fix bug preventing proxy credentials caching.

2024-02-15 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email to review the following change. Change subject: Http-proxy: Fix bug preventing proxy credentials

[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

2024-02-15 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=email to review the following change. Change subject: Route: add support for user defined routing tabl

[Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-15 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/525?usp=email to review the following change. Change subject: Minor fix to process_ip_header .

Re: [Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-15 Thread Gert Doering
Hi, On Thu, Feb 15, 2024 at 03:59:02PM +, its_Giaan (Code Review) wrote: > if (buf->len > 0) > { > -/* > - * The --passtos and --mssfix options require > - * us to examine the IPv4 header. > - */ > - > -if (flags & (PIP_MSSFIX > -#if PASSTOS_CA

Re: [Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-15 Thread Gianmarco De Gregori
Hi, Il 15/02/2024 17:17, Gert Doering ha scritto: Hi, On Thu, Feb 15, 2024 at 03:59:02PM +, its_Giaan (Code Review) wrote: if (buf->len > 0) { -/* - * The --passtos and --mssfix options require - * us to examine the IPv4 header. - */ - -i