Hi,
On Thu, Feb 15, 2024 at 03:59:02PM +0000, its_Giaan (Code Review) wrote:
> if (buf->len > 0)
> {
> - /*
> - * The --passtos and --mssfix options require
> - * us to examine the IPv4 header.
> - */
> -
> - if (flags & (PIP_MSSFIX
> -#if PASSTOS_CAPABILITY
> - | PIPV4_PASSTOS
> -#endif
> - | PIPV4_CLIENT_NAT
> - ))
> + if (flags & PIP_OPT_MASK)
NAK, as this is not the same thing. PIP_OPT_MASK will also match on
the IPv6 flags, which are not something we need to test for here (= if
only an IPv6 flag is active, why should we enter this branch?).
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
