Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/490?usp=email )
Change subject: phase2_tcp_server: fix Coverity issue "Dereference after null
check"
.
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/491?usp=email )
Change subject: buf_string_match_head_str: Fix Coverity issue "Unsigned
compared against 0"
.
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/491?usp=email )
Change subject: buf_string_match_head_str: Fix Coverity issue "Unsigned
compared against 0"
.
From: Frank Lichtenheld
As Coverity says:
An unsigned value can never be negative, so this test will always
evaluate the same way.
Was changed from int to size_t in commit
7fc608da4ec388c9209bd009cd5053ac0ff7df38 which triggered warning,
but the check did not make sense before, either.
Change-I
Arguably coverity is right here :-)
Your patch has been applied to the master and release/2.6 branch (bugfix).
commit bc29bd6a3376158b73d069758122739fbf93c022 (master)
commit 68b00a54e779325f4ac9d9416b4e85261f771c23 (release/2.6)
Author: Frank Lichtenheld
Date: Fri Jan 19 13:03:41 2024 +0100
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/491?usp=email )
Change subject: buf_string_match_head_str: Fix Coverity issue 'Unsigned
compared against 0'
..
buf_string_match_head_str: Fix Coverity iss
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/491?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: buf_string_match_head_str: Fix Coverity issue 'Unsi
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/474?usp=email )
Change subject: test_user_pass: Check fatal errors for empty username/password
...
