Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/490?usp=email )
Change subject: phase2_tcp_server: fix Coverity issue "Dereference after null check" ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/490/comment/49bd721f_a0919cda : PS1, Line 2034: if (signal_received) I do not like checking `signal_received` here if what we're really interested is `sig_info` (I do understand that bother are NULL or none of them, but this way the code is still more confusing than necessary). This said, if we know `sig_info` is never NULL anyway, because there is only a single caller, maybe a better fix would be ``` ASSERT(sig_info); volatile int *signal_received = &sig_info->signal_received; ``` at the beginning of the function. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/490?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8ef199463d46303129a3f563fd9eace780a58b8a Gerrit-Change-Number: 490 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Fri, 19 Jan 2024 08:27:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
